Add ViewModelRegistrationType to IViewFor attribute (#341)

* Add ViewModelRegistrationType to IViewFor attribute

Introduces ViewModelRegistrationType to the IViewFor attribute and updates generator logic to support separate Splat registration for view models. Documentation, tests, and source generator code are updated to reflect the new option and ensure correct registration behavior.

* Add ExcludeFromCodeCoverage to test classes

Added [ExcludeFromCodeCoverage] attribute to various test and sample classes across the project to exclude them from code coverage analysis. This helps ensure that code coverage metrics focus on production code rather than test scaffolding.

* Remove ExcludeFromCodeCoverage attributes from test classes

Deleted the [ExcludeFromCodeCoverage] attribute from several test-related classes to allow code coverage tools to include these files. This change may help improve visibility into test code coverage metrics.

* Fix grouping key in ViewModel registrations

Changed the grouping key from SplatRegistrationType to SplatViewModelRegistrationType in viewModelRegistrations to ensure correct grouping of ViewModel registration types.

* Clarify Splat registration type documentation

Updated XML comments to specify that the ViewModel (T) is registered in the Splat service locator, instead of IViewFor<T>. This improves clarity for consumers of the attribute.

* Update IViewForAttribute XML docs for Splat registration

Clarifies XML documentation to specify that ViewModel (T) is registered in the Splat service locator, instead of IViewFor<T>. Adds new received test file for .NET 10.0 verifying the generated attribute code.

* Skip registrations with empty ViewModelTypeName

Added checks to skip processing registrations where ViewModelTypeName is null, empty, or whitespace. This prevents potential errors from invalid or incomplete registration data.

* Remove unnecessary null/empty check for vmType

Simplifies vmType handling by removing redundant string.IsNullOrEmpty checks before prefixing with 'global::'. This change assumes vmType is always non-null and non-empty at this point in the code.

Author: ChrisPulman

README.md

@@ -560,7 +560,7 @@ The class must inherit from a UI Control from any of the following platforms and
 
 ### IViewFor with Splat Registration Type
 
-Choose from the following Splat Registration Types:
+Choose from the following Splat Registration Types, option for IViewFor Registration and / or ViewModel Registration:
 - `SplatRegistrationType.PerRequest`
 - `SplatRegistrationType.LazySingleton`
 - `SplatRegistrationType.Constant`
@@ -569,7 +569,7 @@ Choose from the following Splat Registration Types:
 ```csharp
 using ReactiveUI.SourceGenerators;
 using Splat;
-[IViewFor<MyReactiveClass>(RegistrationType = SplatRegistrationType.PerRequest)]
+[IViewFor<MyReactiveClass>(RegistrationType = SplatRegistrationType.PerRequest, ViewModelRegistrationType = SplatRegistrationType.LazySingleton)]
 public partial class MyReactiveControl : UserControl
 {
     public MyReactiveControl()

src/ReactiveUI.SourceGenerator.Tests/IVIEWFOR/IViewForGeneratorTests.FromIViewFor#ReactiveUI.SourceGenerators.IViewForAttribute.g.verified.cs

@@ -21,10 +21,16 @@ namespace ReactiveUI.SourceGenerators;
 internal sealed class IViewForAttribute<T> : global::System.Attribute
 {
     /// <summary>
-    /// Gets the Splat registration type for Splat registration.
+    /// Gets the Splat registration type for Splat IViewFor registration.
     /// Registers IViewFor<T> in the Splat service locator.
     /// </summary>
     public SplatRegistrationType RegistrationType { get; init; } = SplatRegistrationType.None;
+
+    /// <summary>
+    /// Gets the Splat registration type for Splat View Model registration.
+    /// Registers the ViewModel (T) in the Splat service locator.
+    /// </summary>
+    public SplatRegistrationType ViewModelRegistrationType { get; init; } = SplatRegistrationType.None;
 }
 
 /// <summary>
@@ -39,10 +45,16 @@ internal sealed class IViewForAttribute<T> : global::System.Attribute
 internal sealed class IViewForAttribute(string? viewModelType) : global::System.Attribute
 {
     /// <summary>
-    /// Gets the Splat registration type for Splat registration.
+    /// Gets the Splat registration type for Splat IViewFor registration.
     /// Registers IViewFor<T> in the Splat service locator.
     /// </summary>
     public SplatRegistrationType RegistrationType { get; init; } = SplatRegistrationType.None;
+
+    /// <summary>
+    /// Gets the Splat registration type for Splat View Model registration.
+    /// Registers the ViewModel (T) in the Splat service locator.
+    /// </summary>
+    public SplatRegistrationType ViewModelRegistrationType { get; init; } = SplatRegistrationType.None;
 }
 #nullable restore
 #pragma warning restore

src/ReactiveUI.SourceGenerator.Tests/TestHelper.cs

@@ -30,19 +30,17 @@ namespace ReactiveUI.SourceGenerator.Tests;
 public sealed class TestHelper<T> : IDisposable
         where T : IIncrementalGenerator, new()
 {
-#pragma warning disable CS0618 // Type or member is obsolete
     /// <summary>
     /// Represents the NuGet library dependency for the Splat library.
     /// </summary>
     private static readonly LibraryRange SplatLibrary =
-        new("Splat", VersionRange.AllStableFloating, LibraryDependencyTarget.Package);
+        new("Splat", VersionRange.AllStable, LibraryDependencyTarget.Package);
 
     /// <summary>
     /// Represents the NuGet library dependency for the ReactiveUI library.
     /// </summary>
     private static readonly LibraryRange ReactiveuiLibrary =
-        new("ReactiveUI", VersionRange.AllStableFloating, LibraryDependencyTarget.Package);
-#pragma warning restore CS0618 // Type or member is obsolete
+        new("ReactiveUI", VersionRange.AllStable, LibraryDependencyTarget.Package);
 
     private static readonly string mscorlibPath = Path.Combine(
             System.Runtime.InteropServices.RuntimeEnvironment.GetRuntimeDirectory(),

src/ReactiveUI.SourceGenerators.Execute.Maui/IViewForTest.cs

@@ -3,6 +3,7 @@
 // The ReactiveUI and contributors licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for full license information.
 
+using System.Diagnostics.CodeAnalysis;
 using ReactiveUI.SourceGenerators;
 
 namespace SGReactiveUI.SourceGenerators.Test.Maui

src/ReactiveUI.SourceGenerators.Execute.Maui/TestViewModel.cs

@@ -3,6 +3,7 @@
 // The ReactiveUI and contributors licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for full license information.
 
+using System.Diagnostics.CodeAnalysis;
 using System.Reactive;
 using System.Reactive.Linq;
 using System.Runtime.Serialization;
@@ -15,6 +16,7 @@ namespace SGReactiveUI.SourceGenerators.Test;
 /// <summary>
 /// TestClass.
 /// </summary>
+[ExcludeFromCodeCoverage]
 [DataContract]
 public partial class TestViewModel : ReactiveObject
 {

src/ReactiveUI.SourceGenerators.Execute.Nested1/Class1.cs

@@ -3,6 +3,7 @@
 // The ReactiveUI and contributors licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for full license information.
 
+using System.Diagnostics.CodeAnalysis;
 using ReactiveUI;
 using ReactiveUI.SourceGenerators;
 
@@ -11,6 +12,7 @@ namespace SGReactiveUI.SourceGenerators.Execute.Nested1;
 /// <summary>
 /// Class1.
 /// </summary>
+[ExcludeFromCodeCoverage]
 public partial class Class1 : ReactiveObject
 {
     [Reactive]

src/ReactiveUI.SourceGenerators.Execute.Nested2/Class1.cs

@@ -3,6 +3,7 @@
 // The ReactiveUI and contributors licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for full license information.
 
+using System.Diagnostics.CodeAnalysis;
 using ReactiveUI;
 using ReactiveUI.SourceGenerators;
 
@@ -11,6 +12,7 @@ namespace SGReactiveUI.SourceGenerators.Execute.Nested2;
 /// <summary>
 /// Class1.
 /// </summary>
+[ExcludeFromCodeCoverage]
 public partial class Class1 : ReactiveObject
 {
     [Reactive]

src/ReactiveUI.SourceGenerators.Execute.Nested3/Class1.cs

@@ -3,6 +3,7 @@
 // The ReactiveUI and contributors licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for full license information.
 
+using System.Diagnostics.CodeAnalysis;
 using ReactiveUI;
 using ReactiveUI.SourceGenerators;
 
@@ -11,6 +12,7 @@ namespace SGReactiveUI.SourceGenerators.Execute.Nested3;
 /// <summary>
 /// Class1.
 /// </summary>
+[ExcludeFromCodeCoverage]
 public partial class Class1 : ReactiveObject
 {
     [Reactive]

src/ReactiveUI.SourceGenerators.Execute/InternalTestViewModel.cs

@@ -4,11 +4,13 @@
 // See the LICENSE file in the project root for full license information.
 
 using System.Collections.ObjectModel;
+using System.Diagnostics.CodeAnalysis;
 using ReactiveUI;
 using ReactiveUI.SourceGenerators;
 
 namespace SGReactiveUI.SourceGenerators.Test;
 
+[ExcludeFromCodeCoverage]
 internal partial class InternalTestViewModel : ReactiveObject
 {
     [ReactiveCollection]

src/ReactiveUI.SourceGenerators.Execute/Person.cs

@@ -3,6 +3,7 @@
 // The ReactiveUI and contributors licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for full license information.
 
+using System.Diagnostics.CodeAnalysis;
 using ReactiveUI;
 using ReactiveUI.SourceGenerators;
 
@@ -12,6 +13,7 @@ namespace SGReactiveUI.SourceGenerators.Test;
 /// Person.
 /// </summary>
 /// <seealso cref="ReactiveUI.ReactiveObject" />
+[ExcludeFromCodeCoverage]
 public partial class Person : ReactiveObject
 {
     /// <summary>