chore: remove SyntaxFactory to improve performance and maintainability (#103)

* Update OAPH From Observable

* Update formatting

Author: ChrisPulman

src/ReactiveUI.SourceGenerator.Tests/OAPH/OAPFromObservableGeneratorTests.FromObservableMethods#TestNs.TestVM.ObservableAsPropertyFromObservable.g.verified.cs renamed to src/ReactiveUI.SourceGenerator.Tests/OAPH/OAPFromObservableGeneratorTests.FromObservableMethods#TestVM.ObservableAsPropertyFromObservable.g.verified.cs

@@ -1,21 +1,25 @@
-//HintName: TestNs.TestVM.ObservableAsPropertyFromObservable.g.cs
-using ReactiveUI;
+//HintName: TestVM.ObservableAsPropertyFromObservable.g.cs
 // <auto-generated/>
+using ReactiveUI;
+
 #pragma warning disable
 #nullable enable
+
 namespace TestNs
 {
-    /// <inheritdoc/>
-    partial class TestVM
+    /// <summary>
+    /// Partial class for the TestVM which contains ReactiveUI Reactive property initialization.
+    /// </summary>
+    public partial class TestVM
     {
-        /// <inheritdoc cref="Test2Property"/>
         [global::System.CodeDom.Compiler.GeneratedCode("ReactiveUI.SourceGenerators.ObservableAsPropertyGenerator", "1.1.0.0")]
+        /// <inheritdoc cref="Test2Property"/>
         private int _test2Property;
+
         /// <inheritdoc cref="_test2PropertyHelper"/>
-        [global::System.CodeDom.Compiler.GeneratedCode("ReactiveUI.SourceGenerators.ObservableAsPropertyGenerator", "1.1.0.0")]
         private ReactiveUI.ObservableAsPropertyHelper<int>? _test2PropertyHelper;
+
         /// <inheritdoc cref="_test2Property"/>
-        [global::System.CodeDom.Compiler.GeneratedCode("ReactiveUI.SourceGenerators.ObservableAsPropertyGenerator", "1.1.0.0")]
         [global::System.Diagnostics.CodeAnalysis.ExcludeFromCodeCoverage]
         public int Test2Property { get => _test2Property = _test2PropertyHelper?.Value ?? _test2Property; }
 
@@ -26,4 +30,6 @@ protected void InitializeOAPH()
             _test2PropertyHelper = Test2()!.ToProperty(this, nameof(Test2Property));
         }
     }
-}
+}
+#nullable restore
+#pragma warning restore

src/ReactiveUI.SourceGenerator.Tests/OAPH/OAPFromObservableGeneratorTests.FromObservableMethodsWithName#TestNs.TestVM.ObservableAsPropertyFromObservable.g.verified.cs renamed to src/ReactiveUI.SourceGenerator.Tests/OAPH/OAPFromObservableGeneratorTests.FromObservableMethodsWithName#TestVM.ObservableAsPropertyFromObservable.g.verified.cs

@@ -1,21 +1,25 @@
-//HintName: TestNs.TestVM.ObservableAsPropertyFromObservable.g.cs
-using ReactiveUI;
+//HintName: TestVM.ObservableAsPropertyFromObservable.g.cs
 // <auto-generated/>
+using ReactiveUI;
+
 #pragma warning disable
 #nullable enable
+
 namespace TestNs
 {
-    /// <inheritdoc/>
-    partial class TestVM
+    /// <summary>
+    /// Partial class for the TestVM which contains ReactiveUI Reactive property initialization.
+    /// </summary>
+    public partial class TestVM
     {
-        /// <inheritdoc cref="Test3Property"/>
         [global::System.CodeDom.Compiler.GeneratedCode("ReactiveUI.SourceGenerators.ObservableAsPropertyGenerator", "1.1.0.0")]
+        /// <inheritdoc cref="Test3Property"/>
         private int _test3Property;
+
         /// <inheritdoc cref="_test3PropertyHelper"/>
-        [global::System.CodeDom.Compiler.GeneratedCode("ReactiveUI.SourceGenerators.ObservableAsPropertyGenerator", "1.1.0.0")]
         private ReactiveUI.ObservableAsPropertyHelper<int>? _test3PropertyHelper;
+
         /// <inheritdoc cref="_test3Property"/>
-        [global::System.CodeDom.Compiler.GeneratedCode("ReactiveUI.SourceGenerators.ObservableAsPropertyGenerator", "1.1.0.0")]
         [global::System.Diagnostics.CodeAnalysis.ExcludeFromCodeCoverage]
         public int Test3Property { get => _test3Property = _test3PropertyHelper?.Value ?? _test3Property; }
 
@@ -26,4 +30,6 @@ protected void InitializeOAPH()
             _test3PropertyHelper = Test3()!.ToProperty(this, nameof(Test3Property));
         }
     }
-}
+}
+#nullable restore
+#pragma warning restore

src/ReactiveUI.SourceGenerator.Tests/OAPH/OAPFromObservableGeneratorTests.FromObservableProp#TestNs.TestVM.ObservableAsPropertyFromObservable.g.verified.cs renamed to src/ReactiveUI.SourceGenerator.Tests/OAPH/OAPFromObservableGeneratorTests.FromObservableProp#TestVM.ObservableAsPropertyFromObservable.g.verified.cs

@@ -1,21 +1,25 @@
-//HintName: TestNs.TestVM.ObservableAsPropertyFromObservable.g.cs
-using ReactiveUI;
+//HintName: TestVM.ObservableAsPropertyFromObservable.g.cs
 // <auto-generated/>
+using ReactiveUI;
+
 #pragma warning disable
 #nullable enable
+
 namespace TestNs
 {
-    /// <inheritdoc/>
-    partial class TestVM
+    /// <summary>
+    /// Partial class for the TestVM which contains ReactiveUI Reactive property initialization.
+    /// </summary>
+    public partial class TestVM
     {
-        /// <inheritdoc cref="Test1Property"/>
         [global::System.CodeDom.Compiler.GeneratedCode("ReactiveUI.SourceGenerators.ObservableAsPropertyGenerator", "1.1.0.0")]
+        /// <inheritdoc cref="Test1Property"/>
         private int _test1Property;
+
         /// <inheritdoc cref="_test1PropertyHelper"/>
-        [global::System.CodeDom.Compiler.GeneratedCode("ReactiveUI.SourceGenerators.ObservableAsPropertyGenerator", "1.1.0.0")]
         private ReactiveUI.ObservableAsPropertyHelper<int>? _test1PropertyHelper;
+
         /// <inheritdoc cref="_test1Property"/>
-        [global::System.CodeDom.Compiler.GeneratedCode("ReactiveUI.SourceGenerators.ObservableAsPropertyGenerator", "1.1.0.0")]
         [global::System.Diagnostics.CodeAnalysis.ExcludeFromCodeCoverage]
         public int Test1Property { get => _test1Property = _test1PropertyHelper?.Value ?? _test1Property; }
 
@@ -26,4 +30,6 @@ protected void InitializeOAPH()
             _test1PropertyHelper = Test1!.ToProperty(this, nameof(Test1Property));
         }
     }
-}
+}
+#nullable restore
+#pragma warning restore

src/ReactiveUI.SourceGenerator.Tests/OAPH/OAPFromObservableGeneratorTests.FromObservablePropertiesWithAttribute#ReactiveUI.SourceGenerators.ObservableAsPropertyAttribute.g.verified.cs

@@ -0,0 +1,39 @@
+//HintName: ReactiveUI.SourceGenerators.ObservableAsPropertyAttribute.g.cs
+// Copyright (c) 2024 .NET Foundation and Contributors. All rights reserved.
+// Licensed to the .NET Foundation under one or more agreements.
+// The .NET Foundation licenses this file to you under the MIT license.
+// See the LICENSE file in the project root for full license information.
+
+using System;
+
+// <auto-generated/>
+#pragma warning disable
+#nullable enable
+namespace ReactiveUI.SourceGenerators;
+
+/// <summary>
+/// ObservableAsPropertyAttribute.
+/// </summary>
+/// <seealso cref="Attribute" />
+[global::System.CodeDom.Compiler.GeneratedCode("ReactiveUI.SourceGenerators.ObservableAsPropertyGenerator", "1.1.0.0")]
+[AttributeUsage(AttributeTargets.Field | AttributeTargets.Property | AttributeTargets.Method, AllowMultiple = false, Inherited = false)]
+internal sealed class ObservableAsPropertyAttribute : Attribute
+{
+    /// <summary>
+    /// Gets the name of the property.
+    /// </summary>
+    /// <value>
+    /// The name of the property.
+    /// </value>
+    public string? PropertyName { get; init; }
+
+    /// <summary>
+    /// Gets the Readonly state of the OAPH property.
+    /// </summary>
+    /// <value>
+    /// The is read only of the OAPH property.
+    /// </value>
+    public bool ReadOnly { get; init; } = true;
+}
+#nullable restore
+#pragma warning restore

src/ReactiveUI.SourceGenerator.Tests/OAPH/OAPFromObservableGeneratorTests.FromObservablePropertiesWithAttribute#TestVM.ObservableAsPropertyFromObservable.g.verified.cs

@@ -0,0 +1,36 @@
+//HintName: TestVM.ObservableAsPropertyFromObservable.g.cs
+// <auto-generated/>
+using ReactiveUI;
+
+#pragma warning disable
+#nullable enable
+
+namespace TestNs
+{
+    /// <summary>
+    /// Partial class for the TestVM which contains ReactiveUI Reactive property initialization.
+    /// </summary>
+    public partial class TestVM
+    {
+        [global::System.CodeDom.Compiler.GeneratedCode("ReactiveUI.SourceGenerators.ObservableAsPropertyGenerator", "1.1.0.0")]
+        /// <inheritdoc cref="Test5Property"/>
+        private int _test5Property;
+
+        /// <inheritdoc cref="_test5PropertyHelper"/>
+        private ReactiveUI.ObservableAsPropertyHelper<int>? _test5PropertyHelper;
+
+        /// <inheritdoc cref="_test5Property"/>
+        [global::System.Diagnostics.CodeAnalysis.ExcludeFromCodeCoverage]
+        [global::System.Text.Json.Serialization.JsonIncludeAttribute()]
+        public int Test5Property { get => _test5Property = _test5PropertyHelper?.Value ?? _test5Property; }
+
+        [global::System.CodeDom.Compiler.GeneratedCode("ReactiveUI.SourceGenerators.ObservableAsPropertyGenerator", "1.1.0.0")]
+        [global::System.Diagnostics.CodeAnalysis.ExcludeFromCodeCoverage]
+        protected void InitializeOAPH()
+        {
+            _test5PropertyHelper = Test5!.ToProperty(this, nameof(Test5Property));
+        }
+    }
+}
+#nullable restore
+#pragma warning restore

src/ReactiveUI.SourceGenerator.Tests/OAPH/OAPFromObservableGeneratorTests.FromObservablePropertiesWithName#TestNs.TestVM.ObservableAsPropertyFromObservable.g.verified.cs renamed to src/ReactiveUI.SourceGenerator.Tests/OAPH/OAPFromObservableGeneratorTests.FromObservablePropertiesWithName#TestVM.ObservableAsPropertyFromObservable.g.verified.cs

@@ -1,21 +1,25 @@
-//HintName: TestNs.TestVM.ObservableAsPropertyFromObservable.g.cs
-using ReactiveUI;
+//HintName: TestVM.ObservableAsPropertyFromObservable.g.cs
 // <auto-generated/>
+using ReactiveUI;
+
 #pragma warning disable
 #nullable enable
+
 namespace TestNs
 {
-    /// <inheritdoc/>
-    partial class TestVM
+    /// <summary>
+    /// Partial class for the TestVM which contains ReactiveUI Reactive property initialization.
+    /// </summary>
+    public partial class TestVM
     {
-        /// <inheritdoc cref="Test4Property"/>
         [global::System.CodeDom.Compiler.GeneratedCode("ReactiveUI.SourceGenerators.ObservableAsPropertyGenerator", "1.1.0.0")]
+        /// <inheritdoc cref="Test4Property"/>
         private int _test4Property;
+
         /// <inheritdoc cref="_test4PropertyHelper"/>
-        [global::System.CodeDom.Compiler.GeneratedCode("ReactiveUI.SourceGenerators.ObservableAsPropertyGenerator", "1.1.0.0")]
         private ReactiveUI.ObservableAsPropertyHelper<int>? _test4PropertyHelper;
+
         /// <inheritdoc cref="_test4Property"/>
-        [global::System.CodeDom.Compiler.GeneratedCode("ReactiveUI.SourceGenerators.ObservableAsPropertyGenerator", "1.1.0.0")]
         [global::System.Diagnostics.CodeAnalysis.ExcludeFromCodeCoverage]
         public int Test4Property { get => _test4Property = _test4PropertyHelper?.Value ?? _test4Property; }
 
@@ -26,4 +30,6 @@ protected void InitializeOAPH()
             _test4PropertyHelper = Test4!.ToProperty(this, nameof(Test4Property));
         }
     }
-}
+}
+#nullable restore
+#pragma warning restore

src/ReactiveUI.SourceGenerator.Tests/UnitTests/OAPFromObservableGeneratorTests.cs

@@ -133,4 +133,38 @@ public partial class TestVM : ReactiveObject
         // Assert: Verify the generated code.
         return Verify(driver).UseDirectory(TestHelper.VerifiedFilePath());
     }
+
+    /// <summary>
+    /// Tests that the source generator correctly generates observable properties.
+    /// </summary>
+    /// <returns>A task to monitor the async.</returns>
+    [Fact]
+    public Task FromObservablePropertiesWithAttribute()
+    {
+        // Arrange: Setup the source code that matches the generator input expectations.
+        const string sourceCode = """
+                using System;
+                using System.Runtime.Serialization;
+                using System.Text.Json.Serialization;
+                using ReactiveUI;
+                using ReactiveUI.SourceGenerators;
+                using System.Reactive.Linq;
+
+                namespace TestNs;
+
+                public partial class TestVM : ReactiveObject
+                {
+                    [ObservableAsProperty(PropertyName = "MyNamedProperty")]
+                    [property: JsonInclude]
+                    [DataMember]
+                    public IObservable<int> Test5 => Observable.Return(42);
+                }
+            """;
+
+        // Act: Initialize the helper and run the generator.
+        var driver = TestHelper.TestPass(sourceCode);
+
+        // Assert: Verify the generated code.
+        return Verify(driver).UseDirectory(TestHelper.VerifiedFilePath());
+    }
 }

src/ReactiveUI.SourceGenerators.Execute/TestViewModel.cs

@@ -27,7 +27,7 @@ public partial class TestViewModel : ReactiveObject, IActivatableViewModel, IDis
     private readonly Subject<double?> _testSubject = new();
     private readonly Subject<double> _testNonNullSubject = new();
 
-    [JsonInclude]
+    [property: JsonInclude]
     [DataMember]
     [ObservableAsProperty]
     private double? _test2Property = 1.1d;
@@ -226,6 +226,7 @@ public TestViewModel()
     /// The observable as property test2.
     /// </value>
     [ObservableAsProperty]
+    [property: Test(AParameter = "Test Input")]
     public IObservable<int> ObservableAsPropertyTest2 => Observable.Return(9);
 
     /// <summary>

src/ReactiveUI.SourceGenerators/AttributeDefinitions.cs

@@ -16,7 +16,6 @@ internal static class AttributeDefinitions
 
     public const string AccessModifierType = "ReactiveUI.SourceGenerators.AccessModifier";
     public static string[] ExcludeFromCodeCoverage = ["[global::System.Diagnostics.CodeAnalysis.ExcludeFromCodeCoverage]"];
-    public static string ExcludeFromCodeCoverageString = "global::System.Diagnostics.CodeAnalysis.ExcludeFromCodeCoverage";
 
     public static string GetAccessModifierEnum() => $$"""
         // Copyright (c) {{DateTime.Now.Year}} .NET Foundation and Contributors. All rights reserved.

src/ReactiveUI.SourceGenerators/IViewFor/IViewForGenerator.Execute.cs

@@ -97,7 +97,7 @@ public partial class IViewForGenerator
 
         token.ThrowIfCancellationRequested();
 
-        return new IViewForInfo(
+        return new(
             targetInfo.FileHintName,
             targetInfo.TargetName,
             targetInfo.TargetNamespace,