-
-
Notifications
You must be signed in to change notification settings - Fork 6
Open
Labels
bugSomething isn't workingSomething isn't working
Description
Describe the bug 🐞
Trying to convert my system over to use the new SourceGenerator nuget package instead of the ReactiveUI Fody nuget package.
Removed Fody assembly from references
Added the ReactiveUI.SourceGenerators nuget to the project
Tried to build and got hundreds of these errors
Step to reproduce
- Open a project that was created using ReactiveUI.Fody and that is currently working correctly
- Confirm the project is set to use
<TargetFramework>net8.0-windows10.0.26100.0</TargetFramework> - Confirm the project is set to use
<LangVersion>preview</LangVersion> - Remove Fody nuget reference
- Add ReactiveUI.SourceGenerators nuget package reference
- Open class that inherits from ReactiveObject
- [Mod to steps]
- I forgot to add the step,
- Set the class and the properties that have the Reactive attribute to bepartial
- Clean Solution
- close Visual Studio and clean up all the build artifacts (bin / obj / debug, etc artifacts)
- Reopen Visual Studio and the solution
- Try to build
- You get errors everywhere the [Reactive] attribute is declared with an error or
'ReactiveAttribute' is inaccessible due to its protection level - Right mouse click on an instance where the error is shown for
[Reactive]attribute and select "Go to definition" - The ReactiveUI.SourceGenerator is generating the ReactiveAttribute as an
internal sealedclass.
Reproduction repository
https://github.com/reactiveui/ReactiveUI
Expected behavior
I should complete steps 1 thru 8 successfully and then when open and built, the errors should show up only for those properties that don't match the new format system for the Reactive attribute usage
Screenshots 🖼️
No response
IDE
Visual Studio 2022
Operating system
Windows11 - 10.0.26200.7171
Version
No response
Device
Microsoft Surface Book
ReactiveUI Version
22.3.1 SourceGenerators - 2.5.1
Additional information ℹ️
No response
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working