Housekeeping Code Clean up (#244)

Author: ChrisPulman

LICENSE

@@ -1,6 +1,6 @@
 The MIT License (MIT)
 
-Copyright (c) .NET Foundation and Contributors
+Copyright (c) ReactiveUI 2021 - 2025
 
 All rights reserved.
 

src/ReactiveUI.Uno.WinUI/DispatcherQueueScheduler.cs

@@ -13,7 +13,7 @@ namespace System.Reactive.Concurrency;
 /// <summary>
 /// Represents an object that schedules units of work on a <see cref="Microsoft.UI.Dispatching.DispatcherQueue"/>.
 /// </summary>
-public class DispatcherQueueScheduler : LocalScheduler, ISchedulerPeriodic
+public partial class DispatcherQueueScheduler : LocalScheduler, ISchedulerPeriodic
 {
     /// <summary>
     /// Gets the scheduler that schedules work on the <see cref="Microsoft.UI.Dispatching.DispatcherQueue"/> for the current thread.

src/ReactiveUI.Uno.WinUI/ReactiveUI.Uno.WinUI.csproj

@@ -5,6 +5,7 @@
     <PackageDescription>Contains the ReactiveUI platform specific extensions for Uno WinUI</PackageDescription>
     <DefineConstants>$(DefineConstants);HAS_WINUI</DefineConstants>
     <PackageTags>$(PackageTags);winui</PackageTags>
+    <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
   </PropertyGroup>
 
   <PropertyGroup Condition="$(TargetFramework.EndsWith('0-windows10.0.19041.0'))">

src/ReactiveUI.Uno/Common/AutoDataTemplateBindingHook.cs

@@ -31,9 +31,11 @@ public class AutoDataTemplateBindingHook : IPropertyBindingHook
     public static Lazy<DataTemplate> DefaultItemTemplate { get; } = new(() =>
     {
         const string template =
-@"<DataTemplate xmlns='http://schemas.microsoft.com/winfx/2006/xaml/presentation' xmlns:xaml='using:ReactiveUI'>
-    <xaml:ViewModelViewHost ViewModel=""{Binding}"" VerticalContentAlignment=""Stretch"" HorizontalContentAlignment=""Stretch"" IsTabStop=""False"" />
-</DataTemplate>";
+"""
+<DataTemplate xmlns='http://schemas.microsoft.com/winfx/2006/xaml/presentation' xmlns:xaml='using:ReactiveUI'>
+    <xaml:ViewModelViewHost ViewModel="{Binding}" VerticalContentAlignment="Stretch" HorizontalContentAlignment="Stretch" IsTabStop="False" />
+</DataTemplate>
+""";
         return (DataTemplate)XamlReader.Load(template);
     });
 
@@ -55,7 +57,7 @@ public bool ExecuteHook(object? source, object target, Func<IObservedChange<obje
             return true;
         }
 
-        if (viewProperties.Last().GetPropertyName() != "ItemsSource")
+        if (viewProperties[^1].GetPropertyName() != "ItemsSource")
         {
             return true;
         }

src/ReactiveUI.Uno/Common/ReactivePage.cs

@@ -90,7 +90,7 @@ public partial class ReactivePage<TViewModel> :
     /// </summary>
     public static readonly DependencyProperty ViewModelProperty =
         DependencyProperty.Register(
-            "ViewModel",
+            nameof(ViewModel),
             typeof(TViewModel),
             typeof(ReactivePage<TViewModel>),
             new PropertyMetadata(null));

src/ReactiveUI.Uno/Common/ReactiveUserControl.cs

@@ -90,7 +90,7 @@ public partial class ReactiveUserControl<TViewModel> :
     /// </summary>
     public static readonly DependencyProperty ViewModelProperty =
         DependencyProperty.Register(
-            "ViewModel",
+            nameof(ViewModel),
             typeof(TViewModel),
             typeof(ReactiveUserControl<TViewModel>),
             new PropertyMetadata(null));

src/ReactiveUI.Uno/Common/RoutedViewHost.cs

@@ -86,14 +86,13 @@ public RoutedViewHost()
             (viewModel, contract) => (viewModel, contract));
 
         this.WhenActivated(d =>
-        {
+
             // NB: The DistinctUntilChanged is useful because most views in
             // WinRT will end up getting here twice - once for configuring
             // the RoutedViewHost's ViewModel, and once on load via SizeChanged
             d(vmAndContract.DistinctUntilChanged<(IRoutableViewModel? viewModel, string? contract)>().Subscribe(
                 ResolveViewForViewModel,
-                ex => RxApp.DefaultExceptionHandler.OnNext(ex)));
-        });
+                ex => RxApp.DefaultExceptionHandler.OnNext(ex))));
     }
 
     /// <summary>

src/ReactiveUI.Uno/TransitioningContentControl.Empty.cs

@@ -14,6 +14,4 @@ namespace ReactiveUI.Uno;
 /// <summary>
 /// A control with a single transition.
 /// </summary>
-public partial class TransitioningContentControl : ContentControl
-{
-}
+public partial class TransitioningContentControl : ContentControl;