Fix StyleCop errors and update NuGet packages

- Removed SA1600, SA1513, SA1028, RCS1037 from NoWarn suppressions
- Added documentation for SetUp and TearDown methods
- Fixed trailing whitespace in PropertyValidationTests.cs
- Added blank lines after closing braces per SA1513
- Updated NuGet packages:
  - Nerdbank.GitVersioning: 3.7.115 → 3.8.118
  - Roslynator.Analyzers: 4.14.0 → 4.14.1
  - System.Collections.Immutable: 9.0.8 → 9.0.9
  - Microsoft.NET.Test.Sdk: 17.14.1 → 18.0.0
  - Microsoft.Reactive.Testing: 6.0.2 → 6.1.0
- Kept ReactiveUI at 21.0.1 (22.0.1 introduces breaking changes)
- All tests passing

Co-authored-by: glennawatson <[email protected]>

Author: Copilot

src/Directory.Build.props

@@ -65,9 +65,9 @@
 		<PackageReference Include="Microsoft.SourceLink.GitHub" Version="8.0.0" PrivateAssets="All" />
 	</ItemGroup>
 	<ItemGroup>
-		<PackageReference Include="Nerdbank.GitVersioning" Version="3.7.115" PrivateAssets="all" />
+		<PackageReference Include="Nerdbank.GitVersioning" Version="3.8.118" PrivateAssets="all" />
 		<PackageReference Include="stylecop.analyzers" Version="1.2.0-beta.556" PrivateAssets="all" />
-		<PackageReference Include="Roslynator.Analyzers" Version="4.14.0" PrivateAssets="All" />
+		<PackageReference Include="Roslynator.Analyzers" Version="4.14.1" PrivateAssets="All" />
 	</ItemGroup>
 	<ItemGroup>
 		<AdditionalFiles Include="$(MSBuildThisFileDirectory)stylecop.json" Link="stylecop.json" />

src/ReactiveUI.Validation.Tests/MemoryLeakTests.cs

@@ -16,6 +16,9 @@ namespace ReactiveUI.Validation.Tests;
 [TestFixture]
 public class MemoryLeakTests
 {
+    /// <summary>
+    /// Sets up the test fixtures.
+    /// </summary>
     [SetUp]
     public void SetUp()
     {

src/ReactiveUI.Validation.Tests/ObservableValidationTests.cs

@@ -24,6 +24,9 @@ public class ObservableValidationTests
     private ReplaySubject<bool> _validState = default!;
     private TestViewModel _validModel = default!;
 
+    /// <summary>
+    /// Sets up the test fixtures.
+    /// </summary>
     [SetUp]
     public void SetUp()
     {
@@ -35,6 +38,9 @@ public void SetUp()
         };
     }
 
+    /// <summary>
+    /// Tears down the test fixtures.
+    /// </summary>
     [TearDown]
     public void TearDown()
     {
@@ -206,6 +212,7 @@ public void ShouldResolveTypedProperties()
             Assert.That(component.ContainsProperty<TestViewModel, string>(model => model.Name2), Is.False);
             Assert.That(component.ContainsProperty<TestViewModel, string>(model => model.Name2, true), Is.False);
         }
+
         Assert.Throws<ArgumentNullException>(() => component.ContainsProperty<TestViewModel, string>(null!));
     }
 

src/ReactiveUI.Validation.Tests/PropertyValidationTests.cs

@@ -124,7 +124,7 @@ public void MessageUpdatedWhenPropertyChanged()
 
         var expectedState1 = new ValidationState(false, "The value 'bongo' is incorrect");
         var comparer = new ValidationStateComparer();
-        
+
         using (Assert.EnterMultipleScope())
         {
             Assert.That(validation.Text?.ToSingleLine(), Is.EqualTo("The value 'bongo' is incorrect"));

src/ReactiveUI.Validation.Tests/ReactiveUI.Validation.Tests.csproj

@@ -2,7 +2,7 @@
 
   <PropertyGroup>
     <TargetFrameworks>$(TestTargetFrameworks)</TargetFrameworks>
-    <NoWarn>$(NoWarn);1591;CA1707;SA1633;SA1600;SA1513;SA1028;RCS1037</NoWarn>
+    <NoWarn>$(NoWarn);1591;CA1707;SA1633</NoWarn>
     <Nullable>disable</Nullable>
   </PropertyGroup>
 
@@ -11,11 +11,11 @@
   </ItemGroup>
 
   <ItemGroup>
-    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.*" />
+    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.0.0" />
     <PackageReference Include="NUnit" Version="4.4.0" />
     <PackageReference Include="NUnit3TestAdapter" Version="5.*" />
     <PackageReference Include="NUnit.Analyzers" Version="4.10.0" />
-    <PackageReference Include="Microsoft.Reactive.Testing" Version="6.0.2" />
+    <PackageReference Include="Microsoft.Reactive.Testing" Version="6.1.0" />
     <PackageReference Include="PublicApiGenerator" Version="11.4.6" />
     <PackageReference Include="Verify.NUnit" Version="31.0.1" />
     <PackageReference Include="coverlet.msbuild" Version="6.0.4">

src/ReactiveUI.Validation.Tests/ValidationContextTests.cs

@@ -234,6 +234,7 @@ public void ShouldClearAttachedValidationRulesForTheGivenProperty()
             Assert.That(viewModel.ValidationContext.IsValid, Is.False);
             Assert.That(viewModel.ValidationContext.Text, Is.Not.Empty);
         }
+
         Assert.Throws<ArgumentNullException>(() => viewModel.ClearValidationRules<TestViewModel, string>(null!));
 
         viewModel.ClearValidationRules(x => x.Name);

src/ReactiveUI.Validation/ReactiveUI.Validation.csproj

@@ -11,6 +11,6 @@
   </ItemGroup>
 
   <ItemGroup Condition="$(TargetFramework.StartsWith('netstandard')) or $(TargetFramework.StartsWith('net4'))">
-    <PackageReference Include="System.Collections.Immutable" Version="9.0.8" />
+    <PackageReference Include="System.Collections.Immutable" Version="9.0.9" />
   </ItemGroup>
 </Project>