Skip to content

Commit 5fc021a

Browse files
committed
Fix remaining RoutingState constructors to use ImmediateScheduler
- Fixed RoutedViewHostTests.cs (WPF) missing scheduler parameter - Fixed WinFormsRoutedViewHostTests.cs (3 instances) missing scheduler parameter - Fixed AdvancedAOTTests.cs missing scheduler parameter - Ensures all test RoutingState instances execute synchronously preventing async hangs - All 6,155 tests passing
1 parent 2d3f769 commit 5fc021a

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

src/tests/ReactiveUI.AOTTests/AdvancedAOTTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ public class AdvancedAOTTests
2828
[Test]
2929
public async Task RoutingState_Navigation_WorksInAOT()
3030
{
31-
var routingState = new RoutingState();
31+
var routingState = new RoutingState(ImmediateScheduler.Instance);
3232
var viewModel = new TestRoutableViewModel();
3333

3434
// Test navigation

src/tests/ReactiveUI.WinForms.Tests/winforms/WinFormsRoutedViewHostTests.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ public class WinFormsRoutedViewHostTests
1717
public async Task ShouldDisposePreviousView()
1818
{
1919
var viewLocator = new FakeViewLocator { LocatorFunc = _ => new FakeWinformsView() };
20-
var router = new RoutingState();
20+
var router = new RoutingState(ImmediateScheduler.Instance);
2121
var target = new WinFormsRoutedViewHost { Router = router, ViewLocator = viewLocator };
2222
router?.Navigate?.Execute(new FakeWinformViewModel());
2323

@@ -36,7 +36,7 @@ public async Task ShouldSetDefaultContentWhenViewModelIsNull()
3636
{
3737
var defaultContent = new Control();
3838
var viewLocator = new FakeViewLocator { LocatorFunc = static _ => new FakeWinformsView() };
39-
var router = new RoutingState();
39+
var router = new RoutingState(ImmediateScheduler.Instance);
4040
var target = new WinFormsRoutedViewHost
4141
{
4242
Router = router,
@@ -51,7 +51,7 @@ public async Task ShouldSetDefaultContentWhenViewModelIsNull()
5151
public async Task WhenRoutedToViewModelItShouldAddViewToControls()
5252
{
5353
var viewLocator = new FakeViewLocator { LocatorFunc = static _ => new FakeWinformsView() };
54-
var router = new RoutingState();
54+
var router = new RoutingState(ImmediateScheduler.Instance);
5555
var target = new WinFormsRoutedViewHost { Router = router, ViewLocator = viewLocator };
5656
router?.Navigate?.Execute(new FakeWinformViewModel());
5757

src/tests/ReactiveUI.Wpf.Tests/Xaml/RoutedViewHostTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ public async Task RoutedViewHostDefaultContentNotNullWithViewModelAndActivated()
8585
[TestExecutor<WpfWithViewAndRoutingExecutor>]
8686
public async Task RoutedViewHostDefaultContentNotNullWithViewModelAndNotActivated()
8787
{
88-
var router = new RoutingState();
88+
var router = new RoutingState(ImmediateScheduler.Instance);
8989
var viewModel = new TestViewModel();
9090

9191
var uc = new RoutedViewHost

0 commit comments

Comments
 (0)