fix: Update nullability, pick dependencies (#2720)

* build(deps): bump Xamarin.AndroidX.Fragment in /src

Bumps [Xamarin.AndroidX.Fragment](https://github.com/xamarin/AndroidX) from 1.3.0.1 to 1.3.1.
- [Release notes](https://github.com/xamarin/AndroidX/releases)
- [Commits](https://github.com/xamarin/AndroidX/commits)

Signed-off-by: dependabot[bot] <[email protected]>

* build(deps): bump DiffEngine from 6.5.7 to 6.6.1 in /src

Bumps [DiffEngine](https://github.com/VerifyTests/DiffEngine) from 6.5.7 to 6.6.1.
- [Release notes](https://github.com/VerifyTests/DiffEngine/releases)
- [Commits](VerifyTests/DiffEngine@6.5.7...6.6.1)

Signed-off-by: dependabot[bot] <[email protected]>

* build(deps): bump Acr.UserDialogs in /integrationtests

Bumps [Acr.UserDialogs](https://github.com/aritchie/userdialogs) from 7.1.0.481 to 7.1.0.483.
- [Release notes](https://github.com/aritchie/userdialogs/releases)
- [Commits](https://github.com/aritchie/userdialogs/commits)

Signed-off-by: dependabot[bot] <[email protected]>

* build(deps): bump Fody from 6.4.0 to 6.5.0 in /src

Bumps [Fody](https://github.com/Fody/Fody) from 6.4.0 to 6.5.0.
- [Release notes](https://github.com/Fody/Fody/releases)
- [Commits](Fody/Fody@6.4.0...6.5.0)

Signed-off-by: dependabot[bot] <[email protected]>

* build(deps): bump FodyPackaging from 6.4.0 to 6.5.0 in /src

Bumps [FodyPackaging](https://github.com/Fody/Fody) from 6.4.0 to 6.5.0.
- [Release notes](https://github.com/Fody/Fody/releases)
- [Commits](Fody/Fody@6.4.0...6.5.0)

Signed-off-by: dependabot[bot] <[email protected]>

* build(deps): bump FodyHelpers from 6.4.0 to 6.5.0 in /src

Bumps [FodyHelpers](https://github.com/Fody/Fody) from 6.4.0 to 6.5.0.
- [Release notes](https://github.com/Fody/Fody/releases)
- [Commits](Fody/Fody@6.4.0...6.5.0)

Signed-off-by: dependabot[bot] <[email protected]>

* Command binder nullability hint

* Fix a few more nullability issues

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Author: worldbeater

integrationtests/IntegrationTests.XamarinForms.Android/IntegrationTests.XamarinForms.Android.csproj

@@ -50,7 +50,7 @@
     <Reference Include="System.Xml" />
   </ItemGroup>
   <ItemGroup>
-    <PackageReference Include="Acr.UserDialogs" Version="7.1.0.481" />
+    <PackageReference Include="Acr.UserDialogs" Version="7.1.0.483" />
     <PackageReference Include="ReactiveUI.AndroidSupport" Version="*" />
     <PackageReference Include="Xamarin.Android.Support.Design" Version="28.0.*" />
     <PackageReference Include="Xamarin.Android.Support.v7.AppCompat" Version="28.0.*" />

integrationtests/IntegrationTests.XamarinForms.UWP/IntegrationTests.XamarinForms.UWP.csproj

@@ -145,7 +145,7 @@
   </ItemGroup>
   <ItemGroup>
     <PackageReference Include="Acr.UserDialogs">
-      <Version>7.1.0.481</Version>
+      <Version>7.1.0.483</Version>
     </PackageReference>
     <PackageReference Include="Microsoft.NETCore.UniversalWindowsPlatform" Version="6.2.*" />
   </ItemGroup>

integrationtests/IntegrationTests.XamarinForms.iOS/IntegrationTests.XamarinForms.iOS.csproj

@@ -160,7 +160,7 @@
     <Reference Include="Xamarin.iOS" />
   </ItemGroup>
   <ItemGroup>
-    <PackageReference Include="Acr.UserDialogs" Version="7.1.0.481" />
+    <PackageReference Include="Acr.UserDialogs" Version="7.1.0.483" />
   </ItemGroup>
   <ItemGroup>
     <ProjectReference Include="..\IntegrationTests.XamarinForms\IntegrationTests.XamarinForms.csproj">

integrationtests/IntegrationTests.XamarinForms/IntegrationTests.XamarinForms.csproj

@@ -5,7 +5,7 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Acr.UserDialogs" Version="7.1.0.481" />
+    <PackageReference Include="Acr.UserDialogs" Version="7.1.0.483" />
     <PackageReference Include="ReactiveUI.XamForms" Version="*" />
     <PackageReference Include="Xamarin.Forms" Version="4.8.*" />
   </ItemGroup>

src/Directory.build.props

@@ -42,7 +42,7 @@
     <PackageReference Include="FluentAssertions" Version="5.10.3" />
     <PackageReference Include="Microsoft.Reactive.Testing" Version="5.0.0" />
     <PackageReference Include="PublicApiGenerator" Version="10.2.0" />
-    <PackageReference Include="DiffEngine" Version="6.5.7" />
+    <PackageReference Include="DiffEngine" Version="6.6.1" />
     <PackageReference Include="coverlet.msbuild" Version="3.0.3" PrivateAssets="All" />
   </ItemGroup>
 

src/ReactiveUI.AndroidX/ReactiveUI.AndroidX.csproj

@@ -12,7 +12,7 @@
   <ItemGroup>
     <PackageReference Include="System.Runtime.Serialization.Primitives" Version="4.3.0" />
     <PackageReference Include="Xamarin.AndroidX.AppCompat" Version="1.2.0.7" />
-    <PackageReference Include="Xamarin.AndroidX.Fragment" Version="1.3.0.1" />
+    <PackageReference Include="Xamarin.AndroidX.Fragment" Version="1.3.1" />
     <PackageReference Include="Xamarin.AndroidX.Preference" Version="1.1.1.8" />
     <PackageReference Include="Xamarin.AndroidX.RecyclerView" Version="1.1.0.8" />
     <Reference Include="System.Runtime.Serialization" />

src/ReactiveUI.Fody.Helpers/ReactiveUI.Fody.Helpers.csproj

@@ -17,8 +17,8 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Fody" Version="6.4.0" PrivateAssets="None" />
-    <PackageReference Include="FodyPackaging" Version="6.4.0" PrivateAssets="All" />
+    <PackageReference Include="Fody" Version="6.5.0" PrivateAssets="None" />
+    <PackageReference Include="FodyPackaging" Version="6.5.0" PrivateAssets="All" />
     <PackageReference Include="System.Reactive" Version="5.0.0" />
   </ItemGroup>
 

src/ReactiveUI.Fody/ReactiveUI.Fody.csproj

@@ -10,6 +10,6 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="FodyHelpers" Version="6.4.0" />
+    <PackageReference Include="FodyHelpers" Version="6.5.0" />
   </ItemGroup>
 </Project>

src/ReactiveUI/Bindings/Command/CommandBinderImplementation.cs

@@ -155,9 +155,13 @@ private static IDisposable BindCommandInternal<TView, TProp, TParam>(
                 (val, host) => new { val, host });
 
             var propSub = bindInfo
-                .Where(x => x.host is not null)
                 .Subscribe(x =>
                 {
+                    if (x.host is null)
+                    {
+                        return;
+                    }
+
                     disposable.Dispose();
                     if (x is null)
                     {

src/ReactiveUI/Bindings/Property/PropertyBinderImplementation.cs

@@ -82,7 +82,7 @@ bool VmToViewFunc(TVMProp vmValue, out TVProp vValue)
                 var result = vmToViewConverter.TryConvert(vmValue, typeof(TVProp), conversionHint, out object? tmp);
 
 #pragma warning disable CS8605 // Unboxing a possibly null value.
-                vValue = result ? (TVProp)tmp : default;
+                vValue = result && tmp != null ? (TVProp)tmp : default;
 #pragma warning restore CS8605 // Unboxing a possibly null value.
                 return result;
             }
@@ -92,7 +92,7 @@ bool ViewToVmFunc(TVProp vValue, out TVMProp vmValue)
                 var result = viewToVMConverter.TryConvert(vValue, typeof(TVMProp), conversionHint, out object? tmp);
 
 #pragma warning disable CS8605 // Unboxing a possibly null value.
-                vmValue = result ? (TVMProp)tmp : default;
+                vmValue = result && tmp != null ? (TVMProp)tmp : default;
 #pragma warning restore CS8605 // Unboxing a possibly null value.
                 return result;
             }