Add AOT reflection warnings for .NET 6+ methods (#4085)

<!-- Please be sure to read the
[Contribute](https://github.com/reactiveui/reactiveui#contribute)
section of the README -->

**What kind of change does this PR introduce?**
<!-- Bug fix, feature, docs update, ... -->

update

**What is the current behavior?**
<!-- You can also link to an open issue here. -->

Some AOT markup is applied to broadly

**What is the new behavior?**
<!-- If this is a feature change -->

Added [RequiresDynamicCode] and [RequiresUnreferencedCode] attributes to
methods and interfaces that use reflection and are not compatible with
AOT environments in .NET 6 or greater. This change improves
compatibility and provides clearer warnings for developers targeting AOT
scenarios.

**What might this PR break?**

AOT requirements updated

**Please check if the PR fulfills these requirements**
- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)

**Other information**:

Author: ChrisPulman

src/ReactiveUI.Tests/API/ApiApprovalTests.ReactiveUI.DotNet8_0.verified.txt

@@ -395,6 +395,10 @@ public static bool IsStatic(this PropertyInfo item) // TODO: Create Test
         return method.IsStatic;
     }
 
+#if NET6_0_OR_GREATER
+    [RequiresDynamicCode("The method uses reflection and will not work in AOT environments.")]
+    [RequiresUnreferencedCode("The method uses reflection and will not work in AOT environments.")]
+#endif
     internal static IObservable<object> ViewModelWhenAnyValue<TView, TViewModel>(TViewModel? viewModel, TView view, Expression? expression)
         where TView : class, IViewFor
         where TViewModel : class =>

src/ReactiveUI.Tests/API/ApiApprovalTests.ReactiveUI.DotNet9_0.verified.txt

@@ -37,5 +37,9 @@ public interface ISuspensionDriver
     /// Invalidates the application state (i.e. deletes it from disk).
     /// </summary>
     /// <returns>A completed observable.</returns>
+#if NET6_0_OR_GREATER
+    [RequiresDynamicCode("The method uses reflection and will not work in AOT environments.")]
+    [RequiresUnreferencedCode("The method uses reflection and will not work in AOT environments.")]
+#endif
     IObservable<Unit> InvalidateState();
 }

src/ReactiveUI/Expression/Reflection.cs

@@ -22,8 +22,8 @@ public static class AutoPersistHelper
 {
     private static readonly MemoizingMRUCache<Type, Dictionary<string, bool>> _persistablePropertiesCache = new(
      static (type, _) => type.GetTypeInfo().DeclaredProperties
-                      .Where(x => x.CustomAttributes.Any(y => typeof(DataMemberAttribute).GetTypeInfo().IsAssignableFrom(y.AttributeType.GetTypeInfo())))
-                      .ToDictionary(k => k.Name, _ => true),
+                               .Where(x => x.CustomAttributes.Any(y => typeof(DataMemberAttribute).GetTypeInfo().IsAssignableFrom(y.AttributeType.GetTypeInfo())))
+                               .ToDictionary(k => k.Name, _ => true),
      RxApp.SmallCacheLimit);
 
     private static readonly MemoizingMRUCache<Type, bool> _dataContractCheckCache = new(
@@ -49,6 +49,10 @@ public static class AutoPersistHelper
     /// it is possible that it will never be saved.
     /// </param>
     /// <returns>A Disposable to disable automatic persistence.</returns>
+#if NET6_0_OR_GREATER
+    [RequiresDynamicCode("The method uses reflection and will not work in AOT environments.")]
+    [RequiresUnreferencedCode("The method uses reflection and will not work in AOT environments.")]
+#endif
     public static IDisposable AutoPersist<T>(this T @this, Func<T, IObservable<Unit>> doPersist, TimeSpan? interval = null)
         where T : IReactiveObject =>
         @this.AutoPersist(doPersist, Observable<Unit>.Never, interval);
@@ -76,6 +80,10 @@ public static IDisposable AutoPersist<T>(this T @this, Func<T, IObservable<Unit>
     /// it is possible that it will never be saved.
     /// </param>
     /// <returns>A Disposable to disable automatic persistence.</returns>
+#if NET6_0_OR_GREATER
+    [RequiresDynamicCode("The method uses reflection and will not work in AOT environments.")]
+    [RequiresUnreferencedCode("The method uses reflection and will not work in AOT environments.")]
+#endif
     public static IDisposable AutoPersist<T, TDontCare>(this T @this, Func<T, IObservable<Unit>> doPersist, IObservable<TDontCare> manualSaveSignal, TimeSpan? interval = null)
         where T : IReactiveObject
     {
@@ -127,6 +135,10 @@ public static IDisposable AutoPersist<T, TDontCare>(this T @this, Func<T, IObser
     /// it is possible that it will never be saved.
     /// </param>
     /// <returns>A Disposable to disable automatic persistence.</returns>
+#if NET6_0_OR_GREATER
+    [RequiresDynamicCode("The method uses reflection and will not work in AOT environments.")]
+    [RequiresUnreferencedCode("The method uses reflection and will not work in AOT environments.")]
+#endif
     public static IDisposable AutoPersistCollection<TItem>(this ObservableCollection<TItem> @this, Func<TItem, IObservable<Unit>> doPersist, TimeSpan? interval = null) // TODO: Create Test
         where TItem : IReactiveObject =>
         AutoPersistCollection(@this, doPersist, Observable<Unit>.Never, interval);
@@ -151,6 +163,10 @@ public static IDisposable AutoPersistCollection<TItem>(this ObservableCollection
     /// it is possible that it will never be saved.
     /// </param>
     /// <returns>A Disposable to disable automatic persistence.</returns>
+#if NET6_0_OR_GREATER
+    [RequiresDynamicCode("The method uses reflection and will not work in AOT environments.")]
+    [RequiresUnreferencedCode("The method uses reflection and will not work in AOT environments.")]
+#endif
     public static IDisposable AutoPersistCollection<TItem, TDontCare>(this ObservableCollection<TItem> @this, Func<TItem, IObservable<Unit>> doPersist, IObservable<TDontCare> manualSaveSignal, TimeSpan? interval = null)
         where TItem : IReactiveObject =>
         AutoPersistCollection<TItem, ObservableCollection<TItem>, TDontCare>(@this, doPersist, manualSaveSignal, interval);
@@ -175,6 +191,10 @@ public static IDisposable AutoPersistCollection<TItem, TDontCare>(this Observabl
     /// it is possible that it will never be saved.
     /// </param>
     /// <returns>A Disposable to disable automatic persistence.</returns>
+#if NET6_0_OR_GREATER
+    [RequiresDynamicCode("The method uses reflection and will not work in AOT environments.")]
+    [RequiresUnreferencedCode("The method uses reflection and will not work in AOT environments.")]
+#endif
     public static IDisposable AutoPersistCollection<TItem, TDontCare>(this ReadOnlyObservableCollection<TItem> @this, Func<TItem, IObservable<Unit>> doPersist, IObservable<TDontCare> manualSaveSignal, TimeSpan? interval = null) // TODO: Create Test
         where TItem : IReactiveObject =>
         AutoPersistCollection<TItem, ReadOnlyObservableCollection<TItem>, TDontCare>(@this, doPersist, manualSaveSignal, interval);
@@ -200,6 +220,10 @@ public static IDisposable AutoPersistCollection<TItem, TDontCare>(this ReadOnlyO
     /// it is possible that it will never be saved.
     /// </param>
     /// <returns>A Disposable to disable automatic persistence.</returns>
+#if NET6_0_OR_GREATER
+    [RequiresDynamicCode("The method uses reflection and will not work in AOT environments.")]
+    [RequiresUnreferencedCode("The method uses reflection and will not work in AOT environments.")]
+#endif
     public static IDisposable AutoPersistCollection<TItem, TCollection, TDontCare>(this TCollection @this, Func<TItem, IObservable<Unit>> doPersist, IObservable<TDontCare> manualSaveSignal, TimeSpan? interval = null) // TODO: Create Test
         where TItem : IReactiveObject
         where TCollection : INotifyCollectionChanged, IEnumerable<TItem>

src/ReactiveUI/Interfaces/ISuspensionDriver.cs

@@ -11,10 +11,6 @@ namespace ReactiveUI;
 /// <summary>
 /// Loads and saves state to persistent storage.
 /// </summary>
-#if NET6_0_OR_GREATER
-[RequiresDynamicCode("The method uses reflection and will not work in AOT environments.")]
-[RequiresUnreferencedCode("The method uses reflection and will not work in AOT environments.")]
-#endif
 public class BundleSuspensionDriver : ISuspensionDriver
 {
     /// <inheritdoc/>
@@ -71,6 +67,10 @@ public IObservable<Unit> SaveState(object state) // TODO: Create Test
     }
 
     /// <inheritdoc/>
+#if NET6_0_OR_GREATER
+    [RequiresDynamicCode("The method uses reflection and will not work in AOT environments.")]
+    [RequiresUnreferencedCode("The method uses reflection and will not work in AOT environments.")]
+#endif
     public IObservable<Unit> InvalidateState() // TODO: Create Test
     {
         try

src/ReactiveUI/Mixins/AutoPersistHelper.cs

@@ -17,10 +17,6 @@ namespace ReactiveUI;
 /// Fragments via property names, similar to Butter Knife, as well as allows
 /// you to fetch controls manually.
 /// </summary>
-#if NET6_0_OR_GREATER
-[RequiresDynamicCode("The method uses reflection and will not work in AOT environments.")]
-[RequiresUnreferencedCode("The method uses reflection and will not work in AOT environments.")]
-#endif
 public static partial class ControlFetcherMixin
 {
     private static readonly ConcurrentDictionary<Assembly, Dictionary<string, int>> _controlIds = new();
@@ -47,6 +43,10 @@ public static partial class ControlFetcherMixin
     /// <param name="assembly">The assembly containing the user-defined view.</param>
     /// <param name="propertyName">The property.</param>
     /// <returns>The return view.</returns>
+#if NET6_0_OR_GREATER
+    [RequiresDynamicCode("The method uses reflection and will not work in AOT environments.")]
+    [RequiresUnreferencedCode("The method uses reflection and will not work in AOT environments.")]
+#endif
     public static View? GetControl(this View view, Assembly assembly, [CallerMemberName] string? propertyName = null) // TODO: Create Test
         => GetCachedControl(propertyName, view, () => view.FindViewById(GetControlIdByName(assembly, propertyName)));
 
@@ -55,6 +55,10 @@ public static partial class ControlFetcherMixin
     /// </summary>
     /// <param name="layoutHost">The layout view host.</param>
     /// <param name="resolveMembers">The resolve members.</param>
+#if NET6_0_OR_GREATER
+    [RequiresDynamicCode("The method uses reflection and will not work in AOT environments.")]
+    [RequiresUnreferencedCode("The method uses reflection and will not work in AOT environments.")]
+#endif
     public static void WireUpControls(this ILayoutViewHost layoutHost, ResolveStrategy resolveMembers = ResolveStrategy.Implicit) // TODO: Create Test
     {
         ArgumentNullException.ThrowIfNull(layoutHost);
@@ -80,6 +84,10 @@ public static void WireUpControls(this ILayoutViewHost layoutHost, ResolveStrate
     /// </summary>
     /// <param name="view">The view.</param>
     /// <param name="resolveMembers">The resolve members.</param>
+#if NET6_0_OR_GREATER
+    [RequiresDynamicCode("The method uses reflection and will not work in AOT environments.")]
+    [RequiresUnreferencedCode("The method uses reflection and will not work in AOT environments.")]
+#endif
     public static void WireUpControls(this View view, ResolveStrategy resolveMembers = ResolveStrategy.Implicit) // TODO: Create Test
     {
         ArgumentNullException.ThrowIfNull(view);
@@ -111,6 +119,10 @@ public static void WireUpControls(this View view, ResolveStrategy resolveMembers
     /// <param name="fragment">The fragment.</param>
     /// <param name="inflatedView">The inflated view.</param>
     /// <param name="resolveMembers">The resolve members.</param>
+#if NET6_0_OR_GREATER
+    [RequiresDynamicCode("The method uses reflection and will not work in AOT environments.")]
+    [RequiresUnreferencedCode("The method uses reflection and will not work in AOT environments.")]
+#endif
     public static void WireUpControls(this Fragment fragment, View inflatedView, ResolveStrategy resolveMembers = ResolveStrategy.Implicit) // TODO: Create Test
     {
         ArgumentNullException.ThrowIfNull(fragment);
@@ -140,6 +152,10 @@ public static void WireUpControls(this Fragment fragment, View inflatedView, Res
     /// </summary>
     /// <param name="activity">The Activity.</param>
     /// <param name="resolveMembers">The resolve members.</param>
+#if NET6_0_OR_GREATER
+    [RequiresDynamicCode("The method uses reflection and will not work in AOT environments.")]
+    [RequiresUnreferencedCode("The method uses reflection and will not work in AOT environments.")]
+#endif
     public static void WireUpControls(this Activity activity, ResolveStrategy resolveMembers = ResolveStrategy.Implicit) // TODO: Create Test
     {
         ArgumentNullException.ThrowIfNull(activity);

src/ReactiveUI/Platforms/android/BundleSuspensionDriver.cs

@@ -9,10 +9,6 @@ namespace ReactiveUI;
 /// Android platform registrations.
 /// </summary>
 /// <seealso cref="ReactiveUI.IWantsToRegisterStuff" />
-#if NET6_0_OR_GREATER
-[RequiresDynamicCode("The method uses reflection and will not work in AOT environments.")]
-[RequiresUnreferencedCode("The method uses reflection and will not work in AOT environments.")]
-#endif
 public class PlatformRegistrations : IWantsToRegisterStuff
 {
     /// <inheritdoc/>

src/ReactiveUI/Platforms/android/ControlFetcherMixin.cs

@@ -12,10 +12,6 @@ namespace ReactiveUI;
 /// <summary>
 /// Loads and saves state to persistent storage.
 /// </summary>
-#if NET6_0_OR_GREATER
-[RequiresDynamicCode("The method uses reflection and will not work in AOT environments.")]
-[RequiresUnreferencedCode("The method uses reflection and will not work in AOT environments.")]
-#endif
 public class AppSupportJsonSuspensionDriver : ISuspensionDriver
 {
     /// <inheritdoc/>
@@ -68,6 +64,10 @@ public IObservable<Unit> SaveState(object state)
     }
 
     /// <inheritdoc/>
+#if NET6_0_OR_GREATER
+    [RequiresDynamicCode("The method uses reflection and will not work in AOT environments.")]
+    [RequiresUnreferencedCode("The method uses reflection and will not work in AOT environments.")]
+#endif
     public IObservable<Unit> InvalidateState()
     {
         try

src/ReactiveUI/Platforms/android/PlatformRegistrations.cs

@@ -9,10 +9,6 @@ namespace ReactiveUI;
 /// Mac platform registrations.
 /// </summary>
 /// <seealso cref="ReactiveUI.IWantsToRegisterStuff" />
-#if NET6_0_OR_GREATER
-[RequiresDynamicCode("The method uses reflection and will not work in AOT environments.")]
-[RequiresUnreferencedCode("The method uses reflection and will not work in AOT environments.")]
-#endif
 public class PlatformRegistrations : IWantsToRegisterStuff
 {
     /// <inheritdoc/>