Skip to content

Commit ce83513

Browse files
authored
housekeeping: Remove cast (#2626)
* housekeeping: Remove cast * Fix approvals * Fix approval tests again * Fix
1 parent df857bc commit ce83513

File tree

4 files changed

+0
-16
lines changed

4 files changed

+0
-16
lines changed

src/ReactiveUI.Tests/API/ApiApprovalTests.ReactiveUI.net472.approved.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -439,7 +439,6 @@ namespace ReactiveUI
439439
}
440440
public static class ObservableMixins
441441
{
442-
public static System.IObservable<T> Cast<T>(this System.IObservable<object?> observable) { }
443442
public static System.IObservable<T> WhereNotNull<T>(this System.IObservable<T?> observable) { }
444443
}
445444
public class ObservedChange<TSender, TValue> : ReactiveUI.IObservedChange<TSender, TValue>

src/ReactiveUI.Tests/API/ApiApprovalTests.ReactiveUI.net5.0.approved.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -434,7 +434,6 @@ namespace ReactiveUI
434434
}
435435
public static class ObservableMixins
436436
{
437-
public static System.IObservable<T> Cast<T>(this System.IObservable<object?> observable) { }
438437
public static System.IObservable<T> WhereNotNull<T>(this System.IObservable<T?> observable) { }
439438
}
440439
public class ObservedChange<TSender, TValue> : ReactiveUI.IObservedChange<TSender, TValue>

src/ReactiveUI.Tests/API/ApiApprovalTests.ReactiveUI.netcoreapp3.1.approved.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -432,7 +432,6 @@ namespace ReactiveUI
432432
}
433433
public static class ObservableMixins
434434
{
435-
public static System.IObservable<T> Cast<T>(this System.IObservable<object?> observable) { }
436435
public static System.IObservable<T> WhereNotNull<T>(this System.IObservable<T?> observable) { }
437436
}
438437
public class ObservedChange<TSender, TValue> : ReactiveUI.IObservedChange<TSender, TValue>

src/ReactiveUI/Mixins/ObservableMixins.cs

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -13,19 +13,6 @@ namespace ReactiveUI
1313
/// </summary>
1414
public static class ObservableMixins
1515
{
16-
/// <summary>
17-
/// Casts an observable to the specified value.
18-
/// This version allows for nullability.
19-
/// </summary>
20-
/// <typeparam name="T">The type to convert to.</typeparam>
21-
/// <param name="observable">The observable which as nullability.</param>
22-
/// <returns>The new observable.</returns>
23-
#pragma warning disable CS8619 // Nullability of reference types in value doesn't match target type.
24-
#pragma warning disable CS8605 // Unboxing possible null value
25-
public static IObservable<T> Cast<T>(this IObservable<object?> observable) => observable.Select(x => (T)x);
26-
#pragma warning restore CS8605 // Unboxing possible null value
27-
#pragma warning restore CS8619 // Nullability of reference types in value doesn't match target type.
28-
2916
/// <summary>
3017
/// Returns only values that are not null.
3118
/// Converts the nullability.

0 commit comments

Comments
 (0)