Skip to content

Commit 06d8b07

Browse files
committed
Remove cacheDependencyKeys as it's unused.
1 parent 3ea6f8b commit 06d8b07

File tree

5 files changed

+6
-40
lines changed

5 files changed

+6
-40
lines changed

src/React.AspNet/MemoryFileCacheCore.cs

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -63,11 +63,7 @@ public MemoryFileCacheCore(IMemoryCache cache, IHostingEnvironment hostingEnv)
6363
/// Filenames this cached item is dependent on. If any of these files change, the cache
6464
/// will be cleared automatically
6565
/// </param>
66-
/// <param name="cacheDependencyKeys">
67-
/// Other cache keys this cached item is dependent on. If any of these keys change, the
68-
/// cache will be cleared automatically
69-
/// </param>
70-
public void Set<T>(string key, T data, TimeSpan slidingExpiration, IEnumerable<string> cacheDependencyFiles = null, IEnumerable<string> cacheDependencyKeys = null)
66+
public void Set<T>(string key, T data, TimeSpan slidingExpiration, IEnumerable<string> cacheDependencyFiles = null)
7167
{
7268
if (data == null)
7369
{
@@ -89,13 +85,6 @@ public void Set<T>(string key, T data, TimeSpan slidingExpiration, IEnumerable<s
8985
}
9086
}
9187

92-
if (cacheDependencyKeys != null && cacheDependencyKeys.Any())
93-
{
94-
// https://github.com/aspnet/Docs/issues/1938
95-
// https://github.com/aspnet/Caching/issues/236
96-
throw new NotImplementedException();
97-
}
98-
9988
_cache.Set(key, data, options);
10089
}
10190
}

src/React.Core/ICache.cs

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -41,16 +41,11 @@ public interface ICache
4141
/// Filenames this cached item is dependent on. If any of these files change, the cache
4242
/// will be cleared automatically
4343
/// </param>
44-
/// <param name="cacheDependencyKeys">
45-
/// Other cache keys this cached item is dependent on. If any of these keys change, the
46-
/// cache will be cleared automatically
47-
/// </param>
4844
void Set<T>(
4945
string key,
5046
T data,
5147
TimeSpan slidingExpiration,
52-
IEnumerable<string> cacheDependencyFiles = null,
53-
IEnumerable<string> cacheDependencyKeys = null
48+
IEnumerable<string> cacheDependencyFiles = null
5449
);
5550
}
5651
}

src/React.Core/MemoryFileCache.cs

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -57,11 +57,7 @@ public MemoryFileCache()
5757
/// Filenames this cached item is dependent on. If any of these files change, the cache
5858
/// will be cleared automatically
5959
/// </param>
60-
/// <param name="cacheDependencyKeys">
61-
/// Other cache keys this cached item is dependent on. If any of these keys change, the
62-
/// cache will be cleared automatically
63-
/// </param>
64-
public void Set<T>(string key, T data, TimeSpan slidingExpiration, IEnumerable<string> cacheDependencyFiles = null, IEnumerable<string> cacheDependencyKeys = null)
60+
public void Set<T>(string key, T data, TimeSpan slidingExpiration, IEnumerable<string> cacheDependencyFiles = null)
6561
{
6662
if (data == null)
6763
{
@@ -74,9 +70,6 @@ public void Set<T>(string key, T data, TimeSpan slidingExpiration, IEnumerable<s
7470
if (cacheDependencyFiles != null && cacheDependencyFiles.Any())
7571
policy.ChangeMonitors.Add(new HostFileChangeMonitor(cacheDependencyFiles.ToList()));
7672

77-
if (cacheDependencyKeys != null && cacheDependencyKeys.Any())
78-
policy.ChangeMonitors.Add(_cache.CreateCacheEntryChangeMonitor(cacheDependencyKeys));
79-
8073
_cache.Set(key, data, policy);
8174
}
8275
}

src/React.Core/NullCache.cs

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -44,12 +44,7 @@ public class NullCache : ICache
4444
/// Filenames this cached item is dependent on. If any of these files change, the cache
4545
/// will be cleared automatically
4646
/// </param>
47-
/// <param name="cacheDependencyKeys">
48-
/// Other cache keys this cached item is dependent on. If any of these keys change, the
49-
/// cache will be cleared automatically
50-
/// </param>
51-
public void Set<T>(string key, T data, TimeSpan slidingExpiration, IEnumerable<string> cacheDependencyFiles = null,
52-
IEnumerable<string> cacheDependencyKeys = null)
47+
public void Set<T>(string key, T data, TimeSpan slidingExpiration, IEnumerable<string> cacheDependencyFiles = null)
5348
{
5449
// no-op
5550
}

src/React.Web/AspNetCache.cs

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -61,20 +61,14 @@ public AspNetCache(HttpContextBase context)
6161
/// Filenames this cached item is dependent on. If any of these files change, the cache
6262
/// will be cleared automatically
6363
/// </param>
64-
/// <param name="cacheDependencyKeys">
65-
/// Other cache keys this cached item is dependent on. If any of these keys change, the
66-
/// cache will be cleared automatically
67-
/// </param>
6864
public void Set<T>(
6965
string key, T data,
7066
TimeSpan slidingExpiration,
71-
IEnumerable<string> cacheDependencyFiles = null,
72-
IEnumerable<string> cacheDependencyKeys = null
67+
IEnumerable<string> cacheDependencyFiles = null
7368
)
7469
{
7570
var cacheDependency = new CacheDependency(
76-
(cacheDependencyFiles ?? Enumerable.Empty<string>()).ToArray(),
77-
(cacheDependencyKeys ?? Enumerable.Empty<string>()).ToArray()
71+
(cacheDependencyFiles ?? Enumerable.Empty<string>()).ToArray()
7872
);
7973
_cache.Insert(key, data, cacheDependency, Cache.NoAbsoluteExpiration, slidingExpiration);
8074
}

0 commit comments

Comments
 (0)