Skip to content

Commit 5b5a512

Browse files
committed
Add JavaScriptEngineSwitcher references to avoid issues with older MSBuild
MSBuild 12.0 and below have started throwing errors like "The type 'JavaScriptEngineSwitcher.Core.IJsEngine' is defined in an assembly that is not referenced. You must add a reference to assembly 'JavaScriptEngineSwitcher.Core, Version=1.2.4.0, Culture=neutral, PublicKeyToken=c608b2a8cc9e4472'" with the build. Referencing JavaScriptEngineSwitcher in more assemblies was enough to make it happy. Strangely, MSBuild 14.0 was fine before this change.
1 parent 0552613 commit 5b5a512

File tree

7 files changed

+17
-2
lines changed

7 files changed

+17
-2
lines changed

src/React.AspNet/project.json

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
"compilationOptions": {
1111
"define": [ "RELEASE", "TRACE", "ASPNET5" ],
1212
"optimize": true,
13-
"warningsAsErrors": true,
13+
"warningsAsErrors": true
1414
}
1515
}
1616
},
@@ -19,7 +19,8 @@
1919
"Microsoft.AspNet.Hosting": "1.0.0.0-beta3",
2020
"Microsoft.AspNet.Mvc.Core": "6.0.0.0-beta3",
2121
"Microsoft.AspNet.StaticFiles": "1.0.0.0-beta3",
22-
"React.Core": ""
22+
"React.Core": "",
23+
"JavaScriptEngineSwitcher.Core": "1.2.4.0"
2324
},
2425
"frameworks": {
2526
"aspnet50": { }

src/React.Owin/React.Owin.csproj

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,10 @@
4444
<SignAssembly>true</SignAssembly>
4545
</PropertyGroup>
4646
<ItemGroup>
47+
<Reference Include="JavaScriptEngineSwitcher.Core, Version=1.2.4.0, Culture=neutral, PublicKeyToken=c608b2a8cc9e4472, processorArchitecture=MSIL">
48+
<SpecificVersion>False</SpecificVersion>
49+
<HintPath>..\packages\JavaScriptEngineSwitcher.Core.1.2.4\lib\net40\JavaScriptEngineSwitcher.Core.dll</HintPath>
50+
</Reference>
4751
<Reference Include="Microsoft.Owin, Version=3.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
4852
<SpecificVersion>False</SpecificVersion>
4953
<HintPath>..\packages\Microsoft.Owin.3.0.0\lib\net45\Microsoft.Owin.dll</HintPath>

src/React.Owin/packages.config

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
<?xml version="1.0" encoding="utf-8"?>
22
<packages>
3+
<package id="JavaScriptEngineSwitcher.Core" version="1.2.4" targetFramework="net45" />
34
<package id="Microsoft.Owin" version="3.0.0" targetFramework="net45" />
45
<package id="Microsoft.Owin.FileSystems" version="3.0.0" targetFramework="net45" />
56
<package id="Microsoft.Owin.StaticFiles" version="3.0.0" targetFramework="net45" />

src/React.Sample.Cassette/React.Sample.Cassette.csproj

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,9 @@
6666
<SpecificVersion>False</SpecificVersion>
6767
<HintPath>..\packages\Cassette.Views.2.4.1\lib\net40\Cassette.Views.dll</HintPath>
6868
</Reference>
69+
<Reference Include="JavaScriptEngineSwitcher.Core">
70+
<HintPath>..\packages\JavaScriptEngineSwitcher.Core.1.2.4\lib\net40\JavaScriptEngineSwitcher.Core.dll</HintPath>
71+
</Reference>
6972
<Reference Include="Microsoft.CSharp" />
7073
<Reference Include="System" />
7174
<Reference Include="System.Data" />

src/React.Sample.Cassette/packages.config

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
<package id="Cassette.Aspnet" version="2.4.1" targetFramework="net40" />
66
<package id="Cassette.MSBuild" version="2.4.1" targetFramework="net40" />
77
<package id="Cassette.Views" version="2.4.1" targetFramework="net40" />
8+
<package id="JavaScriptEngineSwitcher.Core" version="1.2.4" targetFramework="net40" />
89
<package id="Microsoft.AspNet.Mvc" version="4.0.30506.0" targetFramework="net40" />
910
<package id="Microsoft.AspNet.Mvc.FixedDisplayModes" version="1.0.0" targetFramework="net40" />
1011
<package id="Microsoft.AspNet.Razor" version="2.0.30506.0" targetFramework="net40" />

src/React.Web/React.Web.csproj

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,10 @@
4242
<AssemblyOriginatorKeyFile>..\Key.snk</AssemblyOriginatorKeyFile>
4343
</PropertyGroup>
4444
<ItemGroup>
45+
<Reference Include="JavaScriptEngineSwitcher.Core, Version=1.2.4.0, Culture=neutral, PublicKeyToken=c608b2a8cc9e4472, processorArchitecture=MSIL">
46+
<SpecificVersion>False</SpecificVersion>
47+
<HintPath>..\packages\JavaScriptEngineSwitcher.Core.1.2.4\lib\net40\JavaScriptEngineSwitcher.Core.dll</HintPath>
48+
</Reference>
4549
<Reference Include="Microsoft.Web.Infrastructure, Version=1.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
4650
<Private>True</Private>
4751
<HintPath>..\packages\Microsoft.Web.Infrastructure.1.0.0.0\lib\net40\Microsoft.Web.Infrastructure.dll</HintPath>

src/React.Web/packages.config

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
<?xml version="1.0" encoding="utf-8"?>
22
<packages>
3+
<package id="JavaScriptEngineSwitcher.Core" version="1.2.4" targetFramework="net40" />
34
<package id="Microsoft.Web.Infrastructure" version="1.0.0.0" targetFramework="net40" />
45
<package id="Newtonsoft.Json" version="6.0.8" targetFramework="net40" />
56
<package id="WebActivatorEx" version="2.0.5" targetFramework="net40" />

0 commit comments

Comments
 (0)