Skip to content

Commit 71d0cf4

Browse files
committed
Enable harmony (ES6) and JavaScript engine pooling by default
1 parent f65bfc4 commit 71d0cf4

File tree

3 files changed

+14
-6
lines changed

3 files changed

+14
-6
lines changed

src/React.Tests/Core/JsxTransformerTests.cs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ public void ShouldTransformJsx()
5353
_environment.Verify(x => x.ExecuteWithLargerStackIfRequired<string>(
5454
"ReactNET_transform",
5555
"<div>Hello World</div>",
56-
false
56+
It.IsAny<bool>()
5757
));
5858
}
5959

@@ -63,7 +63,7 @@ public void ShouldWrapExceptionsInJsxExeption()
6363
_environment.Setup(x => x.ExecuteWithLargerStackIfRequired<string>(
6464
"ReactNET_transform",
6565
"<div>Hello World</div>",
66-
false
66+
It.IsAny<bool>()
6767
)).Throws(new Exception("Something broke..."));
6868

6969
const string input = "<div>Hello World</div>";
@@ -116,7 +116,7 @@ public void ShouldTransformJsxIfFileCacheHashInvalid()
116116
_environment.Setup(x => x.ExecuteWithLargerStackIfRequired<JavaScriptWithSourceMap>(
117117
"ReactNET_transform_sourcemap",
118118
It.IsAny<string>(),
119-
false
119+
It.IsAny<bool>()
120120
)).Returns(new JavaScriptWithSourceMap { Code = "React.DOM.div('Hello World')" });
121121

122122
var result = _jsxTransformer.TransformJsxFile("foo.jsx");
@@ -132,7 +132,7 @@ public void ShouldTransformJsxIfNoCache()
132132
_environment.Setup(x => x.ExecuteWithLargerStackIfRequired<JavaScriptWithSourceMap>(
133133
"ReactNET_transform_sourcemap",
134134
It.IsAny<string>(),
135-
false
135+
It.IsAny<bool>()
136136
)).Returns(new JavaScriptWithSourceMap { Code = "React.DOM.div('Hello World')" });
137137

138138
var result = _jsxTransformer.TransformJsxFile("foo.jsx");
@@ -146,7 +146,7 @@ public void ShouldSaveTransformationResult()
146146
_environment.Setup(x => x.ExecuteWithLargerStackIfRequired<JavaScriptWithSourceMap>(
147147
"ReactNET_transform_sourcemap",
148148
It.IsAny<string>(),
149-
false
149+
It.IsAny<bool>()
150150
)).Returns(new JavaScriptWithSourceMap { Code = "React.DOM.div('Hello World')" });
151151

152152
string result = null;

src/React/JsxTransformer.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -219,7 +219,6 @@ protected virtual JavaScriptWithSourceMap TransformJsxWithHeader(string filename
219219
hash = _fileCacheHash.CalculateHash(contents);
220220
}
221221
var header = GetFileHeader(hash);
222-
//var result = TransformJsxWithSourceMap(header + contents, useHarmony);
223222
var result = TransformJsxWithSourceMap(header + contents, useHarmony);
224223
result.Hash = hash;
225224
if (result.SourceMap != null)

src/React/ReactSiteConfiguration.cs

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,15 @@ static ReactSiteConfiguration()
2828
Configuration = new ReactSiteConfiguration();
2929
}
3030

31+
/// <summary>
32+
/// Initializes a new instance of the <see cref="ReactSiteConfiguration"/> class.
33+
/// </summary>
34+
public ReactSiteConfiguration()
35+
{
36+
UseHarmony = true;
37+
ReuseJavaScriptEngines = true;
38+
}
39+
3140
/// <summary>
3241
/// All the scripts that have been added to this configuration
3342
/// </summary>

0 commit comments

Comments
 (0)