Skip to content

Commit ae9e07e

Browse files
committed
Switch unit tests to NUnit
1 parent 5a6434e commit ae9e07e

File tree

9 files changed

+56
-35
lines changed

9 files changed

+56
-35
lines changed

build.proj

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -29,10 +29,6 @@ of patent rights can be found in the PATENTS file in the same directory.
2929
</ItemGroup>
3030

3131
<Import Project="$(MSBuildProjectDirectory)\tools\MSBuildTasks\MSBuild.Community.Tasks.Targets" />
32-
<UsingTask
33-
AssemblyFile="src\packages\xunit.1.9.2\lib\net20\xunit.runner.msbuild.dll"
34-
TaskName="Xunit.Runner.MSBuild.xunit"
35-
/>
3632
<UsingTask
3733
AssemblyFile="$(MSBuildExtensionsPath)\Microsoft\VisualStudio\v12.0\Web\Microsoft.Web.Publishing.Tasks.dll"
3834
TaskName="TransformXml"
@@ -74,7 +70,10 @@ of patent rights can be found in the PATENTS file in the same directory.
7470
<ItemGroup>
7571
<TestAssemblies Include="bin/ReleaseTests/**/React.Tests*.dll" />
7672
</ItemGroup>
77-
<xunit Assemblies="@(TestAssemblies)" />
73+
<NUnit
74+
ToolPath="src\packages\NUnit.Runners.2.6.3\tools"
75+
Assemblies="@(TestAssemblies)"
76+
/>
7877
</Target>
7978

8079
<Target Name="GenerateNuSpecs">

src/.nuget/packages.config

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
<?xml version="1.0" encoding="utf-8"?>
2+
<packages>
3+
<package id="NUnit.Runners" version="2.6.3" />
4+
</packages>

src/React.Tests/Core/JavaScriptEngineFactoryTest.cs

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,14 @@
99

1010
using System.Threading;
1111
using JavaScriptEngineSwitcher.Core;
12-
using Xunit;
12+
using NUnit.Framework;
1313

1414
namespace React.Tests.Core
1515
{
16+
[TestFixture]
1617
public class JavaScriptEngineFactoryTest
1718
{
18-
[Fact]
19+
[Test]
1920
public void ShouldCallOnNewEngineWhenCreatingNew()
2021
{
2122
var factory = new JavaScriptEngineFactory();
@@ -30,7 +31,7 @@ public void ShouldCallOnNewEngineWhenCreatingNew()
3031
Assert.True(called);
3132
}
3233

33-
[Fact]
34+
[Test]
3435
public void ShouldNotCallOnNewEngineWhenUsingExisting()
3536
{
3637
var factory = new JavaScriptEngineFactory();
@@ -42,18 +43,18 @@ public void ShouldNotCallOnNewEngineWhenUsingExisting()
4243
Assert.False(called);
4344
}
4445

45-
[Fact]
46+
[Test]
4647
public void ShouldReturnSameEngine()
4748
{
4849
var factory = new JavaScriptEngineFactory();
4950
var engine1 = factory.GetEngineForCurrentThread();
5051
var engine2 = factory.GetEngineForCurrentThread();
5152

52-
Assert.Equal(engine1, engine2);
53+
Assert.AreEqual(engine1, engine2);
5354
factory.DisposeEngineForCurrentThread();
5455
}
5556

56-
[Fact]
57+
[Test]
5758
public void ShouldReturnNewEngineAfterDisposing()
5859
{
5960
var factory = new JavaScriptEngineFactory();
@@ -62,10 +63,10 @@ public void ShouldReturnNewEngineAfterDisposing()
6263
var engine2 = factory.GetEngineForCurrentThread();
6364
factory.DisposeEngineForCurrentThread();
6465

65-
Assert.NotEqual(engine1, engine2);
66+
Assert.AreNotEqual(engine1, engine2);
6667
}
6768

68-
[Fact]
69+
[Test]
6970
public void ShouldCreateNewEngineForNewThread()
7071
{
7172
var factory = new JavaScriptEngineFactory();
@@ -84,9 +85,9 @@ public void ShouldCreateNewEngineForNewThread()
8485
var engine3 = factory.GetEngineForCurrentThread();
8586

8687
// Different threads should have different engines
87-
Assert.NotEqual(engine1, engine2);
88+
Assert.AreNotEqual(engine1, engine2);
8889
// Same thread should share same engine
89-
Assert.Equal(engine1, engine3);
90+
Assert.AreEqual(engine1, engine3);
9091
factory.DisposeEngineForCurrentThread();
9192
}
9293
}

src/React.Tests/Core/JsxTransformerTests.cs

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,14 +8,15 @@
88
*/
99

1010
using Moq;
11+
using NUnit.Framework;
1112
using React.Exceptions;
12-
using Xunit;
1313

1414
namespace React.Tests.Core
1515
{
16+
[TestFixture]
1617
public class JsxTransformerTests
1718
{
18-
[Fact]
19+
[Test]
1920
public void ShouldNotTransformJsxIfNoAnnotationPresent()
2021
{
2122
var environment = new Mock<IReactEnvironment>();
@@ -29,10 +30,10 @@ public void ShouldNotTransformJsxIfNoAnnotationPresent()
2930
const string input = "<div>Hello World</div>";
3031

3132
var output = jsxTransformer.TransformJsx(input);
32-
Assert.Equal(input, output);
33+
Assert.AreEqual(input, output);
3334
}
3435

35-
[Fact]
36+
[Test]
3637
public void ShouldTransformJsxIfAnnotationPresent()
3738
{
3839
var environment = new Mock<IReactEnvironment>();

src/React.Tests/Core/ReactComponentTest.cs

Lines changed: 18 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,22 @@
1-
using Moq;
1+
/*
2+
* Copyright (c) 2014, Facebook, Inc.
3+
* All rights reserved.
4+
*
5+
* This source code is licensed under the BSD-style license found in the
6+
* LICENSE file in the root directory of this source tree. An additional grant
7+
* of patent rights can be found in the PATENTS file in the same directory.
8+
*/
9+
10+
using Moq;
11+
using NUnit.Framework;
212
using React.Exceptions;
3-
using Xunit;
413

514
namespace React.Tests.Core
615
{
16+
[TestFixture]
717
public class ReactComponentTest
818
{
9-
[Fact]
19+
[Test]
1020
public void RenderHtmlShouldThrowExceptionIfComponentDoesNotExist()
1121
{
1222
var environment = new Mock<IReactEnvironment>();
@@ -19,7 +29,7 @@ public void RenderHtmlShouldThrowExceptionIfComponentDoesNotExist()
1929
});
2030
}
2131

22-
[Fact]
32+
[Test]
2333
public void RenderHtmlShouldCallRenderComponent()
2434
{
2535
var environment = new Mock<IReactEnvironment>();
@@ -34,7 +44,7 @@ public void RenderHtmlShouldCallRenderComponent()
3444
environment.Verify(x => x.Execute<string>(@"React.renderComponentToString(Foo({""hello"":""World""}))"));
3545
}
3646

37-
[Fact]
47+
[Test]
3848
public void RenderHtmlShouldWrapComponentInDiv()
3949
{
4050
var environment = new Mock<IReactEnvironment>();
@@ -48,10 +58,10 @@ public void RenderHtmlShouldWrapComponentInDiv()
4858
};
4959
var result = component.RenderHtml();
5060

51-
Assert.Equal(@"<div id=""container"">[HTML]</div>", result);
61+
Assert.AreEqual(@"<div id=""container"">[HTML]</div>", result);
5262
}
5363

54-
[Fact]
64+
[Test]
5565
public void RenderJavaScriptShouldCallRenderComponent()
5666
{
5767
var environment = new Mock<IReactEnvironment>();
@@ -62,7 +72,7 @@ public void RenderJavaScriptShouldCallRenderComponent()
6272
};
6373
var result = component.RenderJavaScript();
6474

65-
Assert.Equal(
75+
Assert.AreEqual(
6676
@"React.renderComponent(Foo({""hello"":""World""}), document.getElementById(""container""))",
6777
result
6878
);

src/React.Tests/Core/ReactEnvironmentTest.cs

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,13 +10,14 @@
1010
using System;
1111
using JavaScriptEngineSwitcher.Core;
1212
using Moq;
13-
using Xunit;
13+
using NUnit.Framework;
1414

1515
namespace React.Tests.Core
1616
{
17+
[TestFixture]
1718
public class ReactEnvironmentTest
1819
{
19-
[Fact]
20+
[Test]
2021
public void ExecuteWithLargerStackIfRequiredWithNoNewThread()
2122
{
2223
var mocks = new Mocks();
@@ -26,7 +27,7 @@ public void ExecuteWithLargerStackIfRequiredWithNoNewThread()
2627
mocks.Engine.Verify(x => x.Evaluate<int>("1+1"));
2728
}
2829

29-
[Fact]
30+
[Test]
3031
public void ExecuteWithLargerStackIfRequiredWithNewThread()
3132
{
3233
var mocks = new Mocks();
@@ -50,7 +51,7 @@ public void ExecuteWithLargerStackIfRequiredWithNewThread()
5051
);
5152
}
5253

53-
[Fact]
54+
[Test]
5455
public void ExecuteWithLargerStackIfRequiredShouldBubbleExceptions()
5556
{
5657
var mocks = new Mocks();

src/React.Tests/React.Tests.csproj

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,9 @@
4747
<Reference Include="Moq">
4848
<HintPath>..\packages\Moq.4.2.1402.2112\lib\net40\Moq.dll</HintPath>
4949
</Reference>
50+
<Reference Include="nunit.framework">
51+
<HintPath>..\packages\NUnit.2.6.3\lib\nunit.framework.dll</HintPath>
52+
</Reference>
5053
<Reference Include="System" />
5154
<Reference Include="System.Core" />
5255
<Reference Include="System.Web" />
@@ -55,9 +58,6 @@
5558
<Reference Include="Microsoft.CSharp" />
5659
<Reference Include="System.Data" />
5760
<Reference Include="System.Xml" />
58-
<Reference Include="xunit">
59-
<HintPath>..\packages\xunit.1.9.2\lib\net20\xunit.dll</HintPath>
60-
</Reference>
6161
</ItemGroup>
6262
<ItemGroup>
6363
<Compile Include="..\SharedAssemblyInfo.cs">

src/React.Tests/packages.config

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,5 @@
22
<packages>
33
<package id="JavaScriptEngineSwitcher.Core" version="1.1.3" targetFramework="net40" />
44
<package id="Moq" version="4.2.1402.2112" targetFramework="net40" />
5-
<package id="xunit" version="1.9.2" targetFramework="net40" />
5+
<package id="NUnit" version="2.6.3" targetFramework="net40" />
66
</packages>

src/React.sln

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,11 @@ Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "React.Web.Mvc3", "React.Web
4444
EndProject
4545
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "React.MSBuild", "React.MSBuild\React.MSBuild.csproj", "{AF531A37-B93F-4113-9C2C-4DB28064B926}"
4646
EndProject
47+
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = ".nuget", ".nuget", "{F2875D3A-0C8A-439B-B734-ECABA00AC629}"
48+
ProjectSection(SolutionItems) = preProject
49+
.nuget\packages.config = .nuget\packages.config
50+
EndProjectSection
51+
EndProject
4752
Global
4853
GlobalSection(SolutionConfigurationPlatforms) = preSolution
4954
Debug|Any CPU = Debug|Any CPU

0 commit comments

Comments
 (0)