Skip to content

Commit 036b16c

Browse files
simisonSunil Pai
authored andcommitted
React-PropTypes-to-prop-types: ignore migrated named import (#188)
1 parent dda87a5 commit 036b16c

File tree

6 files changed

+24
-1
lines changed

6 files changed

+24
-1
lines changed

transforms/React-PropTypes-to-prop-types.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -220,7 +220,8 @@ module.exports = function(file, api, options) {
220220
.find(j.Identifier)
221221
.filter(path => (
222222
path.node.name === 'PropTypes' &&
223-
path.parent.node.type === 'ImportSpecifier'
223+
path.parent.node.type === 'ImportSpecifier' &&
224+
path.parent.parent.node.source.value === 'react'
224225
))
225226
.forEach(path => {
226227
hasModifications = true;
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
import { PropTypes as PT } from 'prop-types';
2+
import React from 'react';
3+
4+
const object = PropTypes.object;
5+
const string = React.PropTypes.string;
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
import { PropTypes as PT } from 'prop-types';
2+
import React from 'react';
3+
4+
const object = PropTypes.object;
5+
const string = PropTypes.string;
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
import { PropTypes } from 'prop-types';
2+
import React from 'react';
3+
4+
const object = PropTypes.object;
5+
const string = React.PropTypes.string;
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
import { PropTypes } from 'prop-types';
2+
import React from 'react';
3+
4+
const object = PropTypes.object;
5+
const string = PropTypes.string;

transforms/__tests__/React-PropTypes-to-prop-types-test.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,8 @@ jest.mock('../React-PropTypes-to-prop-types', () => {
1717
});
1818

1919
const tests = [
20+
'already-migrated-named-as-import',
21+
'already-migrated-named-import',
2022
'already-migrated-import',
2123
'already-migrated-require',
2224
'assigned-from-react-var',

0 commit comments

Comments
 (0)