Issues/181 : manual-bind-to-arrow does not clean up constructor binds when the same bind occurs multiple times (#247)

* Add a failing test

* Fails only when method name is same in multiple components

* Scope the method removal to the corresponding component declaration

Author: Pavithra Kodmad

transforms/__testfixtures__/manual-bind-to-arrow/manual-bind-to-arrow10.input.js

@@ -0,0 +1,15 @@
+class Component extends React.Component {
+    constructor() {
+        super();
+        this.onClick = this.onClick.bind(this);
+    }
+    onClick() { }
+}
+
+class Component2 extends React.Component {
+    constructor() {
+        super();
+        this.onClick = this.onClick.bind(this);
+    }
+    onClick() { }
+}

transforms/__testfixtures__/manual-bind-to-arrow/manual-bind-to-arrow10.output.js

@@ -0,0 +1,7 @@
+class Component extends React.Component {
+    onClick = () => { };
+}
+
+class Component2 extends React.Component {
+    onClick = () => { };
+}

transforms/__testfixtures__/manual-bind-to-arrow/manual-bind-to-arrow9.input.js

@@ -0,0 +1,15 @@
+class Component extends React.Component {
+    constructor() {
+        super();
+        this.onClick = this.onClick.bind(this);
+    }
+    onClick() { }
+}
+
+class Component2 extends React.Component {
+    constructor() {
+        super();
+        this.didClick = this.didClick.bind(this);
+    }
+    didClick() { }
+}

transforms/__testfixtures__/manual-bind-to-arrow/manual-bind-to-arrow9.output.js

@@ -0,0 +1,7 @@
+class Component extends React.Component {
+    onClick = () => { };
+}
+
+class Component2 extends React.Component {
+    didClick = () => { };
+}

transforms/__tests__/manual-bind-to-arrow-test.js

@@ -25,6 +25,8 @@ var TESTS = [
   6,
   7,
   8,
+  9,
+  10
 ];
 
 TESTS.forEach(test => {

transforms/manual-bind-to-arrow.js

@@ -107,7 +107,9 @@ export default function transformer(file, api, options) {
 
     // Find the method() declaration and replace it with an arrow function
     var methodName = path.node.left.property.name;
-    var methods = root
+
+    const componentDecl = methodPath.parentPath;
+    var methods = j(componentDecl)
       .find(j.MethodDefinition)
       .filter(
         path =>
@@ -121,7 +123,7 @@ export default function transformer(file, api, options) {
       return;
     }
     methods.replaceWith(path => createArrowProperty(path.node));
-
+    
     // Remove the line
     // this.method = this.method.bind(this);
     j(path.parentPath).remove();