Skip to content

Commit e49a761

Browse files
author
Sunil Pai
authored
adds --extensions=jsx,js by default (#239)
It seems common enough that we should allow it. Also folks use .js with typescript sometimes.
1 parent 28b3da0 commit e49a761

File tree

2 files changed

+9
-5
lines changed

2 files changed

+9
-5
lines changed

bin/__tests__/react-codemod-test.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ describe('runTransform', () => {
9999
});
100100
expect(console.log).toBeCalledWith(
101101
// eslint-disable-next-line max-len
102-
`Executing command: jscodeshift --verbose=2 --ignore-pattern=**/node_modules/** --parser flow --transform ${path.join(
102+
`Executing command: jscodeshift --verbose=2 --ignore-pattern=**/node_modules/** --parser flow --extensions=jsx,js --transform ${path.join(
103103
transformerDirectory,
104104
'rename-unsafe-xyz.js'
105105
)} src`
@@ -117,7 +117,7 @@ describe('runTransform', () => {
117117
});
118118
expect(console.log).toBeCalledWith(
119119
// eslint-disable-next-line max-len
120-
`Executing command: jscodeshift --dry --verbose=2 --ignore-pattern=**/node_modules/** --parser flow --transform ${path.join(
120+
`Executing command: jscodeshift --dry --verbose=2 --ignore-pattern=**/node_modules/** --parser flow --extensions=jsx,js --transform ${path.join(
121121
transformerDirectory,
122122
'rename-unsafe-lifecycles.js'
123123
)} folder`
@@ -135,7 +135,7 @@ describe('runTransform', () => {
135135
});
136136
expect(console.log).toBeCalledWith(
137137
// eslint-disable-next-line max-len
138-
`Executing command: jscodeshift --dry --verbose=2 --ignore-pattern=**/node_modules/** --parser tsx --extensions=tsx,ts --transform ${path.join(
138+
`Executing command: jscodeshift --dry --verbose=2 --ignore-pattern=**/node_modules/** --parser tsx --extensions=tsx,ts,jsx,js --transform ${path.join(
139139
transformerDirectory,
140140
'rename-unsafe-lifecycles.js'
141141
)} folder`
@@ -156,7 +156,7 @@ describe('runTransform', () => {
156156
});
157157
expect(console.log).toBeCalledWith(
158158
// eslint-disable-next-line max-len
159-
`Executing command: jscodeshift --dry --verbose=2 --ignore-pattern=**/node_modules/** --parser babel --transform ${path.join(
159+
`Executing command: jscodeshift --dry --verbose=2 --ignore-pattern=**/node_modules/** --parser babel --extensions=jsx,js --transform ${path.join(
160160
transformerDirectory,
161161
'rename-unsafe-lifecycles.js'
162162
)} verbose=2 --printOptions='{"quote":"double"}' folder`

bin/cli.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,8 +64,12 @@ function runTransform({ files, flags, parser, transformer, answers }) {
6464
args.push('--ignore-pattern=**/node_modules/**');
6565

6666
args.push('--parser', parser);
67+
6768
if (parser === 'tsx') {
68-
args.push('--extensions=tsx,ts');
69+
args.push('--extensions=tsx,ts,jsx,js');
70+
}
71+
else {
72+
args.push('--extensions=jsx,js');
6973
}
7074

7175
args = args.concat(['--transform', transformerPath]);

0 commit comments

Comments
 (0)