Add importer tests for resolveObjectKeysToArray

Author: phated

src/utils/__tests__/resolveObjectKeysToArray-test.js

@@ -7,21 +7,45 @@
  */
 
 import { builders } from 'ast-types';
-import * as utils from '../../../tests/utils';
+import {
+  parse as parseSource,
+  statement,
+  noopImporter,
+  makeMockImporter,
+} from '../../../tests/utils';
 import resolveObjectKeysToArray from '../resolveObjectKeysToArray';
 
 describe('resolveObjectKeysToArray', () => {
   function parse(src) {
-    const root = utils.parse(src);
+    const root = parseSource(src);
     return root.get('body', root.node.body.length - 1, 'expression');
   }
 
+  const mockImporter = makeMockImporter({
+    foo: statement(`
+      export default {
+        bar: "bar",
+        "foo": "foo",
+        1: 0,
+        2: 5,
+        [3]: 3,
+        ['baz']: "baz",
+      };
+    `).get('declaration'),
+
+    bar: statement(`
+      export default {
+        bar: 'bar',
+      };
+    `).get('declaration'),
+  });
+
   it('resolves Object.keys with identifiers', () => {
     const path = parse(
       ['var foo = { bar: 1, foo: 2 };', 'Object.keys(foo);'].join('\n'),
     );
 
-    expect(resolveObjectKeysToArray(path)).toEqualASTNode(
+    expect(resolveObjectKeysToArray(path, noopImporter)).toEqualASTNode(
       builders.arrayExpression([
         builders.literal('bar'),
         builders.literal('foo'),
@@ -34,7 +58,7 @@ describe('resolveObjectKeysToArray', () => {
       ['var foo = { "bar": 1, 5: 2 };', 'Object.keys(foo);'].join('\n'),
     );
 
-    expect(resolveObjectKeysToArray(path)).toEqualASTNode(
+    expect(resolveObjectKeysToArray(path, noopImporter)).toEqualASTNode(
       builders.arrayExpression([
         builders.literal('bar'),
         builders.literal('5'),
@@ -47,7 +71,7 @@ describe('resolveObjectKeysToArray', () => {
       ['var foo = { ["bar"]: 1, [5]: 2};', 'Object.keys(foo);'].join('\n'),
     );
 
-    expect(resolveObjectKeysToArray(path)).toEqualASTNode(
+    expect(resolveObjectKeysToArray(path, noopImporter)).toEqualASTNode(
       builders.arrayExpression([
         builders.literal('bar'),
         builders.literal('5'),
@@ -64,7 +88,7 @@ describe('resolveObjectKeysToArray', () => {
       ].join('\n'),
     );
 
-    expect(resolveObjectKeysToArray(path)).toEqualASTNode(
+    expect(resolveObjectKeysToArray(path, noopImporter)).toEqualASTNode(
       builders.arrayExpression([
         builders.literal('boo'),
         builders.literal('foo'),
@@ -80,7 +104,7 @@ describe('resolveObjectKeysToArray', () => {
       ),
     );
 
-    expect(resolveObjectKeysToArray(path)).toEqualASTNode(
+    expect(resolveObjectKeysToArray(path, noopImporter)).toEqualASTNode(
       builders.arrayExpression([
         builders.literal('boo'),
         builders.literal('foo'),
@@ -97,7 +121,7 @@ describe('resolveObjectKeysToArray', () => {
       ].join('\n'),
     );
 
-    expect(resolveObjectKeysToArray(path)).toEqualASTNode(
+    expect(resolveObjectKeysToArray(path, noopImporter)).toEqualASTNode(
       builders.arrayExpression([
         builders.literal('boo'),
         builders.literal('foo'),
@@ -115,7 +139,7 @@ describe('resolveObjectKeysToArray', () => {
       ].join('\n'),
     );
 
-    expect(resolveObjectKeysToArray(path)).toEqualASTNode(
+    expect(resolveObjectKeysToArray(path, noopImporter)).toEqualASTNode(
       builders.arrayExpression([
         builders.literal('boo'),
         builders.literal('foo'),
@@ -131,7 +155,7 @@ describe('resolveObjectKeysToArray', () => {
       ),
     );
 
-    expect(resolveObjectKeysToArray(path)).toEqualASTNode(
+    expect(resolveObjectKeysToArray(path, noopImporter)).toEqualASTNode(
       builders.arrayExpression([builders.literal('x')]),
     );
   });
@@ -141,14 +165,48 @@ describe('resolveObjectKeysToArray', () => {
       ['var foo = { bar: 1, foo: 2, ...bar };', 'Object.keys(foo);'].join('\n'),
     );
 
-    expect(resolveObjectKeysToArray(path)).toBeNull();
+    expect(resolveObjectKeysToArray(path, noopImporter)).toBeNull();
   });
 
   it('does not resolve Object.keys when using computed keys', () => {
     const path = parse(
       ['var foo = { [bar]: 1, foo: 2 };', 'Object.keys(foo);'].join('\n'),
     );
 
-    expect(resolveObjectKeysToArray(path)).toBeNull();
+    expect(resolveObjectKeysToArray(path, noopImporter)).toBeNull();
+  });
+
+  it('can resolve imported objects passed to Object.keys', () => {
+    const path = parse(`
+      import foo from 'foo';
+      Object.keys(foo);
+    `);
+
+    expect(resolveObjectKeysToArray(path, mockImporter)).toEqualASTNode(
+      builders.arrayExpression([
+        builders.literal('bar'),
+        builders.literal('foo'),
+        builders.literal(1),
+        builders.literal(2),
+        builders.literal(3),
+        builders.literal('baz'),
+      ]),
+    );
+  });
+
+  it('can resolve spreads from imported objects', () => {
+    const path = parse(`
+      import bar from 'bar';
+      var abc = { foo: 'foo', baz: 'baz', ...bar };
+      Object.keys(abc);
+    `);
+
+    expect(resolveObjectKeysToArray(path, mockImporter)).toEqualASTNode(
+      builders.arrayExpression([
+        builders.literal('foo'),
+        builders.literal('baz'),
+        builders.literal('bar'),
+      ]),
+    );
   });
 });