Add importer tests for propDocblockHandler

Author: phated

src/handlers/__tests__/propDocblockHandler-test.js

@@ -8,7 +8,7 @@
 
 jest.mock('../../Documentation');
 
-import { expression, statement } from '../../../tests/utils';
+import { expression, statement, noopImporter, makeMockImporter } from '../../../tests/utils';
 
 describe('propDocBlockHandler', () => {
   let documentation;
@@ -19,6 +19,17 @@ describe('propDocBlockHandler', () => {
     propDocBlockHandler = require('../propDocBlockHandler').default;
   });
 
+  const mockImporter = makeMockImporter({
+    props: statement(`
+      export default {
+        /**
+          * A comment on imported props
+          */
+        foo: Prop.bool,
+      };
+    `).get('declaration'),
+  });
+
   function test(getSrc, parse) {
     it('finds docblocks for prop types', () => {
       const definition = parse(
@@ -36,7 +47,7 @@ describe('propDocBlockHandler', () => {
         ),
       );
 
-      propDocBlockHandler(documentation, definition);
+      propDocBlockHandler(documentation, definition, noopImporter);
       expect(documentation.descriptors).toEqual({
         foo: {
           description: 'Foo comment',
@@ -62,7 +73,7 @@ describe('propDocBlockHandler', () => {
         ),
       );
 
-      propDocBlockHandler(documentation, definition);
+      propDocBlockHandler(documentation, definition, noopImporter);
       expect(documentation.descriptors).toEqual({
         foo: {
           description:
@@ -89,7 +100,7 @@ describe('propDocBlockHandler', () => {
         ),
       );
 
-      propDocBlockHandler(documentation, definition);
+      propDocBlockHandler(documentation, definition, noopImporter);
       expect(documentation.descriptors).toEqual({
         foo: {
           description: 'Foo comment',
@@ -113,7 +124,7 @@ describe('propDocBlockHandler', () => {
         ),
       );
 
-      propDocBlockHandler(documentation, definition);
+      propDocBlockHandler(documentation, definition, noopImporter);
       expect(documentation.descriptors).toEqual({
         foo: {
           description: 'Foo comment',
@@ -137,7 +148,7 @@ describe('propDocBlockHandler', () => {
         ),
       );
 
-      propDocBlockHandler(documentation, definition);
+      propDocBlockHandler(documentation, definition, noopImporter);
       expect(documentation.descriptors).toEqual({
         foo: {
           description: 'Foo comment',
@@ -156,13 +167,51 @@ describe('propDocBlockHandler', () => {
         };
       `);
 
-      propDocBlockHandler(documentation, definition);
+      propDocBlockHandler(documentation, definition, noopImporter);
       expect(documentation.descriptors).toEqual({
         foo: {
           description: 'Foo comment',
         },
       });
     });
+
+    it('resolves imported variables', () => {
+      const definition = parse(`
+        ${getSrc('Props')}
+        import Props from 'props';
+      `);
+
+      propDocBlockHandler(documentation, definition, mockImporter);
+      expect(documentation.descriptors).toEqual({
+        foo: {
+          description: 'A comment on imported props',
+        },
+      });
+    });
+
+    it('resolves imported variables that are spread', () => {
+      const definition = parse(`
+        ${getSrc('Props')}
+        import ExtraProps from 'props';
+        var Props = {
+          ...ExtraProps,
+          /**
+           * Bar comment
+           */
+          bar: Prop.bool,
+        }
+      `);
+
+      propDocBlockHandler(documentation, definition, mockImporter);
+      expect(documentation.descriptors).toEqual({
+        foo: {
+          description: 'A comment on imported props',
+        },
+        bar: {
+          description: 'Bar comment',
+        },
+      });
+    });
   }
 
   describe('React.createClass', () => {
@@ -200,9 +249,9 @@ describe('propDocBlockHandler', () => {
 
   it('does not error if propTypes cannot be found', () => {
     let definition = expression('{fooBar: 42}');
-    expect(() => propDocBlockHandler(documentation, definition)).not.toThrow();
+    expect(() => propDocBlockHandler(documentation, definition, noopImporter)).not.toThrow();
 
     definition = statement('class Foo {}');
-    expect(() => propDocBlockHandler(documentation, definition)).not.toThrow();
+    expect(() => propDocBlockHandler(documentation, definition, noopImporter)).not.toThrow();
   });
 });