Skip to content

Commit e125c65

Browse files
committed
Fix lint errors
1 parent 6c6ea4d commit e125c65

22 files changed

+124
-131
lines changed

.eslintrc

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,20 @@
11
{
22
"parser": "babel-eslint",
33
"rules": {
4-
"strict": 0,
54
"comma-dangle": [1, "always-multiline"],
6-
"quotes": [2, "single", "avoid-escape"]
5+
"no-underscore-dangle": 0,
6+
"quotes": [2, "single", "avoid-escape"],
7+
"strict": 0
78
},
89
"env": {
910
"node": true
11+
},
12+
"globals": {
13+
"ASTNode": true,
14+
"Handler": true,
15+
"NodePath": true,
16+
"PropTypeDescriptor": true,
17+
"PropDescriptor": true,
18+
"Resolver": true
1019
}
1120
}

src/Documentation.js

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,10 @@
66
* LICENSE file in the root directory of this source tree. An additional grant
77
* of patent rights can be found in the PATENTS file in the same directory.
88
*
9+
* @flow
10+
*
911
*/
1012

11-
/**
12-
* @flow
13-
*/
14-
"use strict";
15-
1613
class Documentation {
1714
_props: Object;
1815
_description: string;
@@ -49,7 +46,7 @@ class Documentation {
4946
toObject(): Object {
5047
var obj = {
5148
description: this._description,
52-
props: this._props
49+
props: this._props,
5350
};
5451

5552
if (this._composes.length) {

src/__mocks__/Documentation.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ function Documentation() {
2121
},
2222
setDescription(descr) {
2323
this.description = descr;
24-
}
24+
},
2525
};
2626
}
2727

src/handlers/__tests__/propTypeCompositionHandler-test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
*
99
*/
1010

11-
/*global jest, describe, it, expect, beforeEach, afterEach*/
11+
/*global jest, describe, it, expect, beforeEach*/
1212

1313
jest.autoMockOff();
1414
jest.mock('../../Documentation');

src/handlers/propTypeHandler.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
import type Documentation from '../Documentation';
1414

1515
import getMembers from '../utils/getMembers';
16-
import getNameOrValue from '../utils/getNameOrValue';
1716
import getPropType from '../utils/getPropType';
1817
import getPropertyName from '../utils/getPropertyName';
1918
import getMemberValuePath from '../utils/getMemberValuePath';
@@ -44,7 +43,7 @@ function isRequired(path) {
4443
);
4544
}
4645

47-
function amendPropTypes(documentation, path, componentPath) {
46+
function amendPropTypes(documentation, path) {
4847
path.get('properties').each(function(propertyPath) {
4948
switch (propertyPath.node.type) {
5049
case types.Property.name:
@@ -86,5 +85,5 @@ export default function propTypeHandler(
8685
if (!propTypesPath) {
8786
return;
8887
}
89-
amendPropTypes(documentation, propTypesPath, path);
88+
amendPropTypes(documentation, propTypesPath);
9089
}

src/main.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,8 @@ var defaultHandlers = [
3737
*/
3838
function defaultParse( // eslint-disable-line no-unused-vars
3939
src: string,
40-
resolver?: ?Resolver,
41-
handlers?: ?Array<Handler>
40+
resolver?: ?Resolver, // eslint-disable-line no-shadow
41+
handlers?: ?Array<Handler> // eslint-disable-line no-shadow
4242
): Array<Object>|Object {
4343
if (!resolver) {
4444
resolver = defaultResolver;

src/resolver/__tests__/findExportedComponentDefinition-test.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -291,7 +291,7 @@ describe('findExportedComponentDefinition', () => {
291291
`;
292292
expect(() => parse(source)).toThrow();
293293

294-
var source = `
294+
source = `
295295
import React from 'React';
296296
var Component = class extends React.Component {};
297297
export {Component};
@@ -428,7 +428,7 @@ describe('findExportedComponentDefinition', () => {
428428
`;
429429
expect(() => parse(source)).toThrow();
430430

431-
var source = `
431+
source = `
432432
import React from 'React';
433433
export var ComponentA = class extends React.Component {};
434434
var ComponentB = class extends React.Component {};

src/utils/__tests__/docblock-test.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,10 @@
88
*
99
*/
1010

11-
"use strict";
11+
/*global jest, describe, beforeEach, it, expect*/
1212

13-
jest.autoMockOff();
13+
jest
14+
.dontMock('../docblock');
1415

1516
describe('docblock', () => {
1617

src/utils/__tests__/getMemberValuePath-test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
*
99
*/
1010

11-
/*global jest, describe, xdescribe, beforeEach, it, expect*/
11+
/*global jest, describe, beforeEach, it, expect*/
1212

1313
jest
1414
.dontMock('../getMemberValuePath.js');

src/utils/__tests__/getMembers-test.js

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -8,30 +8,23 @@
88
*
99
*/
1010

11-
"use strict";
11+
/*global jest, describe, beforeEach, it, expect*/
1212

1313
jest.autoMockOff();
1414

1515
describe('getMembers', () => {
16-
var recast;
16+
var expression;
1717
var getMembers;
1818
var memberExpressionPath;
1919

20-
function parse(src) {
21-
return new recast.types.NodePath(
22-
recast.parse(src).program.body[0].expression
23-
);
24-
}
25-
2620
beforeEach(() => {
2721
getMembers = require('../getMembers');
28-
recast = require('recast');
29-
memberExpressionPath = parse('foo.bar(123)(456)[baz][42]');
22+
({expression} = require('../../../tests/utils'));
23+
memberExpressionPath = expression('foo.bar(123)(456)[baz][42]');
3024
});
3125

3226

3327
it('finds all "members" "inside" a MemberExpression', () => {
34-
var b = recast.types.builders;
3528
var members = getMembers(memberExpressionPath);
3629

3730
//bar(123)

0 commit comments

Comments
 (0)