Update linting

Author: danez

.eslintrc

@@ -6,13 +6,12 @@
     "node": true
   },
   "rules": {
-    "react/prefer-es6-class": 0,
-    "react/prefer-stateless-function": 0,
-    "no-plusplus": 0,
+    "no-plusplus": "off",
+    "react/require-default-props": "off",
     "react/jsx-filename-extension": ["error", { "extensions": [".js"] }],
-    "react/forbid-prop-types": 0,
-    "react/sort-comp": 0,
-    "jsx-a11y/no-static-element-interactions": 0,
+    "react/forbid-prop-types": "off",
+    "react/sort-comp": "off",
+    "jsx-a11y/no-static-element-interactions": "off",
     "import/no-extraneous-dependencies": ["error", {
       "devDependencies": ["**/__tests__/*-test.js"],
       "optionalDependencies": false

package.json

@@ -52,9 +52,9 @@
     "cross-env": "^4.0.0",
     "enzyme": "^2.3.0",
     "eslint": "^3.5.0",
-    "eslint-config-airbnb": "^12.0.0",
-    "eslint-plugin-import": "^1.8.0",
-    "eslint-plugin-jsx-a11y": "^2.2.2",
+    "eslint-config-airbnb": "^14.1.0",
+    "eslint-plugin-import": "^2.2.0",
+    "eslint-plugin-jsx-a11y": "^4.0.0",
     "eslint-plugin-react": "^6.2.1",
     "jest-cli": "^19.0.2",
     "react": "^15.0.0",

src/components/Tab.js

@@ -67,7 +67,7 @@ export default class Tab extends Component {
           {
             [activeTabClassName]: selected,
             [disabledTabClassName]: disabled,
-          }
+          },
         )}
         ref={(node) => { this.node = node; if (tabRef) tabRef(node); }}
         role="tab"

src/components/TabList.js

@@ -50,7 +50,7 @@ export default class TabList extends Component {
         {...attributes}
         className={cx(
           'ReactTabs__TabList',
-          className
+          className,
         )}
         role="tablist"
       >

src/components/TabPanel.js

@@ -15,11 +15,7 @@ export default class TabPanel extends Component {
   };
 
   static propTypes = {
-    children: PropTypes.oneOfType([
-      PropTypes.array,
-      PropTypes.object,
-      PropTypes.string,
-    ]),
+    children: PropTypes.node,
     className: PropTypes.string,
     id: PropTypes.string,
     selected: PropTypes.bool,
@@ -45,7 +41,7 @@ export default class TabPanel extends Component {
           className,
           {
             'ReactTabs__TabPanel--selected': selected,
-          }
+          },
         )}
         role="tabpanel"
         id={id}

src/components/Tabs.js

@@ -141,16 +141,16 @@ export default class Tabs extends Component {
     let count = 0;
     const children = this.props.children;
     const state = this.state;
-    const tabIds = this.tabIds = this.tabIds || [];
-    const panelIds = this.panelIds = this.panelIds || [];
+    this.tabIds = this.tabIds || [];
+    this.panelIds = this.panelIds || [];
     let diff = this.tabIds.length - this.getTabsCount();
 
     // Add ids if new tabs have been added
     // Don't bother removing ids, just keep them in case they are added again
     // This is more efficient, and keeps the uuid counter under control
     while (diff++ < 0) {
-      tabIds.push(uuid());
-      panelIds.push(uuid());
+      this.tabIds.push(uuid());
+      this.panelIds.push(uuid());
     }
 
     // Map children to dynamically setup refs
@@ -175,8 +175,8 @@ export default class Tabs extends Component {
             }
 
             const tabRef = (node) => { this.tabNodes[`tabs-${index}`] = node; };
-            const id = tabIds[index];
-            const panelId = panelIds[index];
+            const id = this.tabIds[index];
+            const panelId = this.panelIds[index];
             const selected = state.selectedIndex === index;
             const focus = selected && state.focus;
 
@@ -199,8 +199,8 @@ export default class Tabs extends Component {
         // Reset index for panels
         index = 0;
       } else {
-        const id = panelIds[index];
-        const tabId = tabIds[index];
+        const id = this.panelIds[index];
+        const tabId = this.tabIds[index];
         const selected = state.selectedIndex === index;
 
         index++;
@@ -343,7 +343,7 @@ export default class Tabs extends Component {
         className={cx(
           'ReactTabs',
           'react-tabs',
-          className
+          className,
         )}
         onClick={this.handleClick}
         onKeyDown={this.handleKeyDown}

src/components/__tests__/Tab-test.js

@@ -5,6 +5,7 @@ import Tab from '../Tab';
 
 describe('<Tab />', () => {
   beforeAll(() => {
+    // eslint-disable-next-line no-console
     console.error = (error) => {
       throw new Error(error);
     };

src/components/__tests__/TabList-test.js

@@ -12,6 +12,7 @@ function hasClassAt(wrapper, index, className) {
 
 describe('<TabList />', () => {
   beforeAll(() => {
+    // eslint-disable-next-line no-console
     console.error = (error) => {
       throw new Error(error);
     };
@@ -53,7 +54,7 @@ describe('<TabList />', () => {
         </TabList>
         <TabPanel>Foo</TabPanel>
         <TabPanel>Bar</TabPanel>
-      </Tabs>
+      </Tabs>,
     );
 
     const tabsList = wrapper.childAt(0);
@@ -70,7 +71,7 @@ describe('<TabList />', () => {
         </TabList>
         <TabPanel>Foo</TabPanel>
         <TabPanel>Bar</TabPanel>
-      </Tabs>
+      </Tabs>,
     );
 
     const tabsList = wrapper.childAt(0);

src/components/__tests__/TabPanel-test.js

@@ -5,6 +5,7 @@ import TabPanel from '../TabPanel';
 
 describe('<TabPanel />', () => {
   beforeAll(() => {
+    // eslint-disable-next-line no-console
     console.error = (error) => {
       throw new Error(error);
     };

src/components/__tests__/Tabs-test.js

@@ -40,6 +40,7 @@ function assertTabSelected(wrapper, index) {
 
 describe('<Tabs />', () => {
   beforeAll(() => {
+    // eslint-disable-next-line no-console
     console.error = (error) => {
       throw new Error(error);
     };
@@ -224,7 +225,7 @@ describe('<Tabs />', () => {
           <TabList>
             <Tab>Foo</Tab>
           </TabList>
-        </Tabs>
+        </Tabs>,
       );
       console.error = oldConsoleError; // eslint-disable-line no-console
 
@@ -245,7 +246,7 @@ describe('<Tabs />', () => {
 
           <TabPanel>Hello Foo</TabPanel>
           <TabPanel>Hello Bar</TabPanel>
-        </Tabs>
+        </Tabs>,
       );
       console.error = oldConsoleError; // eslint-disable-line no-console
 
@@ -261,7 +262,7 @@ describe('<Tabs />', () => {
             <div />
           </TabList>
           <TabPanel />
-        </Tabs>
+        </Tabs>,
       );
 
       const result = Tabs.propTypes.children(wrapper.props(), 'children', 'Tabs');
@@ -276,7 +277,7 @@ describe('<Tabs />', () => {
       expect(() => shallow(
         <Tabs>
           <TabList />
-        </Tabs>
+        </Tabs>,
       )).not.toThrow();
     });
 
@@ -289,7 +290,7 @@ describe('<Tabs />', () => {
           </TabList>
           <TabPanel>Content A</TabPanel>
           {false && <TabPanel>Content B</TabPanel>}
-        </Tabs>
+        </Tabs>,
       )).not.toThrow();
     });
 
@@ -311,7 +312,7 @@ describe('<Tabs />', () => {
             </Tabs>
           </TabPanel>
           <TabPanel />
-        </Tabs>
+        </Tabs>,
       );
 
       const innerTabs = wrapper.childAt(1).childAt(0);