Skip to content

Commit d8f611a

Browse files
fix(Sandpack): prevent phantom browser history entries on scroll (#8047)
1 parent 9fddeca commit d8f611a

File tree

1 file changed

+10
-6
lines changed

1 file changed

+10
-6
lines changed

src/components/MDX/Sandpack/Preview.tsx

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -97,14 +97,18 @@ export function Preview({
9797

9898
const sandpackIdle = sandpack.status === 'idle';
9999

100-
useEffect(function createBundler() {
101-
const iframeElement = iframeRef.current!;
100+
useEffect(function createBundler() {
101+
const iframeElement = iframeRef.current!;
102+
if (!iframeElement.dataset.registered) {
102103
registerBundler(iframeElement, clientId);
104+
iframeElement.dataset.registered = 'true';
105+
}
106+
return () => {
107+
unregisterBundler(clientId);
108+
iframeElement.dataset.registered = '';
109+
};
110+
}, []);
103111

104-
return () => {
105-
unregisterBundler(clientId);
106-
};
107-
}, []);
108112

109113
useEffect(
110114
function bundlerListener() {

0 commit comments

Comments
 (0)