[Typo]: Section "My subscribe function gets called after every re-render" of useSyncExternalStore documentation is incorrect

[hugmouse]

Summary

In the given context the code that is used in the example will break due to javascript execution flow. subscribe is used before it being defined - it throws Uncaught TypeError: subscribe is not a function.

Page

https://react.dev/reference/react/useSyncExternalStore#my-subscribe-function-gets-called-after-every-re-render

Details

The following code will throw Uncaught TypeError: subscribe is not a function. Fix: declare subscribe before passing it to the useSyncExternalStore.

react.dev/src/content/reference/react/useSyncExternalStore.md

Lines 438 to 447 in b5f5134

	function ChatIndicator({ userId }) {
	const isOnline = useSyncExternalStore(subscribe, getSnapshot);
	// ✅ Same function as long as userId doesn't change
	const subscribe = useCallback(() => {
	// ...
	}, [userId]);
	// ...
	}

[rickhanlonii]

Nice catch, want to submit a PR?

Ideally, all 3 would move the subscribe before uSES. The middle example, moving it to the module, should go above the component (not for syntax reasons, but convention).

[rickhanlonii]

Fixed in #7711, thanks again!