From 342fbd875e3cbce415d88d76f20f47a7bc14b6d1 Mon Sep 17 00:00:00 2001 From: alinkedd Date: Tue, 20 Feb 2024 23:49:21 +0200 Subject: [PATCH 1/2] Fix warning of missing analysis comment artifact --- .github/workflows/analyze.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/analyze.yml b/.github/workflows/analyze.yml index 83e7f2e8a9c..09b20a00c12 100644 --- a/.github/workflows/analyze.yml +++ b/.github/workflows/analyze.yml @@ -84,6 +84,7 @@ jobs: - name: Upload analysis comment uses: actions/upload-artifact@v4 + if: success() && github.event.number with: name: analysis_comment.txt path: .next/analyze/__bundle_analysis_comment.txt From ec6b9dd46475d67c5db8b5d9a2b4e2d686ce8fed Mon Sep 17 00:00:00 2001 From: alinkedd Date: Tue, 20 Feb 2024 23:56:18 +0200 Subject: [PATCH 2/2] Fix comment action failing on default branch --- .github/workflows/analyze_comment.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/analyze_comment.yml b/.github/workflows/analyze_comment.yml index fcac3773869..2453167cbfd 100644 --- a/.github/workflows/analyze_comment.yml +++ b/.github/workflows/analyze_comment.yml @@ -15,8 +15,8 @@ jobs: comment: runs-on: ubuntu-latest if: > - ${{ github.event.workflow_run.event == 'pull_request' && - github.event.workflow_run.conclusion == 'success' }} + github.event.workflow_run.event == 'pull_request' && + github.event.workflow_run.conclusion == 'success' steps: - name: Download base branch bundle stats uses: dawidd6/action-download-artifact@268677152d06ba59fcec7a7f0b5d961b6ccd7e1e