Skip to content

Commit 62a2720

Browse files
authored
Disable 'no-broken-external-links' Remark Rule to Optimize CI Performance by 92% (facebook#4392)
* Comment out the remark-lint plugin configuration in .remarkrc.mjs * Update remark-cli to version 12.0.1 and comment out lint plugin configuration
1 parent a03de1b commit 62a2720

File tree

3 files changed

+55
-430
lines changed

3 files changed

+55
-430
lines changed

website/.remarkrc.mjs

Lines changed: 16 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -2,20 +2,21 @@ import packageJson from "./package.json" assert { type: "json" };
22

33
export default {
44
plugins: [
5-
[
6-
"@react-native-website/remark-lint-no-broken-external-links",
7-
{
8-
skipUrlPatterns: [
9-
// False positive, flagged as a bot and rate limited
10-
"www.apkfiles.com",
11-
// TODO: replace the 2048 example repository with another suitable project
12-
"github.com/JoelMarcey",
13-
],
14-
baseUrl: "https://reactnative.dev/docs",
15-
headers: {
16-
"user-agent": `${packageJson.name}/${packageJson.version}`,
17-
},
18-
},
19-
],
5+
// TODO: Enable the plugin once a more performant solution is found
6+
// [
7+
// "@react-native-website/remark-lint-no-broken-external-links",
8+
// {
9+
// skipUrlPatterns: [
10+
// // False positive, flagged as a bot and rate limited
11+
// "www.apkfiles.com",
12+
// // TODO: replace the 2048 example repository with another suitable project
13+
// "github.com/JoelMarcey",
14+
// ],
15+
// baseUrl: "https://reactnative.dev/docs",
16+
// headers: {
17+
// "user-agent": `${packageJson.name}/${packageJson.version}`,
18+
// },
19+
// },
20+
// ],
2021
],
2122
};

website/package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,8 +73,7 @@
7373
"glob": "^8.0.3",
7474
"glob-promise": "^4.2.2",
7575
"path": "^0.12.7",
76-
"remark-cli": "^11.0.0",
77-
"remark-lint-no-dead-urls": "^1.1.0",
76+
"remark-cli": "^12.0.1",
7877
"typescript": "^5.7.2"
7978
}
8079
}

0 commit comments

Comments
 (0)