OpenJDK 13 requires -XX:+AllowRedefinitionToAddDeleteMethods flag

[juergenzimmermann]

OpenJDK 12.0.1 with even Kotlin 1.3.40-eap-67 works fine. However, using OpenJDK 13 build 23 I get the following exception:

Exception in thread "main" java.lang.RuntimeException: java.lang.UnsupportedOperationException: class redefinition failed: attempted to add a method
        at reactor.blockhound.BlockHound$Builder.install(BlockHound.java:264)
        at reactor.blockhound.BlockHound.install(BlockHound.java:64)
        at de.hska.kunde.ApplicationKt.main(Application.kt:51)
Caused by: java.lang.UnsupportedOperationException: class redefinition failed: attempted to add a method
        at java.instrument/sun.instrument.InstrumentationImpl.retransformClasses0(Native Method)
        at java.instrument/sun.instrument.InstrumentationImpl.retransformClasses(InstrumentationImpl.java:167)
        at reactor.blockhound.BlockHound$Builder.instrument(BlockHound.java:273)
        at reactor.blockhound.BlockHound$Builder.install(BlockHound.java:261)
        ... 2 more

[bsideup]

Hi @juergenzimmermann,

I'm afraid that's due to https://bugs.openjdk.java.net/browse/JDK-8192936 and similar to #21
In JDK 13+, they adjusted the spec & impl and no longer allow redefining native methods :(

We will need to find an alternative way for 13+ and J9, meanwhile, they seem to plan adding a flag to keep the behaviour for a few versions:
https://bugs.openjdk.java.net/browse/JDK-8192936?focusedCommentId=14254266&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14254266

[juergenzimmermann]

@bsideup When I use -XX:+AllowRedefinitionToAddDeleteMethods the stacktrace goes away

[bsideup]

@juergenzimmermann thanks a lot for trying it!
I will keep this issue open as a reminder to document this flag 👍

[yburkouski]

Heaving quite different behavior on Oracle JDK 13 in Windows: it does not throw an error about blocking call until I add this flag

[sergey-morenets]

Still reproduced with JDK 14.0.1 and BlockHound 1.0.3