Revert IdleTimeoutHandler on HttpClient

Signed-off-by: raccoonback <[email protected]>

Author: raccoonback

docs/modules/ROOT/pages/http-client.adoc

@@ -680,50 +680,6 @@ include::{examples-dir}/channeloptions/Application.java[lines=18..54]
 <4> Configures the time between individual `keepalive` probes to 1 minute.
 <5> Configures the maximum number of TCP `keepalive` probes to 8.
 
-
-==== IdleTimeout
-The maximum time (resolution: ms) that this connection stays opened and waits for HTTP request. Once the timeout is reached, the connection is closed.
-By default, `idleTimeout` is not specified, this indicates no timeout (i.e. infinite), which means the connection is closed only if one of the peers decides to close it explicitly.
-
-NOTE: It is always a good practice to configure an idle timeout.
-
-To customize the default settings, you can configure `HttpClient` as follows:
-
-{examples-link}/idle/timeout/Application.java
-----
-include::{examples-dir}/idle/timeout/Application.java[lines=26..44]
-----
-<1> Configures the default idle timeout to 1 second.
-
-===== Configuring Ping Frame for HTTP/2 Health Check
-When using the HTTP/2 protocol, it is recommended to configure a *PING* frame to maintain the connection and ensure timely health checks.
-The HttpClient in Reactor Netty allows setting up a  *PING* frame to prevent idle connections from being prematurely closed when *idleTimeout* is configured.
-
-[NOTE]
-====
-To enable HTTP/2 PING frame-based health checks, you must configure `idleTimeout`.
-Without `idleTimeout`, the connection may remain open indefinitely, preventing proper detection of inactive or unresponsive connections.
-Setting an appropriate `idleTimeout` ensures that PING-based health checks can effectively terminate unresponsive connections.
-====
-
-*Benefits of Using PING Frames*
-
-- Actively monitors connection health by checking real-time responses to *PING* frames.
-- Ensures that health checks detect unresponsive connections quickly.
-- Helps maintain long-lived connections in an efficient manner.
-
-To enable *PING* frames for HTTP/2 connections, configure the HttpClient as follows:
-
-{examples-link}/liveness/Application.java
-----
-include::{examples-dir}/liveness/Application.java[lines=26..49]
-----
-<1> To set up a health check using HTTP2 Ping frame, `idleTimeout` must be set first.
-<2> Sets the interval for sending `HTTP/2` `PING` frames and receiving `ACK` responses
-<3> Sets the execution interval for the scheduler that sends `HTTP/2` `PING frames and periodically checks for `ACK` responses
-<4> Sets the threshold for retrying `HTTP/2` `PING` frame transmissions.
-
-
 [[ssl-tls-timeout]]
 ==== SSL/TLS Timeout
 `HttpClient` supports the SSL/TLS functionality provided by Netty.

reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/http/client/idle/timeout/Application.java

@@ -456,32 +456,4 @@ public Builder pushEnabled(boolean pushEnabled) {
 		}
 		*/
 	}
-
-	public Http2Settings http2Settings() {
-		Http2Settings settings = Http2Settings.defaultSettings();
-
-		if (headerTableSize != null) {
-			settings.headerTableSize(headerTableSize);
-		}
-
-		if (initialWindowSize != null) {
-			settings.initialWindowSize(initialWindowSize);
-		}
-
-		if (maxConcurrentStreams != null) {
-			settings.maxConcurrentStreams(maxConcurrentStreams);
-		}
-
-		if (maxFrameSize != null) {
-			settings.maxFrameSize(maxFrameSize);
-		}
-
-		settings.maxHeaderListSize(maxHeaderListSize);
-
-		if (pushEnabled != null) {
-			settings.pushEnabled(pushEnabled);
-		}
-
-		return settings;
-	}
 }

reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/http/client/liveness/Application.java

@@ -18,8 +18,6 @@
 import io.netty.channel.ChannelHandler;
 import io.netty.channel.ChannelHandlerContext;
 import io.netty.channel.ChannelPipeline;
-import io.netty.handler.codec.http.HttpClientCodec;
-import io.netty.handler.codec.http.HttpClientUpgradeHandler;
 import io.netty.handler.codec.http.HttpServerCodec;
 import io.netty.handler.codec.http.HttpServerUpgradeHandler;
 import io.netty.handler.timeout.IdleState;
@@ -123,45 +121,6 @@ public static void addIdleTimeoutServerHandler(ChannelPipeline pipeline, @Nullab
 		}
 	}
 
-	/**
-	 * Adds an idle timeout handler to the client pipeline.
-	 * This handler will close the connection if it remains idle for the specified duration.
-	 *
-	 * @param pipeline               the channel pipeline to which the handler will be added
-	 * @param idleTimeout            the duration of idle time after which the connection will be closed
-	 * @param httpConnectionLiveness the HTTP connection liveness checker to be used
-	 */
-	public static void addIdleTimeoutClientHandler(ChannelPipeline pipeline, @Nullable Duration idleTimeout,
-	                                               HttpConnectionLiveness httpConnectionLiveness) {
-		if (idleTimeout != null && pipeline.get(NettyPipeline.IdleTimeoutHandler) == null) {
-			String baseName = null;
-			if (pipeline.get(NettyPipeline.HttpCodec) != null) {
-				baseName = NettyPipeline.HttpCodec;
-			}
-			else {
-				ChannelHandler httpClientUpgradeHandler = pipeline.get(HttpClientUpgradeHandler.class);
-				if (httpClientUpgradeHandler != null) {
-					baseName = pipeline.context(httpClientUpgradeHandler).name();
-				}
-				else {
-					ChannelHandler httpClientCodec = pipeline.get(HttpClientCodec.class);
-					if (httpClientCodec != null) {
-						baseName = pipeline.context(httpClientCodec).name();
-					}
-				}
-			}
-
-			pipeline.addAfter(
-					baseName,
-					NettyPipeline.IdleTimeoutHandler,
-					new IdleTimeoutHandler(
-							idleTimeout.toMillis(),
-							httpConnectionLiveness
-					)
-			);
-		}
-	}
-
 	/**
 	 * Removes the idle timeout handler from the pipeline if it exists.
 	 *

reactor-netty-http/src/main/java/reactor/netty/http/Http2SettingsSpec.java

@@ -1095,25 +1095,6 @@ public final HttpClient headersWhen(Function<? super HttpHeaders, Mono<? extends
 		return dup;
 	}
 
-	/**
-	 * Specifies an idle timeout on the connection when it is waiting for an HTTP request (resolution: ms).
-	 * Once the timeout is reached the connection will be closed.
-	 * <p>If an {@code idleTimeout} is not specified, this indicates no timeout (i.e. infinite),
-	 * which means the connection will be closed only if one of the peers decides to close it.
-	 * <p>If the {@code idleTimeout} is less than {@code 1ms}, then {@code 1ms} will be the idle timeout.
-	 * <p>By default {@code idleTimeout} is not specified.
-	 *
-	 * @param idleTimeout an idle timeout on the connection when it is waiting for an HTTP request (resolution: ms)
-	 * @return a new {@link HttpClient}
-	 * @since 1.2.5
-	 */
-	public final HttpClient idleTimeout(Duration idleTimeout) {
-		Objects.requireNonNull(idleTimeout, "idleTimeout");
-		HttpClient dup = duplicate();
-		dup.configuration().idleTimeout = idleTimeout;
-		return dup;
-	}
-
 	/**
 	 * Apply HTTP/2 configuration.
 	 *