Skip to content

Commit 8280258

Browse files
authored
Merge pull request #96 from clue-labs/tests
Skip failing tests on bugged versions (PHP 8.1.7 and PHP 8.0.20 only)
2 parents 127eadc + b9567da commit 8280258

File tree

1 file changed

+16
-0
lines changed

1 file changed

+16
-0
lines changed

tests/AbstractProcessTest.php

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -643,6 +643,10 @@ public function testDetectsClosingStdoutWithoutHavingToWaitForExit()
643643
$this->markTestSkipped('Process pipes not supported on Windows');
644644
}
645645

646+
if (PHP_VERSION_ID === 80107 || PHP_VERSION_ID === 80020) {
647+
$this->markTestSkipped('Skip bugged PHP version: https://github.com/php/php-src/issues/8827');
648+
}
649+
646650
$cmd = 'exec ' . $this->getPhpBinary() . ' -r ' . escapeshellarg('fclose(STDOUT); sleep(1);');
647651

648652
$loop = $this->createLoop();
@@ -669,6 +673,10 @@ public function testDetectsClosingStdoutWithoutHavingToWaitForExit()
669673
*/
670674
public function testDetectsClosingStdoutSocketWithoutHavingToWaitForExit()
671675
{
676+
if (PHP_VERSION_ID === 80107 || PHP_VERSION_ID === 80020) {
677+
$this->markTestSkipped('Skip bugged PHP version: https://github.com/php/php-src/issues/8827');
678+
}
679+
672680
$loop = $this->createLoop();
673681
$process = new Process(
674682
(DIRECTORY_SEPARATOR === '\\' ? '' : 'exec ') . $this->getPhpBinary() . ' -r ' . escapeshellarg('fclose(STDOUT); sleep(1);'),
@@ -703,6 +711,10 @@ public function testKeepsRunningEvenWhenAllStdioPipesHaveBeenClosed()
703711
$this->markTestSkipped('Process pipes not supported on Windows');
704712
}
705713

714+
if (PHP_VERSION_ID === 80107 || PHP_VERSION_ID === 80020) {
715+
$this->markTestSkipped('Skip bugged PHP version: https://github.com/php/php-src/issues/8827');
716+
}
717+
706718
$cmd = 'exec ' . $this->getPhpBinary() . ' -r ' . escapeshellarg('fclose(STDIN);fclose(STDOUT);fclose(STDERR);sleep(1);');
707719

708720
$loop = $this->createLoop();
@@ -738,6 +750,10 @@ public function testKeepsRunningEvenWhenAllStdioPipesHaveBeenClosed()
738750
*/
739751
public function testKeepsRunningEvenWhenAllStdioSocketsHaveBeenClosed()
740752
{
753+
if (PHP_VERSION_ID === 80107 || PHP_VERSION_ID === 80020) {
754+
$this->markTestSkipped('Skip bugged PHP version: https://github.com/php/php-src/issues/8827');
755+
}
756+
741757
$loop = $this->createLoop();
742758
$process = new Process(
743759
(DIRECTORY_SEPARATOR === '\\' ? '' : 'exec ') . $this->getPhpBinary() . ' -r ' . escapeshellarg('fclose(STDIN);fclose(STDOUT);fclose(STDERR);sleep(1);'),

0 commit comments

Comments
 (0)