Accessing socket address must not report errors accross all PHP versions

clue · clue · commit a6ac2362f1c6 · 2017-01-22T20:10:29.000+01:00
diff --git a/src/Socket.php b/src/Socket.php
@@ -36,16 +36,12 @@ public function __construct(LoopInterface $loop, $socket, Buffer $buffer = null)
 
     public function getLocalAddress()
     {
-        if ($this->socket !== false) {
-            return $this->sanitizeAddress(stream_socket_get_name($this->socket, false));
-        }
+        return $this->sanitizeAddress(@stream_socket_get_name($this->socket, false));
     }
 
     public function getRemoteAddress()
     {
-        if ($this->socket !== false) {
-            return $this->sanitizeAddress(stream_socket_get_name($this->socket, true));
-        }
+        return $this->sanitizeAddress(@stream_socket_get_name($this->socket, true));
     }
 
     public function send($data, $remoteAddress = null)

Original file line number	Diff line number	Diff line change
`@@ -36,16 +36,12 @@ public function __construct(LoopInterface $loop, $socket, Buffer $buffer = null)`
`36`	`36`
`37`	`37`	`public function getLocalAddress()`
`38`	`38`	`{`
`39`		`- if ($this->socket !== false) {`
`40`		`- return $this->sanitizeAddress(stream_socket_get_name($this->socket, false));`
`41`		`- }`
	`39`	`+ return $this->sanitizeAddress(@stream_socket_get_name($this->socket, false));`
`42`	`40`	`}`
`43`	`41`
`44`	`42`	`public function getRemoteAddress()`
`45`	`43`	`{`
`46`		`- if ($this->socket !== false) {`
`47`		`- return $this->sanitizeAddress(stream_socket_get_name($this->socket, true));`
`48`		`- }`
	`44`	`+ return $this->sanitizeAddress(@stream_socket_get_name($this->socket, true));`
`49`	`45`	`}`
`50`	`46`
`51`	`47`	`public function send($data, $remoteAddress = null)`