Explicitly ignore UDP read errors

Author: clue

src/Query/UdpTransportExecutor.php

@@ -174,6 +174,9 @@ public function query(Query $query)
             // try to read a single data packet from the DNS server
             // ignoring any errors, this is uses UDP packets and not a stream of data
             $data = @\fread($socket, $max);
+            if ($data === false) {
+                return;
+            }
 
             try {
                 $response = $parser->parseMessage($data);

tests/Query/UdpTransportExecutorTest.php

@@ -158,6 +158,39 @@ public function testQueryRejectsIfSendToServerFailsAfterConnection()
         throw $exception;
     }
 
+    public function testQueryKeepsPendingIfReadFailsBecauseServerRefusesConnection()
+    {
+        $socket = null;
+        $callback = null;
+        $loop = $this->getMockBuilder('React\EventLoop\LoopInterface')->getMock();
+        $loop->expects($this->once())->method('addReadStream')->with($this->callback(function ($ref) use (&$socket) {
+            $socket = $ref;
+            return true;
+        }), $this->callback(function ($ref) use (&$callback) {
+            $callback = $ref;
+            return true;
+        }));
+
+        $executor = new UdpTransportExecutor('0.0.0.0', $loop);
+
+        $query = new Query('reactphp.org', Message::TYPE_A, Message::CLASS_IN);
+        $promise = $executor->query($query);
+
+        $this->assertNotNull($socket);
+        $callback($socket);
+
+        $this->assertInstanceOf('React\Promise\PromiseInterface', $promise);
+
+        $pending = true;
+        $promise->then(function () use (&$pending) {
+            $pending = false;
+        }, function () use (&$pending) {
+            $pending = false;
+        });
+
+        $this->assertTrue($pending);
+    }
+
     /**
      * @group internet
      */
@@ -177,27 +210,6 @@ public function testQueryRejectsOnCancellation()
         $promise->then(null, $this->expectCallableOnce());
     }
 
-    public function testQueryKeepsPendingIfServerRejectsNetworkPacket()
-    {
-        $loop = Factory::create();
-
-        $executor = new UdpTransportExecutor('127.0.0.1:1', $loop);
-
-        $query = new Query('google.com', Message::TYPE_A, Message::CLASS_IN);
-
-        $wait = true;
-        $promise = $executor->query($query)->then(
-            null,
-            function ($e) use (&$wait) {
-                $wait = false;
-                throw $e;
-            }
-        );
-
-        \Clue\React\Block\sleep(0.2, $loop);
-        $this->assertTrue($wait);
-    }
-
     public function testQueryKeepsPendingIfServerSendsInvalidMessage()
     {
         $loop = Factory::create();