Skip to content

Commit a3f40af

Browse files
committed
[3.x] Increase query count in excessive TCP query tests
In a recent Ubuntu 24.04 runner update something changed that makes PHP code seemingly more performant. In #236 this issue is shown to have something to do with 24.04 because without code changes it works on 22 .04. However, that doesn't fix the underlying issue. While I'm not sure what changed, by increasing these two numbers by 10 folding them we're back at passing tests,
1 parent 967dac8 commit a3f40af

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

tests/Query/TcpTransportExecutorTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -337,7 +337,7 @@ public function testQueryStaysPendingWhenClientCanNotSendExcessiveMessageInOneCh
337337
$query = new Query('google' . str_repeat('.com', 100), Message::TYPE_A, Message::CLASS_IN);
338338

339339
// send a bunch of queries and keep reference to last promise
340-
for ($i = 0; $i < 2000; ++$i) {
340+
for ($i = 0; $i < 20000; ++$i) {
341341
$promise = $executor->query($query);
342342
}
343343

@@ -372,7 +372,7 @@ public function testQueryRejectsWhenClientKeepsSendingWhenServerClosesSocketWith
372372

373373
// send a bunch of queries and keep reference to last promise
374374
$exception = null;
375-
for ($i = 0; $i < 2000; ++$i) {
375+
for ($i = 0; $i < 20000; ++$i) {
376376
$promise = $executor->query($query);
377377
$promise->then(null, function (\Exception $reason) use (&$exception) {
378378
$exception = $reason;

0 commit comments

Comments
 (0)