Skip to content

Commit ce5ebe1

Browse files
dbuSimonFrings
andcommitted
fix references to the deprecated factory
the readme should not recommend to use the factory anymore but Loop::create Co-authored-by: Simon Frings <[email protected]>
1 parent be6dee4 commit ce5ebe1

File tree

3 files changed

+11
-9
lines changed

3 files changed

+11
-9
lines changed

README.md

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -339,7 +339,7 @@ All of the event loops support these features:
339339

340340
For most consumers of this package, the underlying event loop implementation is
341341
an implementation detail.
342-
You should use the [`Factory`](#factory) to automatically create a new instance.
342+
You should use the [`Loop` class](#loop) to automatically create a new instance.
343343

344344
Advanced! If you explicitly need a certain event loop implementation, you can
345345
manually instantiate one of the following classes.
@@ -356,8 +356,9 @@ function and is the only implementation which works out of the box with PHP.
356356
This event loop works out of the box on PHP 5.3 through PHP 7+ and HHVM.
357357
This means that no installation is required and this library works on all
358358
platforms and supported PHP versions.
359-
Accordingly, the [`Factory`](#factory) will use this event loop by default if
360-
you do not install any of the event loop extensions listed below.
359+
Accordingly, the [`Loop` class](#loop) and the deprecated [`Factory`](#factory)
360+
will use this event loop by default if you do not install any of the event loop
361+
extensions listed below.
361362

362363
Under the hood, it does a simple `select` system call.
363364
This system call is limited to the maximum file descriptor number of
@@ -433,8 +434,8 @@ This event loop does only work with PHP 5.
433434
An [unofficial update](https://github.com/php/pecl-event-libevent/pull/2) for
434435
PHP 7 does exist, but it is known to cause regular crashes due to `SEGFAULT`s.
435436
To reiterate: Using this event loop on PHP 7 is not recommended.
436-
Accordingly, the [`Factory`](#factory) will not try to use this event loop on
437-
PHP 7.
437+
Accordingly, neither the [`Loop` object](#loop) nor the deprecated
438+
[`Factory`](#factory) will try to use this event loop on PHP 7.
438439

439440
This event loop is known to trigger a readable listener only if
440441
the stream *becomes* readable (edge-triggered) and may not trigger if the

src/ExtLibeventLoop.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@
2020
* An [unofficial update](https://github.com/php/pecl-event-libevent/pull/2) for
2121
* PHP 7 does exist, but it is known to cause regular crashes due to `SEGFAULT`s.
2222
* To reiterate: Using this event loop on PHP 7 is not recommended.
23-
* Accordingly, the [`Factory`](#factory) will not try to use this event loop on
24-
* PHP 7.
23+
* Accordingly, neither the [`Loop` object](#loop) nor the deprecated
24+
* [`Factory`](#factory) will try to use this event loop on PHP 7.
2525
*
2626
* This event loop is known to trigger a readable listener only if
2727
* the stream *becomes* readable (edge-triggered) and may not trigger if the

src/StreamSelectLoop.php

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,9 @@
1515
* This event loop works out of the box on PHP 5.4 through PHP 7+ and HHVM.
1616
* This means that no installation is required and this library works on all
1717
* platforms and supported PHP versions.
18-
* Accordingly, the [`Factory`](#factory) will use this event loop by default if
19-
* you do not install any of the event loop extensions listed below.
18+
* Accordingly, the [`Loop` class](#loop) and the deprecated [`Factory`](#factory)
19+
* will use this event loop by default if you do not install any of the event loop
20+
* extensions listed below.
2021
*
2122
* Under the hood, it does a simple `select` system call.
2223
* This system call is limited to the maximum file descriptor number of

0 commit comments

Comments
 (0)