Skip to content

Commit de36307

Browse files
committed
Merge branch 'refs/heads/socket-client' into 0.3-client-merge
Conflicts: composer.lock src/React/HttpClient/Client.php src/React/HttpClient/Request.php tests/React/Tests/HttpClient/RequestTest.php
2 parents c0e3807 + 62a0238 commit de36307

File tree

6 files changed

+18
-184
lines changed

6 files changed

+18
-184
lines changed

Client.php

Lines changed: 7 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -3,57 +3,33 @@
33
namespace React\HttpClient;
44

55
use React\EventLoop\LoopInterface;
6-
use React\HttpClient\ConnectionManager;
76
use React\HttpClient\Request;
8-
use React\HttpClient\SecureConnectionManager;
7+
use React\SocketClient\ConnectorInterface;
98

109
class Client
1110
{
1211
private $loop;
1312
private $connectionManager;
1413
private $secureConnectionManager;
1514

16-
public function __construct(LoopInterface $loop, ConnectionManagerInterface $connectionManager, ConnectionManagerInterface $secureConnectionManager)
15+
public function __construct(LoopInterface $loop, ConnectorInterface $connector, ConnectorInterface $secureConnector)
1716
{
1817
$this->loop = $loop;
19-
$this->connectionManager = $connectionManager;
20-
$this->secureConnectionManager = $secureConnectionManager;
18+
$this->connector = $connector;
19+
$this->secureConnector = $secureConnector;
2120
}
2221

2322
public function request($method, $url, array $headers = array())
2423
{
2524
$requestData = new RequestData($method, $url, $headers);
26-
$connectionManager = $this->getConnectionManagerForScheme($requestData->getScheme());
25+
$connectionManager = $this->getConnectorForScheme($requestData->getScheme());
2726
return new Request($this->loop, $connectionManager, $requestData);
28-
}
29-
30-
public function setConnectionManager(ConnectionManagerInterface $connectionManager)
31-
{
32-
$this->connectionManager = $connectionManager;
33-
}
3427

35-
public function getConnectionManager()
36-
{
37-
return $this->connectionManager;
38-
}
39-
40-
public function setSecureConnectionManager(ConnectionManagerInterface $connectionManager)
41-
{
42-
$this->secureConnectionManager = $connectionManager;
43-
}
44-
45-
public function getSecureConnectionManager()
46-
{
47-
return $this->secureConnectionManager;
4828
}
4929

50-
private function getConnectionManagerForScheme($scheme)
30+
private function getConnectorForScheme($scheme)
5131
{
52-
if ('https' === $scheme) {
53-
return $this->getSecureConnectionManager();
54-
} else {
55-
return $this->getConnectionManager();
56-
}
32+
return ('https' === $scheme) ? $this->secureConnector : $this->connector;
5733
}
5834
}
5935

ConnectionManager.php

Lines changed: 0 additions & 89 deletions
This file was deleted.

ConnectionManagerInterface.php

Lines changed: 0 additions & 8 deletions
This file was deleted.

Factory.php

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,16 @@
44

55
use React\EventLoop\LoopInterface;
66
use React\Dns\Resolver\Resolver;
7+
use React\SocketClient\Connector;
8+
use React\SocketClient\SecureConnector;
79

810
class Factory
911
{
1012
public function create(LoopInterface $loop, Resolver $resolver)
1113
{
12-
$connectionManager = new ConnectionManager($loop, $resolver);
13-
$secureConnectionManager = new SecureConnectionManager($loop, $resolver);
14-
return new Client($loop, $connectionManager, $secureConnectionManager);
14+
$connector = new Connector($loop, $resolver);
15+
$secureConnector = new SecureConnector($connector, $loop);
16+
return new Client($loop, $connector, $secureConnector);
1517
}
1618
}
1719

Request.php

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,9 @@
55
use Evenement\EventEmitter;
66
use Guzzle\Parser\Message\MessageParser;
77
use React\EventLoop\LoopInterface;
8-
use React\HttpClient\ConnectionManagerInterface;
98
use React\HttpClient\Response;
109
use React\HttpClient\ResponseHeaderParser;
10+
use React\SocketClient\ConnectorInterface;
1111
use React\Stream\Stream;
1212
use React\Stream\WritableStreamInterface;
1313

@@ -23,7 +23,7 @@ class Request extends EventEmitter implements WritableStreamInterface
2323
const STATE_END = 3;
2424

2525
private $loop;
26-
private $connectionManager;
26+
private $connector;
2727
private $requestData;
2828

2929
private $stream;
@@ -32,10 +32,10 @@ class Request extends EventEmitter implements WritableStreamInterface
3232
private $response;
3333
private $state = self::STATE_INIT;
3434

35-
public function __construct(LoopInterface $loop, ConnectionManagerInterface $connectionManager, RequestData $requestData)
35+
public function __construct(LoopInterface $loop, ConnectorInterface $connector, RequestData $requestData)
3636
{
3737
$this->loop = $loop;
38-
$this->connectionManager = $connectionManager;
38+
$this->connector = $connector;
3939
$this->requestData = $requestData;
4040
}
4141

@@ -217,8 +217,8 @@ protected function connect()
217217
$host = $this->requestData->getHost();
218218
$port = $this->requestData->getPort();
219219

220-
return $this->connectionManager
221-
->getConnection($host, $port);
220+
return $this->connector
221+
->createTcp($host, $port);
222222
}
223223

224224
public function setResponseFactory($factory)

SecureConnectionManager.php

Lines changed: 0 additions & 47 deletions
This file was deleted.

0 commit comments

Comments
 (0)