Improve _checkTypehint for PHP8+

PHP8's reflection API changed to make room for handling of union-types. As one of the consequences `ReflectionParameter::getClass` got marked as deprecated.
While the bug got already fixed in the meantime, the proposed code clears up the code-path for future features like PHP8.1's intersection-types.

Author: bzikarsky

src/functions.php

@@ -341,43 +341,49 @@ function _checkTypehint(callable $callback, $object)
         return true;
     }
 
-    if (\PHP_VERSION_ID < 70100 || \defined('HHVM_VERSION')) {
-        $expectedException = $parameters[0];
+    $expectedException = $parameters[0];
 
+    // PHP before v8 used an easy API:
+    if (\PHP_VERSION_ID < 70100 || \defined('HHVM_VERSION')) {
         if (!$expectedException->getClass()) {
             return true;
         }
 
         return $expectedException->getClass()->isInstance($object);
-    } else {
-        $type = $parameters[0]->getType();
-
-        if (!$type) {
-            return true;
-        }
-
-        $types = [$type];
+    }
 
-        if ($type instanceof \ReflectionUnionType) {
+    // Extract the type of the argument and handle different possibilities
+    $type = $expectedException->getType();
+    $types = [];
+
+    switch (true) {
+        case $type === null:
+            break;
+        case $type instanceof \ReflectionNamedType:
+            $types = [$type];
+            break;
+        case $type instanceof \ReflectionUnionType;
             $types = $type->getTypes();
-        }
-
-        $mismatched = false;
-
-        foreach ($types as $type) {
-            if (!$type || $type->isBuiltin()) {
-                continue;
-            }
+            break;
+        default:
+            throw new \LogicException('Unexpected return value of ReflectionParameter::getType');
+    }
 
-            $expectedClass = $type->getName();
+    // If there is no type restriction, it matches
+    if (empty($types)) {
+        return true;
+    }
 
-            if ($object instanceof $expectedClass) {
-                return true;
-            }
+    // Search for one matching named-type for success, otherwise return false
+    // A named-type can be either a class-name or a built-in type like string, int, array, etc.
+    foreach ($types as $type) {
+        $matches = ($type->isBuiltin() && \gettype($object) === $type->getName())
+            || (new \ReflectionClass($type->getName()))->isInstance($object);
 
-            $mismatched = true;
+        if ($matches) {
+            return true;
         }
-
-        return !$mismatched;
     }
+
+    return false;
 }