Skip to content

Commit e400476

Browse files
authored
Merge pull request #162 from clue-labs/php7.4
Test PHP 7.4 on Travis
2 parents 8d05ffd + 6ee24c2 commit e400476

File tree

2 files changed

+5
-0
lines changed

2 files changed

+5
-0
lines changed

.travis.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ php:
44
- 7.1
55
- 7.2
66
- 7.3
7+
- 7.4
78
- nightly # ignore errors, see below
89

910
# lock distro so new future defaults will not break the build

tests/DeferredTest.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,8 @@ public function shouldRejectWithoutCreatingGarbageCyclesIfCancellerRejectsWithEx
3737
public function shouldRejectWithoutCreatingGarbageCyclesIfParentCancellerRejectsWithException()
3838
{
3939
gc_collect_cycles();
40+
gc_collect_cycles(); // clear twice to avoid leftovers in PHP 7.4 with ext-xdebug and code coverage turned on
41+
4042
$deferred = new Deferred(function ($resolve, $reject) {
4143
$reject(new \Exception('foo'));
4244
});
@@ -50,6 +52,8 @@ public function shouldRejectWithoutCreatingGarbageCyclesIfParentCancellerRejects
5052
public function shouldRejectWithoutCreatingGarbageCyclesIfCancellerHoldsReferenceAndExplicitlyRejectWithException()
5153
{
5254
gc_collect_cycles();
55+
gc_collect_cycles(); // clear twice to avoid leftovers in PHP 7.4 with ext-xdebug and code coverage turned on
56+
5357
$deferred = new Deferred(function () use (&$deferred) { });
5458
$deferred->reject(new \Exception('foo'));
5559
unset($deferred);

0 commit comments

Comments
 (0)