Merge pull request #210 from bzikarsky/bz/deprecated-warning-fix

clue · web-flow · commit ec444aaf94aa · 2022-02-07T13:21:04.000+01:00
Improve test suite to fix default Exception message (PHP 8.1)
diff --git a/tests/Internal/RejectedPromiseTest.php b/tests/Internal/RejectedPromiseTest.php
@@ -34,7 +34,7 @@ public function getPromiseTestAdapter(callable $canceller = null)
                     $promise = new RejectedPromise($reason);
                 }
             },
-            'settle' => function ($reason = null) use (&$promise) {
+            'settle' => function ($reason = "") use (&$promise) {
                 if (!$promise) {
                     if (!$reason instanceof Exception) {
                         $reason = new Exception($reason);

Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,7 @@ public function getPromiseTestAdapter(callable $canceller = null)`
`34`	`34`	`$promise = new RejectedPromise($reason);`
`35`	`35`	`}`
`36`	`36`	`},`
`37`		`- 'settle' => function ($reason = null) use (&$promise) {`
	`37`	`+ 'settle' => function ($reason = "") use (&$promise) {`
`38`	`38`	`if (!$promise) {`
`39`	`39`	`if (!$reason instanceof Exception) {`
`40`	`40`	`$reason = new Exception($reason);`