Skip to content

Commit 1218d5a

Browse files
authored
Merge pull request #181 from carusogabriel/assert-instace-of
Use dedicated assertInstanceOf assertion
2 parents 6cb21be + 654f618 commit 1218d5a

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

tests/FunctionalSecureServerTest.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -421,7 +421,7 @@ public function testEmitsErrorIfConnectionIsClosedBeforeHandshake()
421421
$error = Block\await($errorEvent, $loop, self::TIMEOUT);
422422

423423
// Connection from tcp://127.0.0.1:39528 failed during TLS handshake: Connection lost during TLS handshak
424-
$this->assertTrue($error instanceof \RuntimeException);
424+
$this->assertInstanceOf('RuntimeException', $error);
425425
$this->assertStringStartsWith('Connection from tcp://', $error->getMessage());
426426
$this->assertStringEndsWith('failed during TLS handshake: Connection lost during TLS handshake', $error->getMessage());
427427
$this->assertEquals(defined('SOCKET_ECONNRESET') ? SOCKET_ECONNRESET : 0, $error->getCode());
@@ -449,7 +449,7 @@ public function testEmitsErrorIfConnectionIsClosedWithIncompleteHandshake()
449449
$error = Block\await($errorEvent, $loop, self::TIMEOUT);
450450

451451
// Connection from tcp://127.0.0.1:39528 failed during TLS handshake: Connection lost during TLS handshak
452-
$this->assertTrue($error instanceof \RuntimeException);
452+
$this->assertInstanceOf('RuntimeException', $error);
453453
$this->assertStringStartsWith('Connection from tcp://', $error->getMessage());
454454
$this->assertStringEndsWith('failed during TLS handshake: Connection lost during TLS handshake', $error->getMessage());
455455
$this->assertEquals(defined('SOCKET_ECONNRESET') ? SOCKET_ECONNRESET : 0, $error->getCode());
@@ -494,7 +494,7 @@ public function testEmitsErrorIfConnectionIsHttpInsteadOfSecureHandshake()
494494

495495
$error = Block\await($errorEvent, $loop, self::TIMEOUT);
496496

497-
$this->assertTrue($error instanceof \RuntimeException);
497+
$this->assertInstanceOf('RuntimeException', $error);
498498

499499
// OpenSSL error messages are version/platform specific
500500
// Unable to complete TLS handshake: SSL operation failed with code 1. OpenSSL Error messages: error:1408F10B:SSL routines:SSL3_GET_RECORD:http request
@@ -523,7 +523,7 @@ public function testEmitsErrorIfConnectionIsUnknownProtocolInsteadOfSecureHandsh
523523

524524
$error = Block\await($errorEvent, $loop, self::TIMEOUT);
525525

526-
$this->assertTrue($error instanceof \RuntimeException);
526+
$this->assertInstanceOf('RuntimeException', $error);
527527

528528
// OpenSSL error messages are version/platform specific
529529
// Unable to complete TLS handshake: SSL operation failed with code 1. OpenSSL Error messages: error:1408F10B:SSL routines:SSL3_GET_RECORD:unknown protocol

0 commit comments

Comments
 (0)