Avoid failing test by using invalid DNS resolver IP instead of h… (#210)

WyriHaximus · web-flow · commit b1dee1e2ef6c · 2019-08-16T21:56:39.000+02:00
Avoid failing test by using invalid DNS resolver IP instead of hostname
diff --git a/tests/IntegrationTest.php b/tests/IntegrationTest.php
@@ -99,12 +99,12 @@ public function gettingPlaintextStuffFromEncryptedGoogleShouldNotWork()
         $this->assertNotRegExp('#^HTTP/1\.0#', $response);
     }
 
-    public function testConnectingFailsIfDnsUsesInvalidResolver()
+    public function testConnectingFailsIfConnectorUsesInvalidDnsResolverAddress()
     {
         $loop = Factory::create();
 
         $factory = new ResolverFactory();
-        $dns = $factory->create('demo.invalid', $loop);
+        $dns = $factory->create('255.255.255.255', $loop);
 
         $connector = new Connector($loop, array(
             'dns' => $dns

Original file line number	Diff line number	Diff line change
`@@ -99,12 +99,12 @@ public function gettingPlaintextStuffFromEncryptedGoogleShouldNotWork()`
`99`	`99`	`$this->assertNotRegExp('#^HTTP/1\.0#', $response);`
`100`	`100`	`}`
`101`	`101`
`102`		`- public function testConnectingFailsIfDnsUsesInvalidResolver()`
	`102`	`+ public function testConnectingFailsIfConnectorUsesInvalidDnsResolverAddress()`
`103`	`103`	`{`
`104`	`104`	`$loop = Factory::create();`
`105`	`105`
`106`	`106`	`$factory = new ResolverFactory();`
`107`		`- $dns = $factory->create('demo.invalid', $loop);`
	`107`	`+ $dns = $factory->create('255.255.255.255', $loop);`
`108`	`108`
`109`	`109`	`$connector = new Connector($loop, array(`
`110`	`110`	`'dns' => $dns`