Consistently report default errno when ext-sockets is not available

Author: clue

src/StreamEncryption.php

@@ -126,7 +126,7 @@ public function toggleCrypto($socket, Deferred $deferred, $toggle, $method)
                 // EOF or failed without error => connection closed during handshake
                 $d->reject(new \UnexpectedValueException(
                     'Connection lost during TLS handshake',
-                    \defined('SOCKET_ECONNRESET') ? \SOCKET_ECONNRESET : 0
+                    \defined('SOCKET_ECONNRESET') ? \SOCKET_ECONNRESET : 104
                 ));
             } else {
                 // handshake failed with error message

src/TimeoutConnector.php

@@ -41,7 +41,7 @@ private static function handler($uri)
             if ($e instanceof TimeoutException) {
                 throw new \RuntimeException(
                     'Connection to ' . $uri . ' timed out after ' . $e->getTimeout() . ' seconds',
-                    \defined('SOCKET_ETIMEDOUT') ? \SOCKET_ETIMEDOUT : 0
+                    \defined('SOCKET_ETIMEDOUT') ? \SOCKET_ETIMEDOUT : 110
                 );
             }
 

tests/FunctionalSecureServerTest.php

@@ -664,11 +664,11 @@ public function testEmitsErrorIfConnectionIsClosedBeforeHandshake()
 
         $error = Block\await($errorEvent, $loop, self::TIMEOUT);
 
-        // Connection from tcp://127.0.0.1:39528 failed during TLS handshake: Connection lost during TLS handshak
+        // Connection from tcp://127.0.0.1:39528 failed during TLS handshake: Connection lost during TLS handshake
         $this->assertInstanceOf('RuntimeException', $error);
         $this->assertStringStartsWith('Connection from tcp://', $error->getMessage());
         $this->assertStringEndsWith('failed during TLS handshake: Connection lost during TLS handshake', $error->getMessage());
-        $this->assertEquals(defined('SOCKET_ECONNRESET') ? SOCKET_ECONNRESET : 0, $error->getCode());
+        $this->assertEquals(defined('SOCKET_ECONNRESET') ? SOCKET_ECONNRESET : 104, $error->getCode());
         $this->assertNull($error->getPrevious());
     }
 
@@ -692,11 +692,11 @@ public function testEmitsErrorIfConnectionIsClosedWithIncompleteHandshake()
 
         $error = Block\await($errorEvent, $loop, self::TIMEOUT);
 
-        // Connection from tcp://127.0.0.1:39528 failed during TLS handshake: Connection lost during TLS handshak
+        // Connection from tcp://127.0.0.1:39528 failed during TLS handshake: Connection lost during TLS handshake
         $this->assertInstanceOf('RuntimeException', $error);
         $this->assertStringStartsWith('Connection from tcp://', $error->getMessage());
         $this->assertStringEndsWith('failed during TLS handshake: Connection lost during TLS handshake', $error->getMessage());
-        $this->assertEquals(defined('SOCKET_ECONNRESET') ? SOCKET_ECONNRESET : 0, $error->getCode());
+        $this->assertEquals(defined('SOCKET_ECONNRESET') ? SOCKET_ECONNRESET : 104, $error->getCode());
         $this->assertNull($error->getPrevious());
     }
 

tests/TimeoutConnectorTest.php

@@ -34,13 +34,17 @@ public function testRejectsWithTimeoutReasonOnTimeout()
 
         $timeout = new TimeoutConnector($connector, 0.01, $loop);
 
-        $this->setExpectedException('RuntimeException', 'Connection to google.com:80 timed out after 0.01 seconds');
+        $this->setExpectedException(
+            'RuntimeException',
+            'Connection to google.com:80 timed out after 0.01 seconds',
+            \defined('SOCKET_ETIMEDOUT') ? \SOCKET_ETIMEDOUT : 110
+        );
         Block\await($timeout->connect('google.com:80'), $loop);
     }
 
     public function testRejectsWithOriginalReasonWhenConnectorRejects()
     {
-        $promise = Promise\reject(new \RuntimeException('Failed'));
+        $promise = Promise\reject(new \RuntimeException('Failed', 42));
 
         $connector = $this->getMockBuilder('React\Socket\ConnectorInterface')->getMock();
         $connector->expects($this->once())->method('connect')->with('google.com:80')->will($this->returnValue($promise));
@@ -49,7 +53,11 @@ public function testRejectsWithOriginalReasonWhenConnectorRejects()
 
         $timeout = new TimeoutConnector($connector, 5.0, $loop);
 
-        $this->setExpectedException('RuntimeException', 'Failed');
+        $this->setExpectedException(
+            'RuntimeException',
+            'Failed',
+            42
+        );
         Block\await($timeout->connect('google.com:80'), $loop);
     }