Update to require PHP 7.1+

Author: clue

.github/workflows/ci.yml

@@ -22,20 +22,13 @@ jobs:
           - 7.3
           - 7.2
           - 7.1
-          - 7.0
-          - 5.6
-          - 5.5
-          - 5.4
-          - 5.3
     steps:
       - uses: actions/checkout@v4
       - uses: shivammathur/setup-php@v2
         with:
           php-version: ${{ matrix.php }}
           coverage: xdebug
           ini-file: development
-      - run: composer config secure-http false && composer config repo.packagist composer http://packagist.org && composer config preferred-install source
-        if: ${{ matrix.php < 5.5 && matrix.os == 'windows-2022' }} # legacy PHP on Windows is allowed to use insecure downloads until it will be removed again
       - run: composer install
       - run: vendor/bin/phpunit --coverage-text
         if: ${{ matrix.php >= 7.3 }}
@@ -54,19 +47,3 @@ jobs:
           coverage: xdebug
       - run: composer install
       - run: vendor/bin/phpunit --coverage-text
-
-  PHPUnit-hhvm:
-    name: PHPUnit (HHVM)
-    runs-on: ubuntu-22.04
-    continue-on-error: true
-    steps:
-      - uses: actions/checkout@v4
-      - run: cp "$(which composer)" composer.phar && ./composer.phar self-update --2.2 # downgrade Composer for HHVM
-      - name: Run hhvm composer.phar install
-        uses: docker://hhvm/hhvm:3.30-lts-latest
-        with:
-          args: hhvm composer.phar install
-      - name: Run hhvm vendor/bin/phpunit
-        uses: docker://hhvm/hhvm:3.30-lts-latest
-        with:
-          args: hhvm vendor/bin/phpunit

README.md

@@ -472,7 +472,7 @@ $socket = new React\Socket\SocketServer('tls://127.0.0.1:8000', array(
 ```
 
 By default, this server supports TLSv1.0+ and excludes support for legacy
-SSLv2/SSLv3. As of PHP 5.6+ you can also explicitly choose the TLS version you
+SSLv2/SSLv3. You can also explicitly choose the TLS version you
 want to negotiate with the remote side:
 
 ```php
@@ -650,7 +650,7 @@ $server = new React\Socket\SecureServer($server, null, array(
 ```
 
 By default, this server supports TLSv1.0+ and excludes support for legacy
-SSLv2/SSLv3. As of PHP 5.6+ you can also explicitly choose the TLS version you
+SSLv2/SSLv3. You can also explicitly choose the TLS version you
 want to negotiate with the remote side:
 
 ```php
@@ -1087,7 +1087,7 @@ $connector->connect('tls://localhost:443')->then(function (React\Socket\Connecti
 ```
 
 By default, this connector supports TLSv1.0+ and excludes support for legacy
-SSLv2/SSLv3. As of PHP 5.6+ you can also explicitly choose the TLS version you
+SSLv2/SSLv3. You can also explicitly choose the TLS version you
 want to negotiate with the remote side:
 
 ```php
@@ -1370,7 +1370,7 @@ $secureConnector = new React\Socket\SecureConnector($dnsConnector, null, array(
 ```
 
 By default, this connector supports TLSv1.0+ and excludes support for legacy
-SSLv2/SSLv3. As of PHP 5.6+ you can also explicitly choose the TLS version you
+SSLv2/SSLv3. You can also explicitly choose the TLS version you
 want to negotiate with the remote side:
 
 ```php
@@ -1490,17 +1490,8 @@ composer require react/socket:^3@dev
 See also the [CHANGELOG](CHANGELOG.md) for details about version upgrades.
 
 This project aims to run on any platform and thus does not require any PHP
-extensions and supports running on legacy PHP 5.3 through current PHP 8+ and HHVM.
-It's *highly recommended to use the latest supported PHP version* for this project,
-partly due to its vast performance improvements and partly because legacy PHP
-versions require several workarounds as described below.
-
-Secure TLS connections received some major upgrades starting with PHP 5.6, with
-the defaults now being more secure, while older versions required explicit
-context options.
-This library does not take responsibility over these context options, so it's
-up to consumers of this library to take care of setting appropriate context
-options as described above.
+extensions and supports running on PHP 7.1 through current PHP 8+.
+It's *highly recommended to use the latest supported PHP version* for this project.
 
 PHP < 7.3.3 (and PHP < 7.2.15) suffers from a bug where feof() might
 block with 100% CPU usage on fragmented TLS records.
@@ -1511,21 +1502,13 @@ cause very large data chunks for high throughput scenarios. The buggy
 behavior can still be triggered due to network I/O buffers or
 malicious peers on affected versions, upgrading is highly recommended.
 
-PHP < 7.1.4 (and PHP < 7.0.18) suffers from a bug when writing big
+PHP < 7.1.4 suffers from a bug when writing big
 chunks of data over TLS streams at once.
 We try to work around this by limiting the write chunk size to 8192
 bytes for older PHP versions only.
 This is only a work-around and has a noticable performance penalty on
 affected versions.
 
-This project also supports running on HHVM.
-Note that really old HHVM < 3.8 does not support secure TLS connections, as it
-lacks the required `stream_socket_enable_crypto()` function.
-As such, trying to create a secure TLS connections on affected versions will
-return a rejected promise instead.
-This issue is also covered by our test suite, which will skip related tests
-on affected versions.
-
 ## Tests
 
 To run the test suite, you first need to clone this repo and then install all

composer.json

@@ -26,16 +26,16 @@
         }
     ],
     "require": {
-        "php": ">=5.3.0",
+        "php": ">=7.1",
         "evenement/evenement": "^3.0 || ^2.0 || ^1.0",
         "react/dns": "^1.11",
         "react/event-loop": "^1.2",
         "react/promise": "^3 || ^2.6 || ^1.2.1",
         "react/stream": "^1.2"
     },
     "require-dev": {
-        "phpunit/phpunit": "^9.6 || ^5.7 || ^4.8.36",
-        "react/async": "^4 || ^3 || ^2",
+        "phpunit/phpunit": "^9.6 || ^5.7",
+        "react/async": "^4 || ^3",
         "react/promise-stream": "^1.4",
         "react/promise-timer": "^1.10"
     },

phpunit.xml.legacy

@@ -2,7 +2,7 @@
 
 <!-- PHPUnit configuration file with old format for legacy PHPUnit -->
 <phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-         xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/4.8/phpunit.xsd"
+         xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/5.7/phpunit.xsd"
          bootstrap="vendor/autoload.php"
          colors="true">
     <testsuites>

src/Connection.php

@@ -43,8 +43,8 @@ class Connection extends EventEmitter implements ConnectionInterface
 
     public function __construct($resource, LoopInterface $loop)
     {
-        // PHP < 7.3.3 (and PHP < 7.2.15) suffers from a bug where feof() might
-        // block with 100% CPU usage on fragmented TLS records.
+        // Legacy PHP < 7.3.3 (and PHP < 7.2.15) suffers from a bug where feof()
+        // might block with 100% CPU usage on fragmented TLS records.
         // We try to work around this by always consuming the complete receive
         // buffer at once to avoid stale data in TLS buffers. This is known to
         // work around high CPU usage for well-behaving peers, but this may
@@ -54,15 +54,15 @@ public function __construct($resource, LoopInterface $loop)
         // @link https://bugs.php.net/bug.php?id=77390
         $clearCompleteBuffer = \PHP_VERSION_ID < 70215 || (\PHP_VERSION_ID >= 70300 && \PHP_VERSION_ID < 70303);
 
-        // PHP < 7.1.4 (and PHP < 7.0.18) suffers from a bug when writing big
+        // Legacy PHP < 7.1.4 suffers from a bug when writing big
         // chunks of data over TLS streams at once.
         // We try to work around this by limiting the write chunk size to 8192
         // bytes for older PHP versions only.
         // This is only a work-around and has a noticable performance penalty on
         // affected versions. Please update your PHP version.
         // This applies to all streams because TLS may be enabled later on.
         // See https://github.com/reactphp/socket/issues/105
-        $limitWriteChunks = (\PHP_VERSION_ID < 70018 || (\PHP_VERSION_ID >= 70100 && \PHP_VERSION_ID < 70104));
+        $limitWriteChunks = \PHP_VERSION_ID < 70104;
 
         $this->input = new DuplexResourceStream(
             $resource,
@@ -157,22 +157,17 @@ private function parseAddress($address)
         }
 
         if ($this->unix) {
-            // remove trailing colon from address for HHVM < 3.19: https://3v4l.org/5C1lo
-            // note that technically ":" is a valid address, so keep this in place otherwise
-            if (\substr($address, -1) === ':' && \defined('HHVM_VERSION_ID') && \HHVM_VERSION_ID < 31900) {
-                $address = (string)\substr($address, 0, -1); // @codeCoverageIgnore
-            }
-
-            // work around unknown addresses should return null value: https://3v4l.org/5C1lo and https://bugs.php.net/bug.php?id=74556
-            // PHP uses "\0" string and HHVM uses empty string (colon removed above)
-            if ($address === '' || $address[0] === "\x00" ) {
+            // Legacy PHP < 7.1.7 may use "\0" string instead of false: https://3v4l.org/5C1lo and https://bugs.php.net/bug.php?id=74556
+            // Work around by returning null for "\0" string
+            if ($address[0] === "\x00" ) {
                 return null; // @codeCoverageIgnore
             }
 
             return 'unix://' . $address;
         }
 
-        // check if this is an IPv6 address which includes multiple colons but no square brackets
+        // Legacy PHP < 7.3 uses IPv6 address which includes multiple colons but no square brackets: https://bugs.php.net/bug.php?id=76136
+        // Work around by adding square brackets around IPv6 address when not already present
         $pos = \strrpos($address, ':');
         if ($pos !== false && \strpos($address, ':') < $pos && \substr($address, 0, 1) !== '[') {
             $address = '[' . \substr($address, 0, $pos) . ']:' . \substr($address, $pos + 1); // @codeCoverageIgnore

src/SecureConnector.php

@@ -5,9 +5,6 @@
 use React\EventLoop\Loop;
 use React\EventLoop\LoopInterface;
 use React\Promise;
-use BadMethodCallException;
-use InvalidArgumentException;
-use UnexpectedValueException;
 
 final class SecureConnector implements ConnectorInterface
 {
@@ -24,10 +21,6 @@ public function __construct(ConnectorInterface $connector, LoopInterface $loop =
 
     public function connect($uri)
     {
-        if (!\function_exists('stream_socket_enable_crypto')) {
-            return Promise\reject(new \BadMethodCallException('Encryption not supported on your platform (HHVM < 3.8?)')); // @codeCoverageIgnore
-        }
-
         if (\strpos($uri, '://') === false) {
             $uri = 'tls://' . $uri;
         }

src/SecureServer.php

@@ -5,8 +5,6 @@
 use Evenement\EventEmitter;
 use React\EventLoop\Loop;
 use React\EventLoop\LoopInterface;
-use BadMethodCallException;
-use UnexpectedValueException;
 
 /**
  * The `SecureServer` class implements the `ServerInterface` and is responsible
@@ -118,16 +116,11 @@ final class SecureServer extends EventEmitter implements ServerInterface
      * @param ServerInterface|TcpServer $tcp
      * @param ?LoopInterface $loop
      * @param array $context
-     * @throws BadMethodCallException for legacy HHVM < 3.8 due to lack of support
      * @see TcpServer
      * @link https://www.php.net/manual/en/context.ssl.php for TLS context options
      */
     public function __construct(ServerInterface $tcp, LoopInterface $loop = null, array $context = array())
     {
-        if (!\function_exists('stream_socket_enable_crypto')) {
-            throw new \BadMethodCallException('Encryption not supported on your platform (HHVM < 3.8?)'); // @codeCoverageIgnore
-        }
-
         // default to empty passphrase to suppress blocking passphrase prompt
         $context += array(
             'passphrase' => ''

src/StreamEncryption.php

@@ -26,19 +26,18 @@ public function __construct(LoopInterface $loop, $server = true)
 
         // support TLSv1.0+ by default and exclude legacy SSLv2/SSLv3.
         // As of PHP 7.2+ the main crypto method constant includes all TLS versions.
-        // As of PHP 5.6+ the crypto method is a bitmask, so we explicitly include all TLS versions.
-        // For legacy PHP < 5.6 the crypto method is a single value only and this constant includes all TLS versions.
+        // In prior PHP versions, the crypto method is a bitmask, so we explicitly include all TLS versions.
         // @link https://3v4l.org/9PSST
         if ($server) {
             $this->method = \STREAM_CRYPTO_METHOD_TLS_SERVER;
 
-            if (\PHP_VERSION_ID < 70200 && \PHP_VERSION_ID >= 50600) {
+            if (\PHP_VERSION_ID < 70200) {
                 $this->method |= \STREAM_CRYPTO_METHOD_TLSv1_0_SERVER | \STREAM_CRYPTO_METHOD_TLSv1_1_SERVER | \STREAM_CRYPTO_METHOD_TLSv1_2_SERVER; // @codeCoverageIgnore
             }
         } else {
             $this->method = \STREAM_CRYPTO_METHOD_TLS_CLIENT;
 
-            if (\PHP_VERSION_ID < 70200 && \PHP_VERSION_ID >= 50600) {
+            if (\PHP_VERSION_ID < 70200) {
                 $this->method |= \STREAM_CRYPTO_METHOD_TLSv1_0_CLIENT | \STREAM_CRYPTO_METHOD_TLSv1_1_CLIENT | \STREAM_CRYPTO_METHOD_TLSv1_2_CLIENT; // @codeCoverageIgnore
             }
         }

src/TcpConnector.php

@@ -62,22 +62,9 @@ public function connect($uri)
                 'SNI_enabled' => true,
                 'peer_name' => $args['hostname']
             );
-
-            // Legacy PHP < 5.6 ignores peer_name and requires legacy context options instead.
-            // The SNI_server_name context option has to be set here during construction,
-            // as legacy PHP ignores any values set later.
-            // @codeCoverageIgnoreStart
-            if (\PHP_VERSION_ID < 50600) {
-                $context['ssl'] += array(
-                    'SNI_server_name' => $args['hostname'],
-                    'CN_match' => $args['hostname']
-                );
-            }
-            // @codeCoverageIgnoreEnd
         }
 
-        // latest versions of PHP no longer accept any other URI components and
-        // HHVM fails to parse URIs with a query but no path, so let's simplify our URI here
+        // PHP 7.1.4 does not accept any other URI components (such as a query with no path), so let's simplify our URI here
         $remote = 'tcp://' . $parts['host'] . ':' . $parts['port'];
 
         $stream = @\stream_socket_client(
@@ -108,7 +95,7 @@ public function connect($uri)
                     // If we reach this point, we know the connection is dead, but we don't know the underlying error condition.
                     // @codeCoverageIgnoreStart
                     if (\function_exists('socket_import_stream')) {
-                        // actual socket errno and errstr can be retrieved with ext-sockets on PHP 5.4+
+                        // actual socket errno and errstr can be retrieved with ext-sockets
                         $socket = \socket_import_stream($stream);
                         $errno = \socket_get_option($socket, \SOL_SOCKET, \SO_ERROR);
                         $errstr = \socket_strerror($errno);
@@ -149,13 +136,6 @@ public function connect($uri)
             $loop->removeWriteStream($stream);
             \fclose($stream);
 
-            // @codeCoverageIgnoreStart
-            // legacy PHP 5.3 sometimes requires a second close call (see tests)
-            if (\PHP_VERSION_ID < 50400 && \is_resource($stream)) {
-                \fclose($stream);
-            }
-            // @codeCoverageIgnoreEnd
-
             throw new \RuntimeException(
                 'Connection to ' . $uri . ' cancelled during TCP/IP handshake (ECONNABORTED)',
                 \defined('SOCKET_ECONNABORTED') ? \SOCKET_ECONNABORTED : 103

src/UnixServer.php

@@ -68,7 +68,6 @@ public function __construct($path, LoopInterface $loop = null, array $context =
         \set_error_handler(function ($_, $error) use (&$errno, &$errstr) {
             // PHP does not seem to report errno/errstr for Unix domain sockets (UDS) right now.
             // This only applies to UDS server sockets, see also https://3v4l.org/NAhpr.
-            // Parse PHP warning message containing unknown error, HHVM reports proper info at least.
             if (\preg_match('/\(([^\)]+)\)|\[(\d+)\]: (.*)/', $error, $match)) {
                 $errstr = isset($match[3]) ? $match['3'] : $match[1];
                 $errno = isset($match[2]) ? (int)$match[2] : 0;