Skip to content

Commit 2381cc8

Browse files
committed
Fix stacking context bug in offcanvas menu
1 parent 5b035ec commit 2381cc8

File tree

8 files changed

+22
-11
lines changed

8 files changed

+22
-11
lines changed

static-files/assets/3.284c81ab.css

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

static-files/assets/3.e4b0adb9.css

Lines changed: 0 additions & 1 deletion
This file was deleted.

static-files/assets/main.9d0a7f20.css renamed to static-files/assets/main.d1256f64.css

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

static-files/assets/manifest.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
{
2-
"main.css": "main.9d0a7f20.css",
2+
"main.css": "main.d1256f64.css",
33
"main.js": "main.f372b8b9.js",
4-
"runtime.js": "runtime.79766d03.js",
4+
"runtime.js": "runtime.c39e0f59.js",
55
"2.0f8f4948.js": "2.0f8f4948.js",
6-
"3.e4b0adb9.css": "3.e4b0adb9.css",
6+
"3.284c81ab.css": "3.284c81ab.css",
77
"3.ca2827c9.js": "3.ca2827c9.js",
88
"4.87863994.css": "4.87863994.css",
99
"4.7d534a7e.js": "4.7d534a7e.js",

static-files/assets/runtime.79766d03.js renamed to static-files/assets/runtime.c39e0f59.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

theme/assets/components/off-canvas-menu/index.css

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,5 +4,9 @@
44
position: fixed;
55
top: 0;
66
right: 0;
7+
pointer-events: none;
8+
}
9+
10+
.off-canvas-menu__content {
711
transform: translate3d(105%, 0, 0);
812
}

theme/assets/components/off-canvas-menu/menu.css

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,10 @@
66
z-index: 1000;
77
overflow-y: auto;
88
overflow-x: hidden;
9-
-webkit-overflow-scrolling: touch;
10-
transition: all .35s cubic-bezier(0.23, 1, 0.32, 1);
11-
129
outline: none;
1310

1411
&[aria-hidden="false"] {
15-
transform: translate3D(0, 0, 0);
12+
pointer-events: auto;
1613
}
1714
}
1815

@@ -21,9 +18,19 @@
2118
right: 0;
2219
width: 285px;
2320
height: 100%;
21+
overflow-y: auto;
2422
overflow-x: hidden;
2523
background: var(--color-background-lightest);
2624
box-shadow: 0 0 15px rgba(0, 0, 0, 0.33);
25+
26+
-webkit-overflow-scrolling: touch;
27+
transition: all .35s cubic-bezier(0.23, 1, 0.32, 1);
28+
}
29+
30+
.off-canvas-menu[aria-hidden="false"] {
31+
& .off-canvas-menu__content {
32+
transform: translate3D(0, 0, 0);
33+
}
2734
}
2835

2936
.off-canvas-menu__close {

theme/partials/header_menu.html.twig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
</div>
88
</button>
99
</div>
10-
<nav id="off-canvas-menu" class="off-canvas-menu" aria-hidden="true">
10+
<nav id="off-canvas-menu" class="off-canvas-menu" aria-hidden="true" tabindex="0">
1111
<div class="off-canvas-menu__content">
1212
<button aria-label="Close menu" class="off-canvas-menu__close" data-ctrly="off-canvas-menu" data-off-canvas-menu-control>
1313
<i class="icon-x" aria-hidden="true"></i>

0 commit comments

Comments
 (0)