Skip to content

Commit 7957b33

Browse files
authored
improve github token generation section (#1012)
I actually started to follow the wiks using the docs, and only then noticed there's this convenient direct link to creating a token
1 parent f82f092 commit 7957b33

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

docs/guide-release-testing.md

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -59,21 +59,21 @@ Followed by the options:
5959
-c, --ciToken [string]
6060
```
6161

62-
Using the `-c <your-token>` option is recommended, as the script will download the required artifacts from Github, instead of having to build from source reducing the testing time. It's suggested to store your [Github Personal Access Token (classic)](https://docs.github.com/en/authentication/keeping-your-account-and-data-secure/managing-your-personal-access-tokens#personal-access-tokens-classic) using:
63-
64-
```bash
65-
export GITHUB_TOKEN=<token>
66-
```
62+
Using the `-c <your-token>` option is recommended, as the script will download the required artifacts from GitHub, instead of having to build from source reducing the testing time.
6763

6864
> [!Warning]
6965
> If you are testing versions of React Native that are < 0.75, you need a CircleCI token rather than a GitHub Token.
7066
> Follow [these instruction](https://circleci.com/docs/managing-api-tokens/) to learn how to create one.
7167
72-
Use [this link](https://github.com/settings/tokens/new?description=React%20Native%20Releases&scopes=repo) to generate a token with the Repo scope.
68+
Use [this link](https://github.com/settings/tokens/new?description=React%20Native%20Releases&scopes=repo) to generate a token with the Repo scope. Then you can store it using:
69+
70+
```bash
71+
export GITHUB_TOKEN=<token>
72+
```
7373

7474
There are a couple of extra requirements to make this flow work:
7575

76-
1. the CI must have run at least once in the current branch. We need to download artifacts generated by Github, so we need to have at least one run of the CI.
76+
1. the CI must have run at least once in the current branch. We need to download artifacts generated by GitHub, so we need to have at least one run of the CI.
7777
2. The relevant jobs must have been finished. The required jobs depends on the task you are about to test:
7878
- if you are testing RNTester on iOS, it has to download Hermes for iOS. So the job that produces it must have finished successfully
7979
- if you are testing RNTester on Android, it has to download the right APK (JSC or Hermes). So the job that produces the APKs must have finished successfully.
@@ -84,7 +84,7 @@ If any of those prerequisites is not met, the script should output a proper erro
8484
> [!Warning]
8585
> CI artifacts are only taken from the _last_ commit. This means everytime you push to your release branch, you'll have to wait for the artifacts to build again. You cannot release test using artifacts from an "older" commit. Plan accordingly.
8686
87-
If you need to build React Native from source, you can skip the `-c` parameter. By not passing the Github token, the script falls back to the previous flow, building everything locally.
87+
If you need to build React Native from source, you can skip the `-c` parameter. By not passing the GitHub token, the script falls back to the previous flow, building everything locally.
8888

8989
## Dimensions to test (RN >= 0.79)
9090

0 commit comments

Comments
 (0)