Should we release 0.67.1?

[lunaleaps]

Should we release 0.67.1?

0.67.1 has been released. See discussion for 0.67.2

Current release: 0.67.0

Conversations on this thread are limited:

• major release issues
• qualified cherry-pick requests of commits on main that did not make the previous patch version.

Please include a link to the specific commit on main to be cherry-picked, for example: facebook/react-native@bd2b7d6

In other words, if you cannot point to a particular commit on main, then your request likely belongs as a new issue.
If the issue is a major release issue, please reference the issue here.

---

List of qualified picks

1. Remove alert's window when call to hide. (a46a99e120 by @asafkorem)
2. Do not remove libjscexecutor.so from release builds (574a773f8f by @cortinico)

Local commits to backport to main

[numandev1]

in 0.67.0, we are using [email protected] but for fabric and turbomodule, the recommended version is 0.0.12,
so please pick facebook/react-native@74f3913

[numandev1]

https://github.com/facebook/react-native-website/pull/2879/files I was talking about the playbook, Currently, New architecture is published in the nightly releases.

[kelset]

@cortinico - what do you think?

[cortinico]

I think that cherry-picking would be a "nice-to-have" for a potential 0.67.1 but it's not raising the need for a point release IMHO.

@nomi9995 you're correct to call out that the recommended version to use for react-native-codegen is essentially the latest published. On the other hand, the Playbook currently relies on nightly versions of RN.

Moreover, we're leveraging the NPM semantic versioning system meaning that having "^0.0.11" as version specified will effectively fetch the latest minor version for you (in this case being 0.0.12).

EDIT: typo

[tido64]

Moreover, we're leveraging the NPM semantic versioning system meaning that having "^0.0.11" as version specified will effectively fetch the latest minor version for you (in this case being 0.0.12).

This is a common misconception. ^0.0.11 is actually equivalent to 0.0.11. Semver drop the leading zeroes. You can check it yourself here: https://semver.npmjs.com/

Regardless, agreed that bumping react-native-codegen does not warrant a .1 release.

[cortinico]

Semver drop the leading zeroes

TIL :O Thanks for clarifying @tido64 👍

[asafkorem]

I suggest to cherrypick facebook/react-native@a46a99e, this fixes a serious bug with UI alerts on iOS.

[lunaleaps]

Picking

[kelset]

We are aware of an insta-crash problem when building Android release builds and NOT using Hermes: facebook/react-native#32928 - a PR with a fix is already on its way, will post the commit once it's ready.

[cortinico]

The commit is live facebook/react-native@574a773

[lunaleaps]

Picking

[kelset]

nit: we need to remove from changelog this entry facebook/react-native@6e903b0 from here https://github.com/facebook/react-native/blob/main/CHANGELOG.md#ios-specific since it was reverted facebook/react-native@8595f3f - we can do that when doing the changelog PR for 0.67.1