Should we release 0.72.1?

[kelset]

Released: refer to #76

Current Release: 0.72.0

Conversations on this thread are limited:

• major release issues.
• qualified cherry-pick requests of commits on main that did not make the previous patch version.

Please include a link to the specific commit on main to be cherry-picked, for example: facebook/react-native@bd2b7d6

In other words, if you cannot point to a particular commit on main, then your request likely belongs as a new issue.
If the issue is a major release issues, please reference the issue here.

---

List of issues we're aware of

• rn-diff-purge pipeline is failing, no diff on upgrade-helper
  • actively getting investigated, tentative fix CLI side available (fix: init when there's a package.json in folder react-native-community/cli#1980) -> fixed ✅
• 0.72: websockets malformed authorization headers only on iOS facebook/react-native#38012
  • workaround available, waiting on socketrocket to release patched version
• 0.72: Remote debugging broken on Android facebook/react-native#38006
• TextView on production nuking app with OverlappingFileLockException facebook/react-native#37871
• RN 0.72 - Text component dynamic color style issue facebook/react-native#37944

List of qualified picks

1. ✅ facebook/react-native@377a8b7
2. ✅ facebook/react-native@7a2a327
3. 🦘facebook/react-native@247da6e (merge conflict - skipping)
4. ✅ facebook/react-native@a28881a
5. ✅ facebook/react-native@a702d05
6. ✅ facebook/react-native@ebbd22c
7. ✅ facebook/react-native@bbcedd3
8. ✅ facebook/react-native@83d7a48
9. plus, local work:
   1. ✅ reimplement [LOCAL] Set kotlin.jvm.target.validation.mode=warning on user projects facebook/react-native#37869
   2. ✅ bump CLI to 11.3.3
   3. 🟡 bump socketrocket once new release is out: https://github.com/facebookincubator/SocketRocket/commits/main
   • socketRocket 0.7.0 contains some incompatible bumps, so we need the maintainer to release 0.6.1 with just the hotfix that we need.

not merged at the time of release:

• Set size of Modal only once on Android facebook/react-native#35803
• Add global hook to assert that base Metro config is called facebook/react-native#38126

Local commits to backport to main

1. facebook/react-native@8ce471e

[efstathiosntonas]

Just a heads up, react native upgrade helper does not contain 0.72, only the RC ones

[efstathiosntonas]

@kelset the CHANGELOG has grown really big thus rendering it unreadable (This blob took too long to generate), do you think you should split it? Had to download the file and enter it on an .md reader to read it, reading the raw requires Superman vision lol

[kelset]

oh lol that's a new one 🤣 yeah we can try to chop it down, @lunaleaps was advocating for that too. I'll try to prep something up.

[kelset]

PR is up facebook/react-native#38017

[kelset]

fixed -> https://react-native-community.github.io/upgrade-helper/?from=0.71.11&to=0.72.0

[kelset]

CLI got a release with the fix, we need the bump to CLI 11.3.3 -> https://github.com/react-native-community/cli/commits/11.x

[johnf]

Ignore this. I had react-native-codegen: ^0.71.0 in package.json. Not sure why I had it there at all as it's not needed

[efstathiosntonas]

Can you please merge this PR for SocketRocket?

It solves this issue facebook/react-native#38012

[cipolleschi]

working on it. The PR has been merged, but the maintainer would like to do some other work and will try to release a new version of SoketRocket early next week.

[efstathiosntonas]

@cipolleschi hi, @nlutsenko has released 0.7.0, just a heads up. Thanks @nlutsenko

[kelset]

@efstathiosntonas sadly that release also contains some incompatible bumps, so we need the maintainer to release 0.6.1 with just the hotfix that we need. It won't make it in time for 0.72.1 but we'll handle it for 0.72.2

[kelset]

plottwist: 0.6.1 has already been released so we should be able to include it

[efstathiosntonas]

Love the silence after the 1000 commits storm 😂

[Bardiamist]

Updated to 0.72.0 and have this problem: #54 (comment)

Looks this not helped for build from Android Studio: https://github.com/facebook/react-native/pull/37869/files
Maybe need to update react-native-gradle-plugin

Helped only add kotlin.jvm.target.validation.mode=warning into gradle.properties

[efstathiosntonas]

I've faced that too, on android/build.gradle add this at the very bottom:

// Workaround: Force all android libraries to use java 11.
// This is to fix the build errors from some third party libraries still using java 8,
// which cause gradle 8 errors:
// 'compileDebugJavaWithJavac' task (current target is 1.8) and 'compileDebugKotlin' task (current target is 11) jvm target compatibility should be set to the same Java version.
allprojects { subproject ->
    subproject.pluginManager.withPlugin("com.android.library") {
        subproject.extensions.findByType(com.android.build.api.variant.AndroidComponentsExtension)?.finalizeDsl { ext ->
            ext.compileOptions.sourceCompatibility = JavaVersion.VERSION_11
            ext.compileOptions.targetCompatibility = JavaVersion.VERSION_11
        }
    }
}

and on android/app/build.gradle add this inside the android {:

android {
    compileOptions {
        sourceCompatibility JavaVersion.VERSION_11
        targetCompatibility JavaVersion.VERSION_11
    }

    kotlinOptions {
        jvmTarget = JavaVersion.VERSION_11.majorVersion
    }
...

and on the same file add this on top right under apply plugin: "com.facebook.react"
apply plugin: "kotlin-android"

[Bardiamist]

React native 0.72 lands with @react-native/[email protected] https://github.com/facebook/react-native/blob/0.72-stable/packages/react-native/package.json#L87

When this change https://github.com/facebook/react-native/pull/37869/files in 0.73.0

[cortinico]

Hey all,
This is a known issue.
The correct fix is:

• [LOCAL] Set kotlin.jvm.target.validation.mode=warning on user projects facebook/react-native#37869
  This will be included in 0.72.1

As a workaround for everyone facing this same issue right now, you can add:

kotlin.jvm.target.validation.mode=warning

to your android/gradle.properties file.

[kelset]

yes, that change will make it to 0.72.1 - it landed after RC6 so we had to revert the local commit, we'll add it back in 0.72.1 - which will likely be out this week. Depends on status of other open issues

[cipolleschi]

Potentially, for the interop layer:

• Warn users when a component is registered in Rendere and in the interop facebook/react-native#38089
• Implement multiple manager lookup for the interop layer facebook/react-native#38093

[bernhardoj]

Hi, can we CP this commit, please:

• facebook/react-native@83d7a48

[huntie]

I'm landing this change (to pick, please 🙏🏻) and hopefully we also get a CLI bump in today. Non-blocking for 0.72.1 (is an enhancement).

• Add global hook to assert that base Metro config is called facebook/react-native#38126

[kelset]

added to the list for 0.72.2 👍