Skip to content

Commit 6232bbb

Browse files
UX: change read and unread icons to match industry conventions (#259)
1 parent 8652bc9 commit 6232bbb

File tree

5 files changed

+29
-10
lines changed

5 files changed

+29
-10
lines changed

app/src/main/java/com/readrops/app/item/components/ItemScreenBottomBar.kt

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -54,9 +54,11 @@ fun ItemScreenBottomBar(
5454
) {
5555
Icon(
5656
painter = painterResource(
57-
id = if (state.isRead)
58-
R.drawable.ic_remove_done
59-
else R.drawable.ic_done_all
57+
id = if (state.isRead) {
58+
R.drawable.ic_state_read
59+
} else {
60+
R.drawable.ic_state_unread
61+
}
6062
),
6163
tint = onAccentColor,
6264
contentDescription = null

app/src/main/java/com/readrops/app/timelime/components/TimelineItem.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,9 +81,9 @@ fun TimelineItem(
8181
fun getSwipeIcon(swipeAction: SwipeAction): Int {
8282
return if (swipeAction == SwipeAction.READ) {
8383
if (itemWithFeed.isRead) {
84-
R.drawable.ic_remove_done
84+
R.drawable.ic_state_unread
8585
} else {
86-
R.drawable.ic_done_all
86+
R.drawable.ic_state_read
8787
}
8888
} else {
8989
if (itemWithFeed.isStarred) {

app/src/main/res/drawable/ic_remove_done.xml

Lines changed: 0 additions & 5 deletions
This file was deleted.
Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
<vector xmlns:android="http://schemas.android.com/apk/res/android"
2+
android:width="24dp"
3+
android:height="24dp"
4+
android:tint="#000000"
5+
android:viewportWidth="960"
6+
android:viewportHeight="960">
7+
<path
8+
android:fillColor="@android:color/white"
9+
android:pathData="m480,40 l362,216q18,11 28,30t10,40v434q0,33 -23.5,56.5T800,840L160,840q-33,0 -56.5,-23.5T80,760v-434q0,-21 10,-40t28,-30l362,-216ZM480,506 L792,320 480,134 168,320 480,506ZM480,600L160,408v352h640v-352L480,600ZM480,760h320,-640 320Z"
10+
/>
11+
</vector>
Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
<vector xmlns:android="http://schemas.android.com/apk/res/android"
2+
android:width="24dp"
3+
android:height="24dp"
4+
android:tint="#000000"
5+
android:viewportWidth="24"
6+
android:viewportHeight="24">
7+
<path
8+
android:fillColor="@android:color/white"
9+
android:pathData="M22,6c0,-1.1 -0.9,-2 -2,-2L4,4c-1.1,0 -2,0.9 -2,2v12c0,1.1 0.9,2 2,2h16c1.1,0 2,-0.9 2,-2L22,6zM20,6l-8,5 -8,-5h16zM20,18L4,18L4,8l8,5 8,-5v10z"
10+
/>
11+
</vector>

0 commit comments

Comments
 (0)