Skip to content

Commit cbbb52b

Browse files
committed
Improve available actions in FeedColorScreen
1 parent 8d134c2 commit cbbb52b

File tree

5 files changed

+26
-7
lines changed

5 files changed

+26
-7
lines changed

app/src/main/java/com/readrops/app/feeds/color/FeedColorScreen.kt

Lines changed: 16 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,9 @@ class FeedColorScreen(val feed: Feed) : AndroidScreen() {
5454
val screenModel = koinScreenModel<FeedColorScreenModel> { parametersOf(feed) }
5555

5656
val state by screenModel.state.collectAsStateWithLifecycle()
57+
5758
val snackbarHostState = remember { SnackbarHostState() }
59+
val defaultColor = MaterialTheme.colorScheme.primary
5860

5961
if (state.canExit) {
6062
navigator.pop()
@@ -99,9 +101,7 @@ class FeedColorScreen(val feed: Feed) : AndroidScreen() {
99101
Column(
100102
modifier = Modifier
101103
.padding(innerPadding)
102-
.padding(
103-
vertical = MaterialTheme.spacing.shortSpacing
104-
)
104+
.padding(vertical = MaterialTheme.spacing.shortSpacing)
105105
) {
106106
Text(
107107
text = stringResource(R.string.preview),
@@ -169,6 +169,17 @@ class FeedColorScreen(val feed: Feed) : AndroidScreen() {
169169
onClick = { screenModel.reloadColor(context) },
170170
)
171171

172+
SelectableIconText(
173+
icon = painterResource(R.drawable.ic_reset_color),
174+
text = stringResource(R.string.use_default_color),
175+
style = MaterialTheme.typography.titleSmall,
176+
padding = MaterialTheme.spacing.mediumSpacing,
177+
spacing = MaterialTheme.spacing.mediumSpacing,
178+
iconSize = 24.dp,
179+
tint = MaterialTheme.colorScheme.primary,
180+
onClick = { screenModel.setNewColor(defaultColor) },
181+
)
182+
172183
SelectableIconText(
173184
icon = painterResource(R.drawable.ic_color),
174185
text = stringResource(R.string.select_color),
@@ -180,7 +191,7 @@ class FeedColorScreen(val feed: Feed) : AndroidScreen() {
180191
onClick = { screenModel.showColorPickerDialog() }
181192
)
182193

183-
SelectableIconText(
194+
/*SelectableIconText(
184195
icon = painterResource(R.drawable.ic_download),
185196
text = stringResource(R.string.load_color_new_favicon),
186197
style = MaterialTheme.typography.titleSmall,
@@ -189,7 +200,7 @@ class FeedColorScreen(val feed: Feed) : AndroidScreen() {
189200
iconSize = 24.dp,
190201
tint = MaterialTheme.colorScheme.primary,
191202
onClick = { }
192-
)
203+
)*/
193204

194205
LargeSpacer()
195206

app/src/main/java/com/readrops/app/feeds/dialogs/FeedBottomSheet.kt

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ import androidx.compose.material3.Icon
1515
import androidx.compose.material3.MaterialTheme
1616
import androidx.compose.material3.ModalBottomSheet
1717
import androidx.compose.material3.Text
18+
import androidx.compose.material3.rememberModalBottomSheetState
1819
import androidx.compose.runtime.Composable
1920
import androidx.compose.ui.Alignment
2021
import androidx.compose.ui.Modifier
@@ -25,7 +26,6 @@ import com.readrops.app.R
2526
import com.readrops.app.feeds.components.FeedBanner
2627
import com.readrops.app.more.preferences.components.BasePreference
2728
import com.readrops.app.util.components.SwitchText
28-
import com.readrops.app.util.theme.LargeSpacer
2929
import com.readrops.app.util.theme.MediumSpacer
3030
import com.readrops.app.util.theme.spacing
3131
import com.readrops.db.entities.Feed
@@ -47,6 +47,7 @@ fun FeedModalBottomSheet(
4747
canDeleteFeed: Boolean
4848
) {
4949
ModalBottomSheet(
50+
sheetState = rememberModalBottomSheetState(skipPartiallyExpanded = true),
5051
dragHandle = null,
5152
onDismissRequest = { onDismissRequest() }
5253
) {
@@ -105,7 +106,7 @@ fun FeedModalBottomSheet(
105106
}
106107
}
107108

108-
LargeSpacer()
109+
MediumSpacer()
109110
}
110111
}
111112

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
<vector xmlns:android="http://schemas.android.com/apk/res/android" android:height="24dp" android:tint="#000000" android:viewportHeight="24" android:viewportWidth="24" android:width="24dp">
2+
3+
<path android:fillColor="@android:color/white" android:pathData="M18,14c0,-4 -6,-10.8 -6,-10.8s-1.33,1.51 -2.73,3.52l8.59,8.59c0.09,-0.42 0.14,-0.86 0.14,-1.31zM17.12,17.12L12.5,12.5 5.27,5.27 4,6.55l3.32,3.32C6.55,11.32 6,12.79 6,14c0,3.31 2.69,6 6,6 1.52,0 2.9,-0.57 3.96,-1.5l2.63,2.63 1.27,-1.27 -2.74,-2.74z"/>
4+
5+
</vector>

app/src/main/res/values-fr/strings.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -202,4 +202,5 @@
202202
<string name="reload_color_favicon">Recharger la couleur à partir de la favicône</string>
203203
<string name="load_color_new_favicon">Charger la couleur depuis une nouvelle favicône</string>
204204
<string name="error_occurred_reloading_favicon_color">Une erreur est survenue lors du rechargement de la couleur de la favicône</string>
205+
<string name="use_default_color">Utiliser la couleur par défaut</string>
205206
</resources>

app/src/main/res/values/strings.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -211,4 +211,5 @@
211211
<string name="reload_color_favicon">Reload color from Favicon</string>
212212
<string name="load_color_new_favicon">Load color from a new favicon</string>
213213
<string name="error_occurred_reloading_favicon_color">An error occurred while reloading favicon color</string>
214+
<string name="use_default_color">Use default color</string>
214215
</resources>

0 commit comments

Comments
 (0)