-
Notifications
You must be signed in to change notification settings - Fork 20
Open
Labels
ImprovementMinor improvement to codeMinor improvement to codeNeeded: design decisionA core team decision is requiredA core team decision is required
Description
I found a few examples where some extra HTML tags are added to the DOM in current page the user is reading. At that point, if the user enables visual diff, it fetch the raw HTML file without applying any JavaScript modification to its DOM resulting on having a few diff chunks on places where the HTML didn't change in reality.
It seems that CPython adds a Copy button on their Python code chunks using JavaScript and we identify this as diff chunk:
<ins class="doc-diff-added">
<span class="copybutton" title="Hide the prompts and output" data-hidden="false">
>>>
</span>
</ins>I found this in python/cpython#125565, but it should happen in any other project that modifies the DOM using JavaScript. I'm sure what's the solution, but we may want to render the current DOM with JavaScript disabled and use that for the comparison.
Metadata
Metadata
Assignees
Labels
ImprovementMinor improvement to codeMinor improvement to codeNeeded: design decisionA core team decision is requiredA core team decision is required
Type
Projects
Status
Planned