Skip to content

Commit ef0acd3

Browse files
authored
Used modern Node for webpack, and us npm ci instead (#165)
This was using a crusty old Node version and was calling `npm install`, so the lock file was being updated and reverted to version 1. This was causing significant spin up time for the docker container. `npm ci` installs the exact dependencies used in the last build, so we can ensure a CI passing build will match the prod build closely.
1 parent ac1215e commit ef0acd3

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

dockerfiles/docker-compose-webpack.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ version: '3'
55
services:
66

77
webpack:
8-
image: node:12
8+
image: node:16
99
working_dir: /usr/src/app/checkouts/ext-theme
1010
ports:
1111
- "10001:10001"

dockerfiles/entrypoints/webpack.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
#! /bin/sh
22

3-
npm install
3+
npm ci
44

55
$(npm bin)/webpack-dev-server \
66
--mode=development \

0 commit comments

Comments
 (0)