readthedocs
diff --git a/‎dist/ethicalads.js‎
Lines changed: 1 addition & 1 deletion b/‎dist/ethicalads.js‎
Lines changed: 1 addition & 1 deletion
diff --git a/‎dist/ethicalads.min.js‎
Lines changed: 1 addition & 1 deletion b/‎dist/ethicalads.min.js‎
Lines changed: 1 addition & 1 deletion
diff --git a/‎index.js‎
Lines changed: 21 additions & 7 deletions b/‎index.js‎
Lines changed: 21 additions & 7 deletions
diff --git a/‎tests/priority-placement.test.html‎
Lines changed: 11 additions & 12 deletions b/‎tests/priority-placement.test.html‎
Lines changed: 11 additions & 12 deletions
@@ -517,6 +517,11 @@ export class Placement {
   static from_element(element) {
     // Get attributes from DOM node
     const publisher = element.getAttribute(ATTR_PREFIX + "publisher");
+    if (!publisher) {
+      logger.debug("Missing publisher value. Skipping...");
+      return null;
+    }
+
     let ad_type = element.getAttribute(ATTR_PREFIX + "type");
     if (!ad_type) {
       ad_type = "image";
@@ -1186,17 +1191,26 @@ export function load_placements(force_load = false) {
   }
 
   // Group prioritized placements
-  let priority_group = [];
+  let has_priority = false;
   placements.forEach((placement) => {
-    if (
-      placement &&
-      placement.priority !== null &&
-      (force_load || !placement.load_manually)
-    ) {
-      priority_group.push(placement);
+    if (placement && placement.priority !== null) {
+      has_priority = true;
     }
   });
 
+  let priority_group = [];
+  if (has_priority) {
+    placements.forEach((placement) => {
+      if (placement && (force_load || !placement.load_manually)) {
+        if (placement.priority === null) {
+          // Set default priority for non-prioritized placements
+          placement.priority = 1;
+        }
+        priority_group.push(placement);
+      }
+    });
+  }
+
   if (priority_group.length > 0) {
     Placement.fetchGroup(priority_group);
   }
 
@@ -1,11 +1,11 @@
 <html>
   <body>
     <!-- 3 placements, two with priorities -->
-    <!-- There will be 2 calls to the ad server: one for ad1 and ad2, and one for ad3 -->
+    <!-- There will be 1 call to the ad server for all ad1, ad2, and ad3 -->
 
     <div id="ad1" data-ea-publisher="test" data-ea-priority="1"></div>
     <div id="ad2" data-ea-publisher="test" data-ea-priority="2"></div>
-    <!-- standalone ad -->
+    <!-- standalone ad (gets default priority 1) -->
     <div id="ad3" data-ea-publisher="test"></div>
 
     <script type="module">
@@ -16,10 +16,10 @@
       import { wait, Placement } from "../index";
       import { mockAdDecision } from "./common.inc.js";
 
-      // Mock the regular fetch for ad3
+      // Mock the regular fetch
       let fetchStub = mockAdDecision();
 
-      // Mock the fetchGroup for ad1 and ad2
+      // Mock the fetchGroup for ad1, ad2, and ad3
       let groupStub = sinon
         .stub(Placement, "fetchGroup")
         .callsFake((placements) => {
@@ -43,26 +43,25 @@
         describe("EthicalAds library", () => {
           it("loads prioritized placements correctly", async () => {
             const placements = await wait;
-            // Placements that resolved with ads: only ad2 and ad3
-            expect(placements.length).to.equal(2);
+            // Placements that resolved with ads: only ad2
+            expect(placements.length).to.equal(1);
             expect(placements[0].target.id).to.equal("ad2");
-            expect(placements[1].target.id).to.equal("ad3");
 
             // Look at DOM directly
             const ad1 = document.getElementById("ad1");
             const ad2 = document.getElementById("ad2");
             const ad3 = document.getElementById("ad3");
 
-            // ad1 should NOT have the loaded class
+            // ad1 and ad3 should NOT have the loaded class
             expect(ad1.className).to.not.include("loaded");
+            expect(ad3.className).to.not.include("loaded");
 
-            // ad2 and ad3 should have the loaded class
+            // ad2 should have the loaded class
             expect(ad2.className).to.include("loaded");
-            expect(ad3.className).to.include("loaded");
 
-            // fetchGroup should have been called once with a group of 2
+            // fetchGroup should have been called once with a group of 3
             expect(groupStub.calledOnce).to.be.true;
-            expect(groupStub.firstCall.args[0].length).to.equal(2);
+            expect(groupStub.firstCall.args[0].length).to.equal(3);
           });
         });
       });