Skip to content

Commit 069abda

Browse files
authored
Development: always use webpack on development (#12182)
The Docker development environment always starts the `webpack` container since we removed the legacy dashboard. This PR makes the `webpack` server to be used by default when calling `inv docker.up`. <!-- readthedocs-preview docs start --> --- :books: Documentation previews :books: - User's documentation (`docs`): https://docs--12182.org.readthedocs.build/12182/ <!-- readthedocs-preview docs end --> <!-- readthedocs-preview dev start --> - Developer's documentation (`dev`): https://dev--12182.org.readthedocs.build/12182/ <!-- readthedocs-preview dev end -->
1 parent 1f7b59e commit 069abda

File tree

2 files changed

+2
-6
lines changed

2 files changed

+2
-6
lines changed

docs/dev/install.rst

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ Set up your environment
9191

9292
.. prompt:: bash
9393

94-
inv docker.up --ext-theme --webpack --init
94+
inv docker.up --init
9595

9696
.. warning::
9797

@@ -140,8 +140,6 @@ save some work while typing docker compose commands. This section explains these
140140
* ``--http-domain`` configures an external domain for the environment (useful for Ngrok or other http proxy).
141141
Note that https proxies aren't supported.
142142
There will also be issues with "suspicious domain" failures on Proxito.
143-
* ``--ext-theme`` to use the new dashboard templates
144-
* ``--webpack`` to start the Webpack dev server for the new dashboard templates
145143

146144
``inv docker.shell``
147145
Opens a shell in a container (web by default).

readthedocs/settings/docker_compose.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -61,9 +61,7 @@ def DOCROOT(self):
6161
return os.path.join(super().DOCROOT, socket.gethostname())
6262

6363
# New templates
64-
@property
65-
def RTD_EXT_THEME_DEV_SERVER_ENABLED(self):
66-
return os.environ.get("RTD_EXT_THEME_DEV_SERVER_ENABLED") is not None
64+
RTD_EXT_THEME_DEV_SERVER_ENABLED = True
6765

6866
@property
6967
def RTD_EXT_THEME_DEV_SERVER(self):

0 commit comments

Comments
 (0)