Skip to content

Commit 0e766a4

Browse files
authored
Build overview: link to commit comparison (#12292)
The text says we are comparing against a commit, so why not link to the commit comparison page. GH will render this as 4617dfa...ea12f92
1 parent 649a6ae commit 0e766a4

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

readthedocs/builds/tests/test_tasks.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -208,7 +208,7 @@ def test_post_build_overview(self, get_diff, post_comment):
208208
209209
### Files changed
210210
211-
> Comparing with [latest](http://my-project.readthedocs.io/en/latest/) (1234abcd)
211+
> Comparing with [latest](http://my-project.readthedocs.io/en/latest/) (1234abcd...5678abcd)
212212
213213
214214
<details>
@@ -257,7 +257,7 @@ def test_post_build_overview_more_than_5_files(self, get_diff, post_comment):
257257
258258
### Files changed
259259
260-
> Comparing with [latest](http://my-project.readthedocs.io/en/latest/) (1234abcd)
260+
> Comparing with [latest](http://my-project.readthedocs.io/en/latest/) (1234abcd...5678abcd)
261261
262262
263263
<details>
@@ -302,7 +302,7 @@ def test_post_build_overview_no_files_changed(self, get_diff, post_comment):
302302
303303
### Files changed
304304
305-
> Comparing with [latest](http://my-project.readthedocs.io/en/latest/) (1234abcd)
305+
> Comparing with [latest](http://my-project.readthedocs.io/en/latest/) (1234abcd...5678abcd)
306306
307307
308308
No files changed.

readthedocs/templates/core/build-overview.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ make sure to adjust the tags accordingly, as they introduce newlines.
1010
1111
### Files changed
1212

13-
> Comparing with [{{ base_version.verbose_name }}]({{ base_version.get_absolute_url }}) ({{ base_version_build.commit }})
13+
> Comparing with [{{ base_version.verbose_name }}]({{ base_version.get_absolute_url }}) ({{ base_version_build.commit }}...{{ current_version_build.commit }})
1414
1515
{% if diff.files %}
1616
<details>

0 commit comments

Comments
 (0)